Re: Review Request 114717: Language detection in Sonnet

2014-01-08 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114717/ --- (Updated Jan. 8, 2014, 7:24 p.m.) Status -- This change has been

Re: Review Request 114717: Language detection in Sonnet

2014-01-02 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114717/#review46626 --- README.md

Re: Review Request 114717: Language detection in Sonnet

2014-01-02 Thread Martin Tobias Holmedahl Sandsmark
On Jan. 2, 2014, 2:47 p.m., Vishesh Handa wrote: src/plugins/CMakeLists.txt, line 29 https://git.reviewboard.kde.org/r/114717/diff/1/?file=227733#file227733line29 We don't care about Enchant any more? it's seems to be unmaintained, is just an abstraction library, and it spammed my

Re: Review Request 114717: Language detection in Sonnet

2014-01-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114717/#review46650 --- src/core/settings.cpp

Re: Review Request 114717: Language detection in Sonnet

2013-12-29 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114717/#review46389 --- I wonder if we could use

Re: Review Request 114717: Language detection in Sonnet

2013-12-29 Thread Christoph Feck
On Dec. 29, 2013, 4:39 p.m., Àlex Fiestas wrote: I wonder if we could use https://code.google.com/p/chromium-compact-language-detector/, apparently it is known to be really small, fast and contained, what do you think? It probably has better detection (uses quadgraphs instead of

Re: Review Request 114717: Language detection in Sonnet

2013-12-29 Thread Martin Tobias Holmedahl Sandsmark
On Sun, Dec 29, 2013 at 05:46:33PM -, Christoph Feck wrote: It probably has better detection (uses quadgraphs instead of trigraphs), and covers more languages, but it hardly looks compact, with the cld2_generated_quad0720.cc file being over 20 megabytes large :) Exactly. I could probably

Review Request 114717: Language detection in Sonnet

2013-12-28 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114717/ --- Review request for kdelibs and KDEPIM. Repository: sonnet Description