Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-05 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/ --- Review request for kde-workspace and Martin Gräßlin. Bugs: 311571 and 316

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review46960 --- how does that behave with the normal locker (that is no screen

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-07 Thread Thomas Lübking
> On Jan. 7, 2014, 8:51 a.m., Martin Gräßlin wrote: > > how does that behave with the normal locker (that is no screensaver)? "None" is not "blank" - the patch is correct. If a cursor is specified, it is displayed regardless of what window the pointer is in. If None is specified, the normal cu

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-07 Thread Wolfgang Bauer
> On Jan. 7, 2014, 9:51 a.m., Martin Gräßlin wrote: > > how does that behave with the normal locker (that is no screensaver)? > > Thomas Lübking wrote: > "None" is not "blank" - the patch is correct. > > If a cursor is specified, it is displayed regardless of what window the > poin

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review47020 --- Ship it! If you have the possibility (build setup) please mer

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review47023 --- This review has been submitted with commit c1761755915ab59f41

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-08 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/ --- (Updated Jan. 8, 2014, 8:59 a.m.) Status -- This change has been mar

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-08 Thread Wolfgang Bauer
> On Jan. 8, 2014, 8:10 a.m., Martin Gräßlin wrote: > > If you have the possibility (build setup) please merge to master and fix > > the merge conflict I expect to see :-) I merged 4.11 into master yesterday > > so there should no be anything else which could conflict. I have committed to 4.11

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-08 Thread Martin Gräßlin
> On Jan. 8, 2014, 8:10 a.m., Martin Gräßlin wrote: > > If you have the possibility (build setup) please merge to master and fix > > the merge conflict I expect to see :-) I merged 4.11 into master yesterday > > so there should no be anything else which could conflict. > > Wolfgang Bauer wrote

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-08 Thread Wolfgang Bauer
> On Jan. 8, 2014, 8:10 a.m., Martin Gräßlin wrote: > > If you have the possibility (build setup) please merge to master and fix > > the merge conflict I expect to see :-) I merged 4.11 into master yesterday > > so there should no be anything else which could conflict. > > Wolfgang Bauer wrote