---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115497/#review49710
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115497/
---
(Updated Feb. 13, 2014, 2:31 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115497/
---
(Updated Feb. 11, 2014, 9:46 a.m.)
Review request for KDE Runtime, Teo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115497/
---
(Updated Feb. 10, 2014, 5:43 p.m.)
Review request for KDE Runtime, Teo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115497/#review49485
---
- Valentin Rusu
On Feb. 10, 2014, 5:43 p.m., Àlex Fiestas
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115497/#review49487
---
kwalletd/backend/kwalletbackend.cc
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115497/#review49490
---
Ship it!
One the issue around minor version check is done,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115497/#review49315
---
I've had a chance to download the patch and restart the
On Feb. 7, 2014, 5:14 a.m., Michael Pyne wrote:
kwalletd/backend/kwalletbackend.cc, line 387
https://git.reviewboard.kde.org/r/115497/diff/1-2/?file=242022#file242022line387
Again, might want to add error-checking here. If the salt can't be
saved for whatever reason then we don't
On Feb. 7, 2014, 5:14 a.m., Michael Pyne wrote:
kwalletd/backend/kwalletbackend.cc, line 387
https://git.reviewboard.kde.org/r/115497/diff/1-2/?file=242022#file242022line387
Again, might want to add error-checking here. If the salt can't be
saved for whatever reason then we don't
On Feb. 5, 2014, 7:18 p.m., Michael Pyne wrote:
kwalletd/backend/kwalletbackend.cc, line 635
https://git.reviewboard.kde.org/r/115497/diff/1/?file=242022#file242022line635
Seems to be no error checking here, if this fails and we overwrite the
hashed passwords on disk, couldn't
On Feb. 5, 2014, 7:18 p.m., Michael Pyne wrote:
kwalletd/backend/kwalletbackend.cc, line 130
https://git.reviewboard.kde.org/r/115497/diff/1/?file=242022#file242022line130
The salt here seems to be based off of the user's login-name, which can
change (for instance, someday my KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115497/
---
(Updated Feb. 6, 2014, 3:28 p.m.)
Review request for KDE Runtime, Teo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115497/
---
Review request for KDE Runtime, Teo Mrnjavac and Valentin Rusu.
14 matches
Mail list logo
