Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2015-01-17 Thread Joschi Brauchle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116481/ --- (Updated Jan. 17, 2015, 9:24 p.m.) Status -- This change has been

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2015-01-14 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116481/#review74005 --- You can discard this I think, I've already implemented it

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2015-01-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116481/#review73975 --- Ping? - Kai Uwe Broulik On Feb. 28, 2014, 1:53 nachm.,

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2014-08-31 Thread Christoph Feck
On March 2, 2014, 12:03 a.m., Kai Uwe Broulik wrote: Thanks for looking into this, I have a few code-styling related issues, see below. In the future I want to get rid of all of this, especially the magic ints instead of enums, and move that stuff to Solid - where it's already

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2014-08-31 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116481/#review65591 ---

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2014-08-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116481/#review65604 --- Ship it! Please fix the style related issues Mark pointed

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2014-05-04 Thread Christoph Feck
On March 2, 2014, 12:03 a.m., Kai Uwe Broulik wrote: Thanks for looking into this, I have a few code-styling related issues, see below. In the future I want to get rid of all of this, especially the magic ints instead of enums, and move that stuff to Solid - where it's already

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2014-03-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116481/#review51546 --- Thanks for looking into this, I have a few code-styling

Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2014-02-28 Thread Joschi Brauchle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116481/ --- Review request for kde-workspace and Kai Uwe Broulik. Bugs: