Re: Review Request 116555: Add support for pam-kwallet in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/ --- (Updated March 13, 2014, 12:33 a.m.) Status -- This change has been

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/#review52854 --- This review has been submitted with commit f2fe3e75b4ba12d0f9

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/#review52478 --- @Alex, please just make sure to release pam-wallet before next

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/#review52477 --- With my Release Team member hat i don't oppose to this change

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/#review52298 --- For the release time, since this is really like I would like t

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

> On March 6, 2014, 7:52 p.m., Albert Astals Cid wrote: > > I wonder if you're being too much verbose with the debugs. Since it is a beta I want to take the most of it in case any issue appears, I can remove verbosity before release if needed (think that this debug only happens once on session

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

> On March 6, 2014, 7:52 p.m., Albert Astals Cid wrote: > > kwalletd/main.cpp, line 100 > > > > > > Make this function static like the other ones? You are right, I will fix it tomorrow morning. - Àlex --

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/#review52293 --- I wonder if you're being too much verbose with the debugs. k

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

> On March 3, 2014, 11:57 p.m., Albert Astals Cid wrote: > > The Beta 1 of 4.13 is on Wednesday. Can the maintainer of the code affected > > by this give a evaluation of how "dangerous" this patch is and his > > recommendation for the Freeze exception? Oh, I only see this now. Is it too late?

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/#review52218 --- Ship it! Ship It! - Valentin Rusu On March 2, 2014, 11:33

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/#review51842 --- The Beta 1 of 4.13 is on Wednesday. Can the maintainer of the

Review Request 116555: Add support for pam-kwallet in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/ --- Review request for KDE Runtime, Release Team and Valentin Rusu. Repositor