---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/#review56568
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/
---
(Updated April 24, 2014, 10:52 a.m.)
Review request for kde-workspace,
On April 23, 2014, 5:43 p.m., Martin Gräßlin wrote:
ksmserver/screenlocker/greeter/main.cpp, line 34
https://git.reviewboard.kde.org/r/117091/diff/5/?file=267770#file267770line34
I'm wondering about the variable naming. It's m_ so one would assume
it's a member variable, but that
On April 24, 2014, 10:01 p.m., Thomas Lübking wrote:
ksmserver/screenlocker/greeter/main.cpp, line 94
https://git.reviewboard.kde.org/r/117091/diff/7/?file=268053#file268053line94
was there a problem with SA_RESTART?
---
KDE Workspaces 4.11.9 tagging:
On April 24, 2014, 8:01 p.m., Thomas Lübking wrote:
ksmserver/screenlocker/greeter/main.cpp, line 94
https://git.reviewboard.kde.org/r/117091/diff/7/?file=268053#file268053line94
was there a problem with SA_RESTART?
---
KDE Workspaces 4.11.9 tagging:
On April 24, 2014, 10:01 p.m., Thomas Lübking wrote:
ksmserver/screenlocker/greeter/main.cpp, line 94
https://git.reviewboard.kde.org/r/117091/diff/7/?file=268053#file268053line94
was there a problem with SA_RESTART?
---
KDE Workspaces 4.11.9 tagging:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/#review56431
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/
---
(Updated April 24, 2014, 10:20 p.m.)
Status
--
This change has been
On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote:
Is that only relevant for the legacy (XSS) locker or also for the new
locker? I'm just wondering whether it needs to be ported to master
Yes. I just tried, and the screen locker in master does have the same problem.
I wasn't able yet to
On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote:
Is that only relevant for the legacy (XSS) locker or also for the new
locker? I'm just wondering whether it needs to be ported to master
Wolfgang Bauer wrote:
Yes. I just tried, and the screen locker in master does have the same
On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote:
Is that only relevant for the legacy (XSS) locker or also for the new
locker? I'm just wondering whether it needs to be ported to master
Wolfgang Bauer wrote:
Yes. I just tried, and the screen locker in master does have the same
On April 23, 2014, 5:43 p.m., Martin Gräßlin wrote:
ksmserver/screenlocker/greeter/main.cpp, line 34
https://git.reviewboard.kde.org/r/117091/diff/5/?file=267770#file267770line34
I'm wondering about the variable naming. It's m_ so one would assume
it's a member variable, but that
On March 26, 2014, 11:07 p.m., Thomas Lübking wrote:
you could sighup or sigusr the greeter process and have it
setImmediateLock(true);
desktopResized();
in return
Wolfgang Bauer wrote:
I agree, this would be a bit nicer...
But I tried it and cannot get it to work.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/#review56190
---
see minor nitpicks, but in general the patch seems fine and
On April 22, 2014, 7:34 p.m., Thomas Lübking wrote:
ksmserver/screenlocker/greeter/main.cpp, line 89
https://git.reviewboard.kde.org/r/117091/diff/2/?file=262501#file262501line89
ooc.: what's wrong about just:
signal(SIGUSR1, signalHandler); ?
signal() is deprecated,
On April 22, 2014, 5:34 p.m., Thomas Lübking wrote:
ksmserver/screenlocker/greeter/main.cpp, line 89
https://git.reviewboard.kde.org/r/117091/diff/2/?file=262501#file262501line89
ooc.: what's wrong about just:
signal(SIGUSR1, signalHandler); ?
Wolfgang Bauer wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/#review56209
---
ksmserver/screenlocker/greeter/main.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/
---
(Updated April 22, 2014, 9:56 p.m.)
Review request for kde-workspace,
On April 22, 2014, 9:48 p.m., Thomas Lübking wrote:
ksmserver/screenlocker/greeter/main.cpp, line 38
https://git.reviewboard.kde.org/r/117091/diff/3/?file=267733#file267733line38
/me would not insist on newline, but there needs to be a blank after
the if
if (!m_instance)
On April 22, 2014, 7:34 p.m., Thomas Lübking wrote:
ksmserver/screenlocker/greeter/main.cpp, line 89
https://git.reviewboard.kde.org/r/117091/diff/2/?file=262501#file262501line89
ooc.: what's wrong about just:
signal(SIGUSR1, signalHandler); ?
Wolfgang Bauer wrote:
On April 22, 2014, 5:34 p.m., Thomas Lübking wrote:
ksmserver/screenlocker/greeter/main.cpp, line 89
https://git.reviewboard.kde.org/r/117091/diff/2/?file=262501#file262501line89
ooc.: what's wrong about just:
signal(SIGUSR1, signalHandler); ?
Wolfgang Bauer wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/
---
(Updated April 22, 2014, 10:34 p.m.)
Review request for kde-workspace,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/#review56241
---
Is that only relevant for the legacy (XSS) locker or also for
On March 26, 2014, 10:07 p.m., Thomas Lübking wrote:
you could sighup or sigusr the greeter process and have it
setImmediateLock(true);
desktopResized();
in return
Wolfgang Bauer wrote:
I agree, this would be a bit nicer...
But I tried it and cannot get it to work.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/
---
(Updated April 3, 2014, 5:15 p.m.)
Review request for kde-workspace and
On March 26, 2014, 11:07 p.m., Thomas Lübking wrote:
you could sighup or sigusr the greeter process and have it
setImmediateLock(true);
desktopResized();
in return
Wolfgang Bauer wrote:
I agree, this would be a bit nicer...
But I tried it and cannot get it to work.
On March 26, 2014, 11:07 p.m., Thomas Lübking wrote:
you could sighup or sigusr the greeter process and have it
setImmediateLock(true);
desktopResized();
in return
Wolfgang Bauer wrote:
I agree, this would be a bit nicer...
But I tried it and cannot get it to work.
On March 26, 2014, 10:07 p.m., Thomas Lübking wrote:
you could sighup or sigusr the greeter process and have it
setImmediateLock(true);
desktopResized();
in return
Wolfgang Bauer wrote:
I agree, this would be a bit nicer...
But I tried it and cannot get it to work.
On March 26, 2014, 11:07 p.m., Thomas Lübking wrote:
you could sighup or sigusr the greeter process and have it
setImmediateLock(true);
desktopResized();
in return
I agree, this would be a bit nicer...
But I tried it and cannot get it to work.
My signal handler is called, and
On March 26, 2014, 11:07 p.m., Thomas Lübking wrote:
you could sighup or sigusr the greeter process and have it
setImmediateLock(true);
desktopResized();
in return
Wolfgang Bauer wrote:
I agree, this would be a bit nicer...
But I tried it and cannot get it to work.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/
---
Review request for kde-workspace and Aaron J. Seigo.
Bugs: 327947 and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/#review54247
---
you could sighup or sigusr the greeter process and have it
32 matches
Mail list logo
