Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-15 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 15, 2014, 11:02 p.m.) Status -- This change has been m

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-14 Thread David Faure
> On July 12, 2014, 6:49 p.m., David Faure wrote: > > Seems clear enough. > > > > In KF5 the file is in frameworks/kwindowsystem/src/kwindowinfo_mac.cpp > > Marko Käning wrote: > Thanks for the info about KF5! > > Which branch should this be committed to on kdelibs4? Simply on mast

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-14 Thread Marko Käning
> On July 12, 2014, 8:49 p.m., David Faure wrote: > > Seems clear enough. > > > > In KF5 the file is in frameworks/kwindowsystem/src/kwindowinfo_mac.cpp > > Marko Käning wrote: > Thanks for the info about KF5! > > Which branch should this be committed to on kdelibs4? Simply on mast

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-14 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 14, 2014, 11:49 p.m.) Review request for KDE Software on Ma

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-14 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 14, 2014, 11:26 p.m.) Review request for kdelibs, David Fau

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-14 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 14, 2014, 7:59 p.m.) Review request for KDE Software on Mac

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-14 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 14, 2014, 7:10 p.m.) Review request for KDE Software on Mac

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread David Faure
> On July 12, 2014, 6:49 p.m., David Faure wrote: > > Seems clear enough. > > > > In KF5 the file is in frameworks/kwindowsystem/src/kwindowinfo_mac.cpp > > Marko Käning wrote: > Thanks for the info about KF5! > > Which branch should this be committed to on kdelibs4? Simply on mast

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Marko Käning
> On July 12, 2014, 8:49 p.m., David Faure wrote: > > Seems clear enough. > > > > In KF5 the file is in frameworks/kwindowsystem/src/kwindowinfo_mac.cpp Thanks for the info about KF5! Which branch should this be committed to on kdelibs4? Simply on master or also on (an)other branch(es)? - M

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/#review62201 --- Ship it! Seems clear enough. In KF5 the file is in framework

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 12, 2014, 8:17 p.m.) Review request for kdelibs, David Faur

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 12, 2014, 7:02 p.m.) Review request for kdelibs, Martin Grä

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Marko Käning
> On July 12, 2014, 6:01 p.m., Martin Gräßlin wrote: > > Which branch should that go in? I do not know what is currently a release > > branch. > > > > It should probably also be forward ported to frameworks even if the Mac > > part is currently not compiled (hint: if someone adjusts the code i

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/#review62192 --- Which branch should that go in? I do not know what is currentl

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 12, 2014, 4:22 p.m.) Review request for kdelibs, Martin Grä

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/#review62173 --- The patch is valid. My only question in this context would be

Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- Review request for kdelibs, Martin Gräßlin, Ian Wadham, and Thomas Lübking.