Re: Review Request 119868: KConfig add DirectoryType support

2014-08-20 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/ --- (Updated Aug. 20, 2014, 10:34 p.m.) Review request for KDE Frameworks, kd

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/#review64952 --- We have never needed this until now because we can recognize s

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/ --- (Updated Aug. 21, 2014, 1:15 p.m.) Status -- This change has been di

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread Maarten De Meyer
> On Aug. 21, 2014, 7:19 a.m., David Faure wrote: > > We have never needed this until now because we can recognize such files by > > their name... So while I'm not opposed to this, I wonder, why not use if > > (u.fileName() == ".directory") in KDesktopFileActions (RR 119869) -- which > > will