Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2014-08-21 Thread Arjun Ak
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119890/ --- Review request for KDE Base Apps and KDE Utils. Bugs: 338414 http://b

Re: Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2015-10-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119890/#review86319 --- (Seems we don't have an ark maintainer...) This looks good to

Re: Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2015-10-04 Thread Elvis Angelaccio
> On Oct. 4, 2015, 8:49 a.m., David Faure wrote: > > (Seems we don't have an ark maintainer...) > > > > This looks good to me. At this point it should be ported to KF5 though, I > > suppose. I confirm, it needs to be ported (shouldn't be too hard). - Elvis -

Re: Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2015-10-05 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119890/#review86362 --- Ship it! app/addToArchiveDndPlugin.cpp (line 38)

Re: Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2015-10-05 Thread Elvis Angelaccio
> On Oct. 5, 2015, 8:23 a.m., Vishesh Handa wrote: > > Is the 'Ship it' by accident, I guess? This patch does not currently compile. - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2016-03-19 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119890/#review93714 --- The author seems gone and the patch was lost (due to the Revi

Re: Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2017-01-23 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119890/ --- (Updated Jan. 23, 2017, 9:31 a.m.) Status -- This change has been di