Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 26, 2014, 12:13 p.m.) Status -- This change has been

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/#review67470 --- Ship it! Looks good to me, though I can of course not comment

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

> On Sept. 25, 2014, 5:58 p.m., Martin Gräßlin wrote: > > kglobalaccel/main.cpp, lines 48-55 > > > > > > now there are two deleted lines... My bad, I could so hardly believe that one might want 2 empty lines ther

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 25, 2014, 6:14 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/#review67431 --- kglobalaccel/main.cpp

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 25, 2014, 5:22 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/#review67428 --- kglobalaccel/main.cpp

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

> On Sept. 25, 2014, 4:10 p.m., Martin Gräßlin wrote: > > kglobalaccel/main.cpp, line 28 > > > > > > it's obvious that the include is needed, otherwise one wouldn't add it. > > I think that comment is not adding

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 25, 2014, 4:58 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/#review67423 --- kglobalaccel/main.cpp

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 25, 2014, 4:02 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

> On Sept. 24, 2014, 7:10 p.m., Martin Gräßlin wrote: > > Please watch coding style and please also have a look at the frameworks > > variant. It still needs porting to MacOS *hint,hint* and that would be > > very, very appreciated. I recently sent a mail to frameworks-devel > > concerning mov

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

> On Sept. 24, 2014, 5:10 p.m., Martin Gräßlin wrote: > > Please watch coding style and please also have a look at the frameworks > > variant. It still needs porting to MacOS *hint,hint* and that would be > > very, very appreciated. I recently sent a mail to frameworks-devel > > concerning mov

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

> On Sept. 24, 2014, 7:10 p.m., Martin Gräßlin wrote: > > Please watch coding style and please also have a look at the frameworks > > variant. It still needs porting to MacOS *hint,hint* and that would be > > very, very appreciated. I recently sent a mail to frameworks-devel > > concerning mov

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

> On Sept. 24, 2014, 7:10 p.m., Martin Gräßlin wrote: > > Please watch coding style and please also have a look at the frameworks > > variant. It still needs porting to MacOS *hint,hint* and that would be > > very, very appreciated. I recently sent a mail to frameworks-devel > > concerning mov

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 24, 2014, 7:23 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/#review67376 --- Please watch coding style and please also have a look at the f

Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- Review request for KDE Software on Mac OS X, KDE Runtime and kdelibs. Rep