Re: Review Request 122812: Fix BIC introduced in kdelibs 4

2015-03-05 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122812/ --- (Updated March 5, 2015, 2:07 p.m.) Status -- This change has been

Re: Review Request 122812: Fix BIC introduced in kdelibs 4

2015-03-05 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122812/#review77046 --- Ship it! Looks good. Also as for how to deal with kdelibs

Review Request 122812: Fix BIC introduced in kdelibs 4

2015-03-04 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122812/ --- Review request for kdelibs and Albert Astals Cid. Repository: kdelibs

Re: Review Request 122812: Fix BIC introduced in kdelibs 4

2015-03-04 Thread Luigi Toscano
On March 4, 2015, 10:19 p.m., Albert Astals Cid wrote: Given the BIC change is already part of 4.14.6 i'd say we just ignore it, it's not like anyone cares for that symbol, right? Is it already out? If not, no way to skip 4.14.6 or mark it as don't use it for distributions (or tell them

Re: Review Request 122812: Fix BIC introduced in kdelibs 4

2015-03-04 Thread Luigi Toscano
On March 4, 2015, 10:19 p.m., Albert Astals Cid wrote: Given the BIC change is already part of 4.14.6 i'd say we just ignore it, it's not like anyone cares for that symbol, right? Luigi Toscano wrote: Is it already out? If not, no way to skip 4.14.6 or mark it as don't use it for

Re: Review Request 122812: Fix BIC introduced in kdelibs 4

2015-03-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122812/#review77021 --- Given the BIC change is already part of 4.14.6 i'd say we

Re: Review Request 122812: Fix BIC introduced in kdelibs 4

2015-03-04 Thread Albert Astals Cid
On mar. 4, 2015, 9:19 p.m., Albert Astals Cid wrote: Given the BIC change is already part of 4.14.6 i'd say we just ignore it, it's not like anyone cares for that symbol, right? Luigi Toscano wrote: Is it already out? If not, no way to skip 4.14.6 or mark it as don't use it for

Re: Review Request 122812: Fix BIC introduced in kdelibs 4

2015-03-04 Thread Andrea Iacovitti
On Mar. 4, 2015, 9:19 p.m., Albert Astals Cid wrote: Given the BIC change is already part of 4.14.6 i'd say we just ignore it, it's not like anyone cares for that symbol, right? Luigi Toscano wrote: Is it already out? If not, no way to skip 4.14.6 or mark it as don't use it for