Re: Review Request 125081: Fix build on OS X

2015-09-06 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/ --- (Updated Sept. 6, 2015, 10:46 p.m.) Review request for KDE Base Apps. R

Re: Review Request 125081: Fix build on OS X

2015-09-06 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/#review84924 --- include config-kwindowsystem.h and use KWINDOWSYSTEM_HAVE_X11?

Re: Review Request 125081: Fix build on OS X

2015-09-06 Thread Samuel Gaist
> On Sept. 6, 2015, 10:52 p.m., Albert Astals Cid wrote: > > include config-kwindowsystem.h and use KWINDOWSYSTEM_HAVE_X11? And move all X11 related includes together ? - Samuel --- This is an automatically generated e-mail. To reply, v

Re: Review Request 125081: Fix build on OS X

2015-09-07 Thread Albert Astals Cid
> On set. 6, 2015, 10:52 p.m., Albert Astals Cid wrote: > > include config-kwindowsystem.h and use KWINDOWSYSTEM_HAVE_X11? > > Samuel Gaist wrote: > And move all X11 related includes together ? I'd only put netw.h there since it's the one that clearly comes from kwindowsystem having x11 su

Re: Review Request 125081: Fix build on OS X

2015-09-07 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/ --- (Updated Sept. 7, 2015, 10:08 p.m.) Review request for KDE Base Apps and

Re: Review Request 125081: Fix build on OS X

2015-09-07 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/#review84980 --- Ship it! give mgraesslin one day or so and if no answer commi

Re: Review Request 125081: Fix build on OS X

2015-09-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/#review84982 --- konqueror/src/konqmainwindow.cpp (line 150)

Re: Review Request 125081: Fix build on OS X

2015-09-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/#review84983 --- Ideally the usage of netwm should be removed. NETWM is very lo

Re: Review Request 125081: Fix build on OS X

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/#review102629 --- Since Samuel did not respond to the improvement requests by

Re: Review Request 125081: Fix build on OS X

2017-02-25 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/ --- (Updated Feb. 26, 2017, 12:26 a.m.) Status -- This change has been d