Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125297/ --- (Updated Sept. 17, 2015, 4:58 p.m.) Status -- This change has been d

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

> On set. 17, 2015, 10:17 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 99 > > > > > > I'd actually prefer if you fixed DnD as the fixme says instead of > > removing the feature. > > Jeremy Whiting wr

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

> On Sept. 17, 2015, 9:28 nachm., Thomas Lübking wrote: > > a) fix the test? > > b) the patch first limits to a Url subset and then guesses what it was ... > > if that is the "fix" it smell like okular or the test scenario cannot deal > > with remote files? > > Jeremy Whiting wrote: > As I

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

> On Sept. 17, 2015, 4:17 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 99 > > > > > > I'd actually prefer if you fixed DnD as the fixme says instead of > > removing the feature. Dragging and dropping

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125297/#review85593 --- shell/shell.cpp

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125297/ --- (Updated Sept. 17, 2015, 3:46 p.m.) Review request for kdelibs and Albert

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

> On Sept. 17, 2015, 3:28 p.m., Thomas Lübking wrote: > > a) fix the test? > > b) the patch first limits to a Url subset and then guesses what it was ... > > if that is the "fix" it smell like okular or the test scenario cannot deal > > with remote files? As I said in the description this isn'

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125297/#review85590 --- a) fix the test? b) the patch first limits to a Url subset and

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125297/ --- (Updated Sept. 17, 2015, 3:06 p.m.) Review request for kdelibs and Albert

Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125297/ --- Review request for kdelibs and Albert Astals Cid. Repository: okular De