Re: Review Request 125561: Align FindGettext with CMP002 policy

2015-10-10 Thread Alexander Semke
> On Oct. 10, 2015, 12:40 p.m., Alexander Semke wrote: > > Sholdn't the proposed patch in https://bugs.kde.org/show_bug.cgi?id=293030 > > already fix the problem? > > Hrvoje Senjan wrote: > Which patch? I only see the whole file there. Yes, I see the complete file only, too. The relevant f

Re: Review Request 125561: Align FindGettext with CMP002 policy

2015-10-10 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/ --- (Updated Oct. 10, 2015, 2:05 p.m.) Status -- This change has been ma

Re: Review Request 125561: Align FindGettext with CMP002 policy

2015-10-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/#review86629 --- Ship it! Ship It! - Albert Astals Cid On oct. 9, 2015, 11:

Re: Review Request 125561: Align FindGettext with CMP002 policy

2015-10-10 Thread Hrvoje Senjan
> On Oct. 10, 2015, 11:23 a.m., Albert Astals Cid wrote: > > This is so much cleaner and easier to understand, what would be a way to > > test this, i.e. which tarball do i use that has the problem this is fixing? > > Albert Astals Cid wrote: > i.e. you mention skanlite, but which tarball o

Re: Review Request 125561: Align FindGettext with CMP002 policy

2015-10-10 Thread Hrvoje Senjan
> On Oct. 10, 2015, 2:40 p.m., Alexander Semke wrote: > > Sholdn't the proposed patch in https://bugs.kde.org/show_bug.cgi?id=293030 > > already fix the problem? Which patch? I only see the whole file there. - Hrvoje --- This is an aut

Re: Review Request 125561: Align FindGettext with CMP002 policy

2015-10-10 Thread Alexander Semke
> On Oct. 10, 2015, 9:23 a.m., Albert Astals Cid wrote: > > This is so much cleaner and easier to understand, what would be a way to > > test this, i.e. which tarball do i use that has the problem this is fixing? > > Albert Astals Cid wrote: > i.e. you mention skanlite, but which tarball of

Re: Review Request 125561: Align FindGettext with CMP002 policy

2015-10-10 Thread Alexander Semke
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/#review86622 --- Sholdn't the proposed patch in https://bugs.kde.org/show_bug.c

Re: Review Request 125561: Align FindGettext with CMP002 policy

2015-10-10 Thread Yuri Chornoivan
> On Жов. 10, 2015, 9:23 до полудня, Albert Astals Cid wrote: > > This is so much cleaner and easier to understand, what would be a way to > > test this, i.e. which tarball do i use that has the problem this is fixing? > > Albert Astals Cid wrote: > i.e. you mention skanlite, but which tarb

Re: Review Request 125561: Align FindGettext with CMP002 policy

2015-10-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/#review86609 --- This is so much cleaner and easier to understand, what would b

Re: Review Request 125561: Align FindGettext with CMP002 policy

2015-10-10 Thread Albert Astals Cid
> On oct. 10, 2015, 9:23 a.m., Albert Astals Cid wrote: > > This is so much cleaner and easier to understand, what would be a way to > > test this, i.e. which tarball do i use that has the problem this is fixing? i.e. you mention skanlite, but which tarball of it exactly? - Albert -

Re: Review Request 125561: Align FindGettext with CMP002 policy

2015-10-09 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/ --- (Updated Oct. 10, 2015, 1:42 a.m.) Review request for Build System, kdeli