Re: Review request reminder: kded-appmenu

2012-10-02 Thread Cedric Bellegarde
Le samedi 29 septembre 2012 18:05:45 Alex Fiestas a écrit : > I was wondering, can't the kded be loaded on demand? what if somebody > doesn't care about appmenu? Hello, kded-appmenu was loaded on demand but with last version, i disable this because with Export/TopMenubar mode, nobody is using k

Re: Review request reminder: kded-appmenu

2012-09-29 Thread Alex Fiestas
On Wednesday 26 September 2012 14:58:55 Cedric Bellegarde wrote: > Hello, > > i'm waiting for some code review on kded-appmenu module: > https://projects.kde.org/projects/kdereview/kded-appmenu > > Martin Gräßlin tells me to send a reminder here before commiting. I need to > put this in kde-works

Re: Review request reminder: kded-appmenu

2012-09-27 Thread Cedric Bellegarde
Le mercredi 26 septembre 2012 16:30:11 Albert Astals Cid a écrit : > And where you read there that the code can be GPL3 only? Hello, that's fixed, all code is now GPLv2. registrar.* (plasma-widget-menubar code from Aurelien Gateau for Canonical) has been rewritten. About common code between re

Re: Review request reminder: kded-appmenu

2012-09-26 Thread Frank Reininghaus
Hi, 2012/9/26 Cedric Bellegarde: > Le mercredi 26 septembre 2012 16:04:30 vous avez écrit : >> Really, where does it say that? > > « > Any other source files must be licensed under one of the terms listed under 4) > or one of the following terms: > GPL version 2 as listed in kdelibs/COPYING or lat

Re: Review request reminder: kded-appmenu

2012-09-26 Thread Cedric Bellegarde
Le mercredi 26 septembre 2012 16:04:30 vous avez écrit : > Really, where does it say that? « Any other source files must be licensed under one of the terms listed under 4) or one of the following terms: GPL version 2 as listed in kdelibs/COPYING or later GPL version 2 or version 3 or later versio

Re: Review request reminder: kded-appmenu

2012-09-26 Thread Cedric Bellegarde
Le mercredi 26 septembre 2012 15:37:53 Albert Astals Cid a écrit : > You still have GPLv2 vs GPLv3 issues in the code. Hello, from your last mail, GPLv3 is disallowed by: http://techbase.kde.org/Policies/Licensing_Policy but i can read that for "Source files that aren't part of a library with a

Re: Review request reminder: kded-appmenu

2012-09-26 Thread Albert Astals Cid
El Dimecres, 26 de setembre de 2012, a les 16:07:19, Cedric Bellegarde va escriure: > Le mercredi 26 septembre 2012 16:04:30 vous avez écrit : > > Really, where does it say that? > > « > Any other source files must be licensed under one of the terms listed under > 4) or one of the following terms

Re: Review request reminder: kded-appmenu

2012-09-26 Thread Albert Astals Cid
El Dimecres, 26 de setembre de 2012, a les 15:53:47, Cedric Bellegarde va escriure: > Le mercredi 26 septembre 2012 15:37:53 Albert Astals Cid a écrit : > > You still have GPLv2 vs GPLv3 issues in the code. > > Hello, > > from your last mail, GPLv3 is disallowed by: > http://techbase.kde.org/Pol

Re: Review request reminder: kded-appmenu

2012-09-26 Thread Albert Astals Cid
El Dimecres, 26 de setembre de 2012, a les 14:58:55, Cedric Bellegarde va escriure: > Hello, > > i'm waiting for some code review on kded-appmenu module: > https://projects.kde.org/projects/kdereview/kded-appmenu You still have GPLv2 vs GPLv3 issues in the code. Oh wait the first guy that reque

Review request reminder: kded-appmenu

2012-09-26 Thread Cedric Bellegarde
Hello, i'm waiting for some code review on kded-appmenu module: https://projects.kde.org/projects/kdereview/kded-appmenu Martin Gräßlin tells me to send a reminder here before commiting. I need to put this in kde-workspace before patching with: https://git.reviewboard.kde.org/r/104344/ As i'm n