Re: KGlobalSettings move to kde4support

2013-06-19 Thread Kevin Ottens
Hello, On Tuesday 18 June 2013 20:00:40 Aleix Pol wrote: I added theme here [1]. Can you take a look and see if it's what you expected? :) Mostly good, I adjusted just a bit. I also removed the tasks which were deprecate only. The whole class will get deprecated when moving in kde4support,

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-19 Thread Kevin Ottens
On June 18, 2013, 2:06 p.m., Kevin Ottens wrote: kio/tests/jobtest.cpp, line 264 http://git.reviewboard.kde.org/r/111081/diff/1/?file=164106#file164106line264 Do we agree that the goal is that both uiDelegate() and interactionInterface() will return 0 if you link only kiocore?

Re: Review Request 111103: KPage* belongs to KWidgetsAddons

2013-06-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/#review34643 --- Ship it! Ship It! - Kevin Ottens On June 18, 2013, 5:32

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-19 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/ --- (Updated June 19, 2013, 9:49 a.m.) Review request for KDE Frameworks,

Re: Review Request 110988: Port kio-file to QFile

2013-06-19 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- (Updated June 19, 2013, 1:04 p.m.) Review request for KDE Frameworks.

Re: KF5 Update Meeting Minutes 2013-w25

2013-06-19 Thread Kevin Ottens
Hello, On Tuesday 18 June 2013 17:23:15 Kevin Ottens wrote: Announcements: * Tomorrow no new patch should be started, instead we get all the pending ones integrated so that dfaure can do a merge on thursday morning; Due to git.kde.org being unreachable most of today, we're extending the

Re: Review Request 111103: KPage* belongs to KWidgetsAddons

2013-06-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/ --- (Updated June 19, 2013, 2:47 p.m.) Status -- This change has been

Re: Review Request 111103: KPage* belongs to KWidgetsAddons

2013-06-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/#review34679 --- This review has been submitted with commit

Re: KGlobalSettings move to kde4support

2013-06-19 Thread Aleix Pol
On Tue, Jun 18, 2013 at 5:54 PM, Aleix Pol aleix...@kde.org wrote: On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke mwoehlke.fl...@gmail.com wrote: On 2013-06-18 03:10, Dominik Haumann wrote: On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: On Monday 17 June 2013 19:43:33 Aleix Pol

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-19 Thread Valentin Rusu
On June 19, 2013, 1:26 a.m., Wojciech Kapuscinski wrote: hmmm strange. kwallettest is unit test but was in manual tests (CMakeLists.txt in kdeui). Not sure what to do because kwallettest requires kwalletd Perhaps we could use this kdeui splitting opportunity to bring here kwalletd from

Re: KGlobalSettings move to kde4support

2013-06-19 Thread Matthew Woehlke
On 2013-06-18 11:54, Aleix Pol wrote: On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke wrote: On 2013-06-18 03:10, Dominik Haumann wrote: On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: On Monday 17 June 2013 19:43:33 Aleix Pol wrote: So I was looking at KGlobalSettings to see what we

Re: Re: KGlobalSettings move to kde4support

2013-06-19 Thread Martin Gräßlin
On Wednesday 19 June 2013 15:04:57 Matthew Woehlke wrote: On 2013-06-18 11:54, Aleix Pol wrote: On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke wrote: On 2013-06-18 03:10, Dominik Haumann wrote: On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: On Monday 17 June 2013 19:43:33 Aleix

Re: startkde modifies PATH to add qt4 bin dir to the front

2013-06-19 Thread Andrea Scarpino
On Tuesday 18 June 2013 19:19:24 Albert Astals Cid wrote: Sure we could do all that, but given the black magic that is involved in startkde (or so I've been told), i'd prefer to go for a simpler solution like the attached patch. If anyone is running without qdbus on the path can you give

Re: startkde modifies PATH to add qt4 bin dir to the front

2013-06-19 Thread Lisandro Damián Nicanor Pérez Meyer
On Tuesday 18 June 2013 19:19:24 Albert Astals Cid wrote: [snip] There's also a check that the dbus session is available, but surely we'll error out soon enough if this isn't the case? Sure we could do all that, but given the black magic that is involved in startkde (or so I've been told),

Event affecting KDE Git and Subversion

2013-06-19 Thread Ben Cooksley
Hi all, As some of you are aware, the physical host of git.kde.org and svn.kde.org encountered some problems early in the morning (UTC time). This has required that both are fully rebuilt. At the moment, only git.kde.org has been restored to functionality - however svn.kde.org will follow

Qt DevDays call for papers

2013-06-19 Thread Sebastian Kügler
Hi, One of those not-strictly-technical things you might now want to miss is the call for papers for the Qt DevDays to be held in Berlin (7-9 Oct) and San Francisco (6-8 Nov). As KDE ist contributing more directly to Qt, and in fact offering a lot of functionality on top of Qt (especially, but

Review Request 111115: Handle ramfs mounts correctly so copying files to them works

2013-06-19 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/15/ --- Review request for kdelibs and David Faure. Description --- The

Re: KF5 Update Meeting Minutes 2013-w25

2013-06-19 Thread Kevin Ottens
Hello, On Tuesday 18 June 2013 17:23:15 Kevin Ottens wrote: Announcements: * Tomorrow no new patch should be started, instead we get all the pending ones integrated so that dfaure can do a merge on thursday morning; Due to git.kde.org being unreachable most of today, we're extending the

Re: K(Abstract)FileItemActionPlugin

2013-06-19 Thread Sune Vuorela
On 2013-06-17, Frank Reininghaus frank7...@googlemail.com wrote: Yes, it can block for random reasons, and this is why making D-Bus calls in the code that is executed before the context menu is shown is unacceptable IMHO. I agree with the problem. But the issue is to *fix* kactivities to not

Re: K(Abstract)FileItemActionPlugin

2013-06-19 Thread Thomas Lübking
On Mittwoch, 19. Juni 2013 20:21:41 CEST, Sune Vuorela wrote: On 2013-06-17, Frank Reininghaus frank7...@googlemail.com wrote: Yes, it can block for random reasons, and this is why making D-Bus calls in the code that is executed before the context menu is shown is unacceptable IMHO. I agree

Re: Review Request 110649: add kimgio WebP image format plugin

2013-06-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/#review34706 --- This review has been submitted with commit

Re: Review Request 110649: add kimgio WebP image format plugin

2013-06-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated June 19, 2013, 7:35 p.m.) Status -- This change has been

Re: K(Abstract)FileItemActionPlugin

2013-06-19 Thread Sune Vuorela
On 2013-06-19, Thomas Lübking thomas.luebk...@gmail.com wrote: If I was a plugin developer here, I would of course think my plugin should be enabled by default and thus in my ctor call setEnabledByDefault(true) I would suggest to leave the path of plugin enabling as solution asap - it's not

Review Request 111145: Execute initModules on recreateDone

2013-06-19 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/45/ --- Review request for kdelibs and David Faure. Description --- When

Re: Review Request 110285: Fixed warning message when user trying to set more than 8 keyboard layouts

2013-06-19 Thread Andriy Rysin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110285/#review34718 --- Ship it! Ship It! - Andriy Rysin On May 3, 2013, 11 a.m.,

Event affecting KDE Git and Subversion

2013-06-19 Thread Ben Cooksley
Hi all, As some of you are aware, the physical host of git.kde.org and svn.kde.org encountered some problems early in the morning (UTC time). This has required that both are fully rebuilt. At the moment, only git.kde.org has been restored to functionality - however svn.kde.org will follow

Re: Event affecting KDE Git and Subversion

2013-06-19 Thread Heena Mahour
Hey Ben, So,it is not possible to push to quickgit.kde for some time,is it? This is what I am getting on pushing : @@@ @ WARNING: POSSIBLE DNS SPOOFING DETECTED! @ @@@

Re: Event affecting KDE Git and Subversion

2013-06-19 Thread Thomas Baumgart
Heena, as keys have changed as Ben pointed out, you need to get rid of the old key and make sure you install the new one once you use the connection during a push. Do that by comparing the fingerprints that Ben has sent in his e-mail. As your error message indicates, use ssh-keygen -f