Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117832/ --- (Updated April 29, 2014, 12:03 a.m.) Status -- This change has been

Re: Review Request 117851: fix finding the dummy extractor

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117851/ --- (Updated April 29, 2014, 12:02 a.m.) Review request for Baloo and kdewin.

Re: Review Request 117845: rename test as another exists with the same name

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117845/ --- (Updated April 29, 2014, 12:01 a.m.) Review request for Baloo and kdewin.

Review Request 117851: fix finding the dummy extractor

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117851/ --- Review request for Baloo. Repository: baloo Description --- the du

Re: Review Request 117845: rename test as another exists with the same name

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117845/ --- (Updated April 28, 2014, 11:51 p.m.) Review request for Baloo. Changes

Re: Baloo - [Basic Settings]

2014-04-28 Thread mk-lists
On 28 Apr 2014, at 09:13 , Kevin Krammer wrote: > http://techbase.kde.org/KDE_System_Administration/Configuration_Files#Shell_Expansion Thanks, Kevin, that link was indeed just what I needed! :-) Greets, Marko >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117845: rename test as another exists with the same name

2014-04-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117845/#review56797 --- This review has been submitted with commit 497a344727824c80f1

Re: Review Request 117846: make filesearchstoretest a console application

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117846/ --- (Updated April 28, 2014, 8:28 p.m.) Status -- This change has been m

Re: Review Request 117845: rename test as another exists with the same name

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117845/ --- (Updated April 28, 2014, 8:27 p.m.) Status -- This change has been m

Re: Baloo : Milou Search Application

2014-04-28 Thread Vishesh Handa
On Tuesday, April 29, 2014 12:03:42 AM Manu Gupta wrote: > Hello All, Hey Manu > > I came across the task on Baloo at http://community.kde.org/Baloo/Tasks > It will be great if someone can help me with building it, as I am > quite new to Qt and KDE libs also. > > Any pointers to start will also

Baloo : Milou Search Application

2014-04-28 Thread Manu Gupta
Hello All, I came across the task on Baloo at http://community.kde.org/Baloo/Tasks It will be great if someone can help me with building it, as I am quite new to Qt and KDE libs also. Any pointers to start will also be great. Thanks a lot -- Regards Manu Gupta >> Visit http://mail.kde.org/mai

Re: Review Request 117800: Move tests inside libs/mediacenter and make them compile with the library sources instead of linking to libplasmamediacenter

2014-04-28 Thread Shantanu Tushar Jha
Hi folks, This patch makes our tests compile with the actual sources files they are testing, instead of linking to the object created from the sources. This is done for these reasons- * (this is the main reason) We no longer have to export classes just to test them * We can use ORM mapped classes

Re: Review Request 117845: rename test as another exists with the same name

2014-04-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117845/#review56771 --- Ship it! Feel free to commit it after that. src/file/tests/

Re: Review Request 117845: rename test as another exists with the same name

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117845/ --- (Updated April 28, 2014, 3:33 p.m.) Review request for Baloo and kdewin.

Re: Review Request 117846: make filesearchstoretest a console application

2014-04-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117846/#review56767 --- Ship it! Ship It! - Vishesh Handa On April 28, 2014, 3:21

Review Request 117845: make filesearchstoretest a console application

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117845/ --- Review request for Baloo and kdewin. Repository: baloo Description

Review Request 117846: make filesearchstoretest a console application

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117846/ --- Review request for Baloo and kdewin. Repository: baloo Description

Re: Review Request 117826: check that the directories are actually really removed

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117826/ --- (Updated April 28, 2014, 2:43 p.m.) Status -- This change has been m

Re: Review Request 117825: exclude check for extended attributes for Windows

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117825/ --- (Updated April 28, 2014, 2:43 p.m.) Status -- This change has been m

Re: Review Request 117827: malloc_trim is a gnu extension

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117827/ --- (Updated April 28, 2014, 2:43 p.m.) Status -- This change has been m

Re: Review Request 117828: prevent ex/import in exported classes used in tests

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117828/ --- (Updated April 28, 2014, 2:43 p.m.) Status -- This change has been m

Re: Review Request 117830: disable extended attributes support on windows

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117830/ --- (Updated April 28, 2014, 2:42 p.m.) Status -- This change has been m

Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

2014-04-28 Thread Patrick Spendrin
> On April 28, 2014, 1:24 p.m., Reece Dunn wrote: > > The *A Windows API variants use the ASCII (referred to as ANSI in the > > Windows docs), not UTF-8, encoding. Therefore, this will not work as > > expected for non-ASCII characters. This should use SetFileAttributeW with > > toUtf16. The f

Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

2014-04-28 Thread Reece Dunn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117832/#review56750 --- The *A Windows API variants use the ASCII (referred to as ANSI

Re: Review Request 117830: disable extended attributes support on windows

2014-04-28 Thread Patrick Spendrin
> On April 28, 2014, 12:41 p.m., Vishesh Handa wrote: > > I'm a little surprised that NTFS doesn't support xattr, but sure! > > Thomas Lübking wrote: > NTFS /does/ support xattr (on ntfs-3g), but WinNT does support infinite > length xattr via ADS only, so basically xattr invocation would ha

Re: Review Request 117830: disable extended attributes support on windows

2014-04-28 Thread Thomas Lübking
> On April 28, 2014, 12:41 p.m., Vishesh Handa wrote: > > I'm a little surprised that NTFS doesn't support xattr, but sure! NTFS /does/ support xattr (on ntfs-3g), but WinNT does support infinite length xattr via ADS only, so basically xattr invocation would have to be ported for Windows. -

Re: Review Request 117825: exclude check for extended attributes for Windows

2014-04-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117825/#review56742 --- Ship it! Ship It! - Vishesh Handa On April 28, 2014, 9:41

Re: Review Request 117827: malloc_trim is a gnu extension

2014-04-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117827/#review56740 --- Ship it! I was trying to keep the memory used by the process

Re: Review Request 117826: check that the directories are actually really removed

2014-04-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117826/#review56741 --- Ship it! Ship It! - Vishesh Handa On April 28, 2014, 9:44

Re: Review Request 117828: prevent ex/import in exported classes used in tests

2014-04-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117828/#review56739 --- Ship it! I don't get why MSVC doesn't just ignore it, but sur

Re: Review Request 117829: do not raise unknown signal on windows

2014-04-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117829/#review56738 --- src/file/autotest/fileindexingjob/extractor.cpp

Re: Review Request 117830: disable extended attributes support on windows

2014-04-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117830/#review56737 --- Ship it! I'm a little surprised that NTFS doesn't support xat

Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

2014-04-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117832/#review56736 --- Ship it! Ship It! - Vishesh Handa On April 28, 2014, 10:05

Review Request 117832: use QFileInfo to also find hidden paths on windows

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117832/ --- Review request for Baloo and kdewin. Repository: baloo Description

Review Request 117830: disable extended attributes support on windows

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117830/ --- Review request for Baloo and kdewin. Repository: baloo Description

Review Request 117829: do not raise unknown signal on windows

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117829/ --- Review request for Baloo and kdewin. Repository: baloo Description

Review Request 117828: prevent ex/import in exported classes used in tests

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117828/ --- Review request for Baloo and kdewin. Repository: baloo Description

Review Request 117827: malloc_trim is a gnu extension

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117827/ --- Review request for Baloo and kdewin. Repository: baloo Description

Review Request 117826: check that the directories are actually really removed

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117826/ --- Review request for Baloo and kdewin. Repository: baloo Description

Review Request 117825: exclude check for extended attributes for Windows

2014-04-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117825/ --- Review request for Baloo and kdewin. Repository: baloo Description

Re: Baloo - [Basic Settings]

2014-04-28 Thread Kevin Krammer
On Sunday, 2014-04-27, 22:53:02, mk-li...@email.de wrote: > Hi Vishesh, > > On 23 Apr 2014, at 23:54 , Michael Pyne wrote: > > I'm not sure about [$]. There are other possibilities for a KConfig file > > besides [$e] but I don't think [$] is one of them. > > could you please clarify what the [$]