Re: Review Request 118844: Introduce convenient methods to set active and default shortcut

2014-06-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118844/ --- (Updated June 23, 2014, 6:28 a.m.) Status -- This change has been

Re: Review Request 118844: Introduce convenient methods to set active and default shortcut

2014-06-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118844/#review60748 --- This review has been submitted with commit

Re: Review Request 118846: Turn KLauncher into a QGuiApplication

2014-06-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60749 --- This review has been submitted with commit

Re: Review Request 118846: Turn KLauncher into a QGuiApplication

2014-06-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/ --- (Updated June 23, 2014, 6:30 a.m.) Status -- This change has been

Re: (UNINTENDED?) installation outside the configured DATA_INSTALL_DIR (was Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts)

2014-06-23 Thread David Faure
On Wednesday 04 June 2014 10:31:28 Marko Käning wrote: Turns out thought that these aren’t all yet, since two frameworks (khtml ktexteditor) actually place their stuff outside of the actually configured kf5 subdirectory: --- which is probably unintended! Can this be considered a glitch of

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60771 --- Ship it! Ship It! - David Edmundson On June 22, 2014,

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60772 --- What about bringing this to VdG? They can come up with a more

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Marco Martin
On June 23, 2014, 10:34 a.m., Aleix Pol Gonzalez wrote: What about bringing this to VdG? They can come up with a more integrated new design for the about dialog. For the moment, I'm good with just changing the picture, but I wouldn't like to leave it there. Marco Martin wrote:

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118852/#review60776 --- Isn't that same uses breaking when using kconfig then? -

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60783 --- Sorry for hijacking this review, but I think we need the

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60784 --- Ship it! Ship It! - Sebastian Kügler On June 22, 2014,

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60786 --- This review has been submitted with commit

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/ --- (Updated June 23, 2014, 11:33 a.m.) Status -- This change has been

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review60787 --- Can you please try to generate a proper diff? The one you

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-23 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 23, 2014, 1:46 p.m.) Review request for kde-workspace, KDE

Solid situation for 5.0

2014-06-23 Thread Àlex Fiestas
As many of you know late in the game I started writing some new code to add much needed asynchronous api to Solid/Power which meant moving the old deprecate code to kdelibs4Support. The new API is done (you can review it on master, there are 2 CMake options to enable them) and all is left to

Review Request 118906: Fix dialog's check for isTooltip

2014-06-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118906/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Solid situation for 5.0

2014-06-23 Thread Kevin Ottens
Hello, On Monday 23 June 2014 17:56:20 Àlex Fiestas wrote: As many of you know late in the game I started writing some new code to add much needed asynchronous api to Solid/Power which meant moving the old deprecate code to kdelibs4Support. The new API is done (you can review it on master,

Review Request 118909: Imply SkipTaskbar and SkipPager depending on Window Type

2014-06-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118909/ --- Review request for KDE Frameworks, kwin and Eike Hein. Repository:

Re: Review Request 118909: Imply SkipTaskbar and SkipPager depending on Window Type

2014-06-23 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118909/#review60843 --- What about (non override) utility windows (eg. assume Qt

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-23 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118852/#review60850 --- autotests/kconfigtest.cpp

Re: Review Request 118909: Imply SkipTaskbar and SkipPager depending on Window Type

2014-06-23 Thread Martin Gräßlin
On June 23, 2014, 10:08 p.m., Thomas Lübking wrote: What about (non override) utility windows (eg. assume Qt would not set floating dock override to bring its own titlebar)? While kwin (iirc by default) hides them for inactive windows, that's rather a feature. - By their nature,

Re: Review Request 118853: Log name + size of not found icons in debug output

2014-06-23 Thread Elias Probst
On June 21, 2014, 9:36 a.m., Christoph Feck wrote: What is the status of categorized debugging/logging support in Qt, and how do we utilize that in our frameworks? If we are still simply using uncategorized qDebug(), please commit it. Luigi Toscano wrote: We can use qCDebug;

Re: Review Request 118853: Log name + size of not found icons in debug output

2014-06-23 Thread Luigi Toscano
On June 21, 2014, 11:36 a.m., Christoph Feck wrote: What is the status of categorized debugging/logging support in Qt, and how do we utilize that in our frameworks? If we are still simply using uncategorized qDebug(), please commit it. Luigi Toscano wrote: We can use qCDebug;

Re: Review Request 118879: Revert to old shell script code for parsing rgb.txt

2014-06-23 Thread Alexander Potashev
On June 23, 2014, 8:28 a.m., Aurélien Gâteau wrote: Out of curiosity: why is it necessary to skip colors with spaces? I guess it's a heuristic to remove duplicate entries for same {R,G,B}. However, it doesn't work perfectly, e.g. we have two entries navy and NavyBlue for the same RGB={0,

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60757 --- Hmm, now we seem to have a strange situation between KDE4 and

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Christoph Feck
On June 23, 2014, 9:16 a.m., Raymond Wooninck wrote: Hmm, now we seem to have a strange situation between KDE4 and KF5/PN. The latest version of libkonq with KDE4 is 5.14.0 (libkonq.so.5.14.0) with libkonq.so.5 pointing to it. With this change libkonq has a lower version

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Jonathan Riddell
On June 23, 2014, 9:16 a.m., Raymond Wooninck wrote: Hmm, now we seem to have a strange situation between KDE4 and KF5/PN. The latest version of libkonq with KDE4 is 5.14.0 (libkonq.so.5.14.0) with libkonq.so.5 pointing to it. With this change libkonq has a lower version

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review60787 --- Can you please try to generate a proper diff? The one you

Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/ --- Review request for kde-workspace, Plasma and Marcel Wiesweg. Bugs:

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60795 --- I think there's a couple of problems with this approach: -

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-23 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 23, 2014, 1:46 p.m.) Review request for kde-workspace, KDE

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
On June 23, 2014, 3:21 p.m., Sebastian Kügler wrote: I think there's a couple of problems with this approach: - This slows down startup for everybody, not just those who changed the setting. I'm not super-familiar with this, but isn't kcminit for this use-case? - Changing startup

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
On June 23, 2014, 3:21 p.m., Sebastian Kügler wrote: I think there's a couple of problems with this approach: - This slows down startup for everybody, not just those who changed the setting. I'm not super-familiar with this, but isn't kcminit for this use-case? - Changing startup

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60809 --- kcmkgamma/init_kgamma.cpp

Move of KXStitch to Extragear/Graphics

2014-06-23 Thread Steve Allewell
Hi all The KXStitch application has been in review for a few weeks now. Albert identified a few minor issues that have now been fixed. If there is no more feedback, I would like to request KXStitch is moved to Extragear/Graphics. I'll submit a ticket in a couple of days but if anyone

Move of SymbolEditor to Extragear/Graphics

2014-06-23 Thread Steve Allewell
Hi all The SymbolEditor application has been in review for a few weeks now. Albert identified a few minor issues that have now been fixed. If there is no more feedback, I would like to request SymbolEditor is moved to Extragear/Graphics. I'll submit a ticket in a couple of days but if

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/ --- (Updated June 23, 2014, 7:01 p.m.) Review request for kde-workspace,

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
On June 23, 2014, 3:21 p.m., Sebastian Kügler wrote: I think there's a couple of problems with this approach: - This slows down startup for everybody, not just those who changed the setting. I'm not super-familiar with this, but isn't kcminit for this use-case? - Changing startup

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote: kcmkgamma/init_kgamma.cpp, lines 1-8 https://git.reviewboard.kde.org/r/118898/diff/1/?file=283881#file283881line1 please use a copyright header as in http://techbase.kde.org/Policies/Licensing_Policy#GPL_Header I just copied the

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Martin Gräßlin
On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote: kcmkgamma/init_kgamma.cpp, line 39 https://git.reviewboard.kde.org/r/118898/diff/1/?file=283881#file283881line39 why delete config? I would just use a KSharedConfig::openConfig Wolfgang Bauer wrote: I just copy/pasted the

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote: kcmkgamma/init_kgamma.cpp, line 39 https://git.reviewboard.kde.org/r/118898/diff/1/?file=283881#file283881line39 why delete config? I would just use a KSharedConfig::openConfig Wolfgang Bauer wrote: I just copy/pasted the

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60866 --- Not sure why you added Marcel to the list of reviewers...

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Christoph Feck
On June 23, 2014, 10:41 p.m., Christoph Feck wrote: Not sure why you added Marcel to the list of reviewers... Anyway, if the current patch is all that is needed to restore sanity as in KDE 3, the I am all for getting it fixed. (And if the same issue was the cause for the KRandR

Re: Date/Time related widgets crashing plasma-desktop

2014-06-23 Thread Lindsay Mathieson
On Mon, 23 Jun 2014 01:08:46 PM Sebastian Kügler wrote: did you try running plasma-desktop or plasmoidviewer through gdb to get a backtrace? Crashes in plasmoidviewer, but no debug symbols or stack trace. Would kde-runtime-dbg be the one to install? -- Lindsay signature.asc Description:

Re: Date/Time related widgets crashing plasma-desktop

2014-06-23 Thread Sebastian Kügler
On Monday, June 23, 2014 21:28:26 Lindsay Mathieson wrote: On Mon, 23 Jun 2014 01:08:46 PM Sebastian Kügler wrote: did you try running plasma-desktop or plasmoidviewer through gdb to get a backtrace? Crashes in plasmoidviewer, but no debug symbols or stack trace. Would kde-runtime-dbg

Re: Date/Time related widgets crashing plasma-desktop

2014-06-23 Thread Lindsay Mathieson
On Mon, 23 Jun 2014 01:54:02 PM Sebastian Kügler wrote: Crashes in plasmoidviewer, but no debug symbols or stack trace. Would kde-runtime-dbg be the one to install? Yes, possibly kdelibs*dbg and kde-workspace*dbg as well, and perhaps Qt*dbg. installed, kde-runtime-dbg

Re: Date/Time related widgets crashing plasma-desktop

2014-06-23 Thread Thomas Lübking
On Montag, 23. Juni 2014 14:22:46 CEST, Lindsay Mathieson wrote: installed, kde-runtime-dbg kde-workspace-dbg kdelibs5-dbg Unfortunately, still no debug info You mean no Dr. Konqui? - run plasma-* in gdb gdb --args plasma-desktop 21 | tee plasma-desktop.dbg (gdb) run Program

Re: Date/Time related widgets crashing plasma-desktop

2014-06-23 Thread Lindsay Mathieson
On Mon, 23 Jun 2014 02:35:31 PM Thomas Lübking wrote: Unfortunately, still no debug info You mean no Dr. Konqui? Nope, I mean gdb reports not debug info. gdb plasmoidviewer ... Reading symbols from plasmoidviewer...(no debugging symbols found)...done. (gdb) run digital-clock Starting

Re: Date/Time related widgets crashing plasma-desktop

2014-06-23 Thread Thomas Lübking
On Montag, 23. Juni 2014 14:46:45 CEST, Lindsay Mathieson wrote: On Mon, 23 Jun 2014 02:35:31 PM Thomas Lübking wrote: Unfortunately, still no debug info You mean no Dr. Konqui? Nope, I mean gdb reports not debug info. gdb plasmoidviewer --nofork (not sure whether plasmoidviewer does and

Re: Date/Time related widgets crashing plasma-desktop

2014-06-23 Thread Thomas Lübking
On Montag, 23. Juni 2014 22:55:47 CEST, Lindsay Mathieson wrote: On Mon, 23 Jun 2014 03:00:26 PM Thomas Lübking wrote: On Montag, 23. Juni 2014 14:46:45 CEST, Lindsay Mathieson wrote: ... I tried plasmoidviewer and plasma-desktop with --nofork, but no debug info for either. You get the No

Re: Date/Time related widgets crashing plasma-desktop

2014-06-23 Thread Lindsay Mathieson
On Mon, 23 Jun 2014 11:04:00 PM Thomas Lübking wrote: I tried plasmoidviewer and plasma-desktop with --nofork, but no debug info for either. You get the No stack output from gdb --args plasma-desktop --nofork ??? No idea what could cause that (except nofork being broken - there'd

Re: Date/Time related widgets crashing plasma-desktop

2014-06-23 Thread Ian Wadham
On 24/06/2014, at 7:18 AM, Lindsay Mathieson wrote: On Mon, 23 Jun 2014 11:04:00 PM Thomas Lübking wrote: I tried plasmoidviewer and plasma-desktop with --nofork, but no debug info for either. You get the No stack output from gdb --args plasma-desktop --nofork ??? No idea what

Re: [Kde-hardware-devel] Review Request 118801: Consider additional batteries for power management (when the critical battery timer is running)

2014-06-23 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118801/ --- (Updated June 23, 2014, 6:14 p.m.) Review request for Solid. Changes

Re: [Kde-hardware-devel] Review Request 118801: Consider additional batteries for power management (when the critical battery timer is running)

2014-06-23 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118801/ --- (Updated June 23, 2014, 4:47 p.m.) Status -- This change has been

Re: [Kde-hardware-devel] Review Request 118801: Consider additional batteries for power management (when the critical battery timer is running)

2014-06-23 Thread Emmanuel Pescosta
On June 23, 2014, 6:47 p.m., Commit Hook wrote: This review has been submitted with commit 775a99e8bc1e9c5e277ff17a84a406227a5a32fb by Emmanuel Pescosta to branch KDE/4.11. I'll create a patch for kde:powerdevil when I have some time again, maybe this weekend or in the end of next