Re: Review Request 120361: Force kpagewidget layout's margin to zero when embedded in kpagedialog, to enforce alignment with buttonbox

2014-09-29 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120361/ --- (Updated Sept. 29, 2014, 6:27 a.m.) Review request for KDE Frameworks

Re: Review Request 120361: Force kpagewidget layout's margin to zero when embedded in kpagedialog, to enforce alignment with buttonbox

2014-09-29 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120361/ --- (Updated Sept. 29, 2014, 6:28 a.m.) Status -- This change has been

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-29 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120360/ --- (Updated Sept. 29, 2014, 6:30 a.m.) Review request for KDE Frameworks

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #793

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #793

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #794

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #794

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #795

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #795

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-29 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120360/#review67609 --- Ship it! Ship It! - Christoph Feck On Sept. 29, 2014,

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-29 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120360/ --- (Updated Sept. 29, 2014, 10:34 a.m.) Status -- This change has been

Build error with frameworkintegration

2014-09-29 Thread nerdopolis
Hi. It seems that a recent build error when trying to build Frameworks master against QT 5.4. (well a warning being treated as an error) I build all the Frameworks with my own scripts, because I need checkinstall. However, other then changing the prefix to /opt, I am using default

Re: Review Request 119607: Support for .hidden files

2014-09-29 Thread Bruno Nova
On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: src/core/kcoredirlister.cpp, line 2799 https://git.reviewboard.kde.org/r/119607/diff/2/?file=301215#file301215line2799 This will only work for local files. I'm not sure if we would want to support the .hidden mechanism also

Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

2014-09-29 Thread Helio Castro
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120421/ --- Review request for KDE Frameworks. Repository: kauth Description

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #796

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #796

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120422: Fix build with Qt 5.4 - Implement SystemTrayMenuItem::setIconSize

2014-09-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120422/ --- Review request for KDE Frameworks. Repository: frameworkintegration

Re: Build error with frameworkintegration

2014-09-29 Thread Aleix Pol
On Mon, Sep 29, 2014 at 1:25 PM, nerdopolis bluescreen_aven...@verizon.net wrote: Hi. It seems that a recent build error when trying to build Frameworks master against QT 5.4. (well a warning being treated as an error) I build all the Frameworks with my own scripts, because I need

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

2014-09-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120421/#review67622 --- Shouldn't include directories be dragged by polkit-qt? Maybe

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

2014-09-29 Thread Helio Castro
On Sept. 29, 2014, 1:36 p.m., Aleix Pol Gonzalez wrote: Shouldn't include directories be dragged by polkit-qt? Maybe we should fix polkit-qt cmake files to do so? Nope, this is not automatic and we're talking about polkit-qt5-1. If you look on the cmake file, there's include directories

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

2014-09-29 Thread Hrvoje Senjan
On Sept. 29, 2014, 3:36 p.m., Aleix Pol Gonzalez wrote: Shouldn't include directories be dragged by polkit-qt? Maybe we should fix polkit-qt cmake files to do so? Helio Castro wrote: Nope, this is not automatic and we're talking about polkit-qt5-1. If you look on the cmake file,

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

2014-09-29 Thread Helio Castro
On Sept. 29, 2014, 1:36 p.m., Aleix Pol Gonzalez wrote: Shouldn't include directories be dragged by polkit-qt? Maybe we should fix polkit-qt cmake files to do so? Helio Castro wrote: Nope, this is not automatic and we're talking about polkit-qt5-1. If you look on the cmake file,

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #797

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/797/ -- Started by upstream project plasma-framework_master_qt5 build number 797 originally caused by: Started by remote host 2a01:4f8:160:9363::9 with note:

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #797

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Split kde-baseapps?

2014-09-29 Thread Emmanuel Pescosta
- dolphin: could be split out, I added emmanuel as a CC to know his opinion Thanks for adding me and sorry for the late response. +1 for splitting up kde-baseapps We can split off Dolphin as soon as Dolphin is konq-lib free (David has already done a huge amount of work in this field :) Cheers,

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

2014-09-29 Thread Helio Castro
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120421/ --- (Updated Sept. 29, 2014, 6:26 p.m.) Status -- This change has been

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

2014-09-29 Thread Hrvoje Senjan
On Sept. 29, 2014, 3:36 p.m., Aleix Pol Gonzalez wrote: Shouldn't include directories be dragged by polkit-qt? Maybe we should fix polkit-qt cmake files to do so? Helio Castro wrote: Nope, this is not automatic and we're talking about polkit-qt5-1. If you look on the cmake file,

Re: Review Request 120408: Port textcreator thumbnailer

2014-09-29 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/ --- (Updated Sept. 29, 2014, 7:42 p.m.) Status -- This change has been

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #798

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Build error with frameworkintegration

2014-09-29 Thread nerdopolis
On Monday, September 29, 2014 03:32:31 PM Aleix Pol wrote: On Mon, Sep 29, 2014 at 1:25 PM, nerdopolis bluescreen_aven...@verizon.net wrote: Hi. It seems that a recent build error when trying to build Frameworks master against QT 5.4. (well a warning being treated as an error) I

Jenkins build is unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #798

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/798/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120422: Fix build with Qt 5.4 - Implement SystemTrayMenuItem::setIconSize

2014-09-29 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120422/#review67653 --- I could accept the patch, problem is that later on we might

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #799

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/799/ -- Started by upstream project plasma-framework_master_qt5 build number 799 originally caused by: Started by remote host 2a01:4f8:160:9363::9 with note:

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #799

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #800

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/800/ -- Started by upstream project plasma-framework_master_qt5 build number 800 originally caused by: Started by remote host 2a01:4f8:160:9363::9 with note:

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #800

2014-09-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120406: ksysguardd: Avoid including IO-wait in CPU load.

2014-09-29 Thread Søren Holm
Giv en that my change will be accepted, but is it applied. I have not commit right. Søndag den 28. september 2014 15:07:51 skrev Søren Holm: --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

2014-09-29 Thread Frederic Sheedy
Hi Ian, Review is to reopened! I also use Buzilla_token as param for login request. But use of token as param for attachement works. Frédéric On Fri, Sep 26, 2014 at 7:11 PM, Ian Wadham iandw...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit:

Re: Review Request 120403: [OS X] adapting KMenu::addTitle to OS X menubar specifics

2014-09-29 Thread Thomas Lübking
On Sept. 28, 2014, 3:13 nachm., Thomas Lübking wrote: kdeui/widgets/kmenu.cpp, line 182 https://git.reviewboard.kde.org/r/120403/diff/1/?file=315609#file315609line182 try to avoid negated bools unless for performance or readability reasons (ie. you'd need !flag a lot otherwise)

Fwd: PVS-Studio KDE analysis

2014-09-29 Thread Christoph Feck
Hi, I got this question from Boris, but do not feel qualified to answer, so forwarding it here. Please CC Boris in reply. -- Forwarded Message -- Subject: PVS-Studio KDE analysis Date: Monday 29 September 2014, 18:04:24 From: Boris Egorov ego...@linux.com To:

Re: Fwd: PVS-Studio KDE analysis

2014-09-29 Thread Ivan Čukić
I got this question from Boris, but do not feel qualified to answer, so forwarding it here. Please CC Boris in reply. If the report is not separated into components, then I'd guess kde-devel is the right place for it. Lets see what the others will say. A question that I'd have for Boris is

Re: Fwd: PVS-Studio KDE analysis

2014-09-29 Thread Ingo Klöcker
On Monday 29 September 2014 18:55:18 Ivan Čukić wrote: I got this question from Boris, but do not feel qualified to answer, so forwarding it here. Please CC Boris in reply. If the report is not separated into components, then I'd guess kde-devel is the right place for it. I think it

Re: Fwd: PVS-Studio KDE analysis

2014-09-29 Thread Jan Kundrát
On Monday, 29 September 2014 18:39:08 CEST, Christoph Feck wrote: Russian folks behind PVS-Studio static analyzer (http://www.viva64.com/en/pvs-studio/) made analysis of KDE project. Hi, can we make them run it on extragear (and especially extragear/pim/trojita)? Cheers, Jan -- Trojitá,

Re: libkface

2014-09-29 Thread Vishesh Handa
Hey Tobias Some comments about the code - 1. The code seems to be licensed under GPL. In order to make it into a framework, it will need to be re-licensed. This library seems like an ideal candidate for becoming a framework. 2. The copyright header seems to say Part of the Digikam Project. You

Re: libkface

2014-09-29 Thread Gilles Caulier
2014-09-30 3:06 GMT+02:00 Vishesh Handa m...@vhanda.in: Hey Tobias Some comments about the code - 1. The code seems to be licensed under GPL. In order to make it into a framework, it will need to be re-licensed. This library seems like an ideal candidate for becoming a framework. libkface

Re: Help request with Cantor port to KF5

2014-09-29 Thread Albert Astals Cid
El Dilluns, 29 de setembre de 2014, a les 05:18:36, Aleix Pol va escriure: On Sun, Sep 28, 2014 at 11:59 PM, Filipe Saraiva fil...@kde.org wrote: Hello gearheads, I am working in Cantor port to KF5 in last month. My milestone is to compile and run Cantor without backends and panel