Re: Review Request 121153: Restore filedialog show() functionality for modal dialogs

2014-11-18 Thread Martin Klapetek
On Nov. 18, 2014, 12:33 a.m., Jeremy Whiting wrote: I tested this here and FileDialog qml still hangs the ui with this patch. (though at least the dialog appears) Yes, QML still hangs, not sure why though. Looking into it. - Martin

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-18 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/#review70575 --- Ship it! Ship It! - Christoph Feck On Nov. 17, 2014, 4:48

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-18 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated Nov. 18, 2014, 11:23 a.m.) Status -- This change has been

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2014-11-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/#review70581 --- Ship it! Looks sane to me, also solves a real-world problem.

Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()

2014-11-18 Thread Daniel Vrátil
On Nov. 16, 2014, 10:05 p.m., David Faure wrote: src/kcodecsbase64.h, line 161 https://git.reviewboard.kde.org/r/121047/diff/1/?file=327086#file327086line161 What a weird codec name?? Looks weird, but is correct. This is the name of the encoding that appears in MIME-encoded

Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()

2014-11-18 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/ --- (Updated Nov. 18, 2014, 2:31 p.m.) Review request for KDE Frameworks,

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext - HTML conversion

2014-11-18 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121094/ --- (Updated Nov. 18, 2014, 2:37 p.m.) Review request for KDE Frameworks and

Re: Review Request 120155: Correctly load non-square icons in KIconLoader

2014-11-18 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120155/ --- (Updated Nov. 18, 2014, 2:38 p.m.) Status -- This change has been

Re: Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2014-11-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121086/#review70583 --- thumbnail/CMakeLists.txt

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70598 --- Ship it! Ship It! - Marco Martin On Nov. 13, 2014, 6:24

Re: Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line

2014-11-18 Thread Michael Hansen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120760/ --- (Updated Nov. 18, 2014, 6:55 p.m.) Status -- This change has been

Review Request 121172: Move libgit2-related macro defs into config.h

2014-11-18 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121172/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository:

Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()

2014-11-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/#review70616 --- Ship it! src/kcodecs.h

Review Request 121173: Use correct version in kbuildsycoca5 executable

2014-11-18 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121173/ --- Review request for KDE Frameworks. Repository: kservice Description

Re: Review Request 121173: Use correct version in kbuildsycoca5 executable

2014-11-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121173/#review70632 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 18, 2014,

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2014-11-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/#review70581 --- Ship it! Looks sane to me, also solves a real-world problem.

Re: desktoptojson and list properties

2014-11-18 Thread Sebastian Kügler
On Monday, November 17, 2014 18:50:04 Milian Wolff wrote: Or can we nowadays write the .json files directly, i.e. can scripty/ki18n cope with them nowadays? So, any chance we can use .json directly here? That should be possible, you can just drop the json file in there, and

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Thomas Lübking
On Nov. 17, 2014, 9:45 nachm., Thomas Lübking wrote: attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56 https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56 is KdePlatformDependent::~KdePlatformDependent() { if

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Milian Wolff
On Tuesday 18 November 2014 12:48:42 Sebastian Kügler wrote: On Monday, November 17, 2014 18:50:04 Milian Wolff wrote: Or can we nowadays write the .json files directly, i.e. can scripty/ki18n cope with them nowadays? So, any chance we can use .json directly here?

Re: Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2014-11-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121086/#review70583 --- thumbnail/CMakeLists.txt

Review Request 121169: Use QFile::decodeName for command in KDEsuDialog to fix encoding

2014-11-18 Thread Andrey Bondrov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121169/ --- Review request for KDE Runtime. Repository: kde-runtime Description

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Jeremy Whiting
On Nov. 17, 2014, 2:45 p.m., Thomas Lübking wrote: attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56 https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56 is KdePlatformDependent::~KdePlatformDependent() { if

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/#review70601 --- Ship it! Ship It! - Albert Astals Cid On nov. 17, 2014,

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Thomas Lübking
On Nov. 17, 2014, 9:45 nachm., Thomas Lübking wrote: attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56 https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56 is KdePlatformDependent::~KdePlatformDependent() { if

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/ --- (Updated Nov. 18, 2014, 7:30 p.m.) Status -- This change has been

Re: Review Request 121169: Use QFile::decodeName for command in KDEsuDialog to fix encoding

2014-11-18 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121169/#review70605 --- Ship it! Please commit to kdesu framework as well - Lukáš

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Albert Astals Cid
El Dimarts, 18 de novembre de 2014, a les 14:09:00, Milian Wolff va escriure: On Tuesday 18 November 2014 12:48:42 Sebastian Kügler wrote: On Monday, November 17, 2014 18:50:04 Milian Wolff wrote: Or can we nowadays write the .json files directly, i.e. can scripty/ki18n cope

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Milian Wolff
On Tuesday 18 November 2014 22:31:08 Albert Astals Cid wrote: El Dimarts, 18 de novembre de 2014, a les 14:09:00, Milian Wolff va escriure: On Tuesday 18 November 2014 12:48:42 Sebastian Kügler wrote: On Monday, November 17, 2014 18:50:04 Milian Wolff wrote: Or can we nowadays write

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Albert Astals Cid
El Dimarts, 18 de novembre de 2014, a les 23:35:48, Milian Wolff va escriure: On Tuesday 18 November 2014 22:31:08 Albert Astals Cid wrote: El Dimarts, 18 de novembre de 2014, a les 14:09:00, Milian Wolff va escriure: On Tuesday 18 November 2014 12:48:42 Sebastian Kügler wrote: On

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Alex Merry
On Tuesday 18 November 2014 23:45:56 Albert Astals Cid wrote: I didn't even know we were using json now. Why did we change from .desktop file to .json ones? What's the benefit? Seems like .desktop files did their job good enough and we have all the tooling available already. Because that's

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Albert Astals Cid
El Dimarts, 18 de novembre de 2014, a les 23:01:14, Alex Merry va escriure: On Tuesday 18 November 2014 23:45:56 Albert Astals Cid wrote: I didn't even know we were using json now. Why did we change from .desktop file to .json ones? What's the benefit? Seems like .desktop files did their

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Kevin Funk
On Wednesday 19 November 2014 00:09:25 Albert Astals Cid wrote: El Dimarts, 18 de novembre de 2014, a les 23:01:14, Alex Merry va escriure: On Tuesday 18 November 2014 23:45:56 Albert Astals Cid wrote: I didn't even know we were using json now. Why did we change from .desktop file to

Re: Review Request 121169: Use QFile::decodeName for command in KDEsuDialog to fix encoding

2014-11-18 Thread Andrey Bondrov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121169/ --- (Updated Ноя. 19, 2014, 1:52 д.п.) Status -- This change has been

Re: Review Request 121169: Use QFile::decodeName for command in KDEsuDialog to fix encoding

2014-11-18 Thread Andrey Bondrov
On Ноя. 18, 2014, 7:46 п.п., Lukáš Tinkl wrote: Please commit to kdesu framework as well Done. - Andrey --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121169/#review70605

Re: DBUS issues with KDE 4 and Frameworks 5

2014-11-18 Thread Milian Wolff
On Monday 17 November 2014 11:27:31 Thiago Macieira wrote: On Monday 17 November 2014 20:12:41 Milian Wolff wrote: Yep, that is also what is documented on the Techbase article. Thing is, I don't want multiple dbus sessions (see the first mail of this thread). But when I log in to my KDE4

new-age kde : which c++?

2014-11-18 Thread Mayuresh Kathe
hello, returning to c++ and kde after a really long (16 years) time. has kde moved to modern (2011/2014) c++ yet? a google search for kde c++ version wasn't very helpful. ~mayuresh Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: new-age kde : which c++?

2014-11-18 Thread Luigi Toscano
On Tuesday 18 of November 2014 20:29:20 Mayuresh Kathe wrote: hello, returning to c++ and kde after a really long (16 years) time. has kde moved to modern (2011/2014) c++ yet? a google search for kde c++ version wasn't very helpful. What do you mean by KDE? Those are the current rules for

Re: new-age kde : which c++?

2014-11-18 Thread Aleix Pol
On Tue, Nov 18, 2014 at 3:59 PM, Mayuresh Kathe mayur...@kathe.in wrote: hello, returning to c++ and kde after a really long (16 years) time. has kde moved to modern (2011/2014) c++ yet? a google search for kde c++ version wasn't very helpful. ~mayuresh Hi Mayuresh! Really good to see

Re: new-age kde : which c++?

2014-11-18 Thread Mayuresh Kathe
On 2014-11-18 20:36, Aleix Pol wrote: On Tue, Nov 18, 2014 at 3:59 PM, Mayuresh Kathe mayur...@kathe.in wrote: hello, returning to c++ and kde after a really long (16 years) time. has kde moved to modern (2011/2014) c++ yet? a google search for kde c++ version wasn't very helpful. ~mayuresh

Re: new-age kde : which c++?

2014-11-18 Thread Jeremy Whiting
Mayuresh, Welcome back. Yes gcc does, but we don't only build with gcc, we also build with mingw, and msvc at least. BR, Jeremy On Tue, Nov 18, 2014 at 8:20 AM, Mayuresh Kathe mayur...@kathe.in wrote: On 2014-11-18 20:36, Aleix Pol wrote: On Tue, Nov 18, 2014 at 3:59 PM, Mayuresh Kathe

Re: DBUS issues with KDE 4 and Frameworks 5

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 12:41:57 Milian Wolff wrote: Right, which brings me back to step one :) Or maybe I'm missing something, but: Assuming I add my custom KF5 path to XDG_DATA_DIRS even in my KDE4 session, isn't that highly unsafe considering the other environment variables are not

Re: DBUS issues with KDE 4 and Frameworks 5

2014-11-18 Thread Milian Wolff
On Tuesday 18 November 2014 09:55:52 Thiago Macieira wrote: On Tuesday 18 November 2014 12:41:57 Milian Wolff wrote: Right, which brings me back to step one :) Or maybe I'm missing something, but: Assuming I add my custom KF5 path to XDG_DATA_DIRS even in my KDE4 session, isn't that