Interested in Contribution

2015-05-04 Thread Dhriti Shikhar
Hello, I am Dhriti Shikhar from Pune, India. I am currently studying engineering in Pune University. I program in Python, C, C++, javascript/jquery, HTML. I have hands-on experience on git, Flask, Vim, reStructured Text, shell scripting. I have also worked on PHP, MySQL, mongodb for my

Re: [KDE/Mac] CI for kf5-qt5 is not green anymore

2015-05-04 Thread René J . V . Bertin
On Saturday May 02 2015 09:42:44 Scarlett Clark wrote: On Saturday, May 02, 2015 10:20:27 AM David Faure wrote: KMainWindow_UnitTest::testDefaultName() Cannot create window: no screens available Yes it is a CI issue. We connect to slaves via SSH and therefore GUI is not available. I am not a

Re: Review Request 123570: Add a method to insert new known structures

2015-05-04 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/#review79836 --- Ship it! src/kpackage/packageloader.h (line 85)

Install location of myframework_version.h headers

2015-05-04 Thread Kevin Funk
Heya, I'm wondering why, for instance, ktexteditor_version.h is installed to $PREFIX/include/KF5 instead of $PREFIX/include/KF5/KTextEditor. This currently leads to confusing behavior when trying to include this header if two versions of KTextEditor are installed in different locations.

Re: Install location of myframework_version.h headers

2015-05-04 Thread Kevin Funk
On Monday, May 04, 2015 12:23:32 Kevin Funk wrote: Heya, I'm wondering why, for instance, ktexteditor_version.h is installed to $PREFIX/include/KF5 instead of $PREFIX/include/KF5/KTextEditor. This currently leads to confusing behavior when trying to include this header if two versions of

Re: Install location of myframework_version.h headers

2015-05-04 Thread David Faure
On Monday 04 May 2015 12:23:32 Kevin Funk wrote: The issue could be easily fixed by moving the myframework_version.h into $PREFIX/include/KF5/$FRAMEWORK/, no? Correct, this is what KArchive does. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Install location of myframework_version.h headers

2015-05-04 Thread David Faure
On Monday 04 May 2015 12:29:39 David Faure wrote: On Monday 04 May 2015 12:23:32 Kevin Funk wrote: The issue could be easily fixed by moving the myframework_version.h into $PREFIX/include/KF5/$FRAMEWORK/, no? Correct, this is what KArchive does. Ooops, I thought we were talking about the

Re: Review Request 123528: Add missing license file: COPYING.LGPL-2

2015-05-04 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123528/ --- (Updated May 4, 2015, 11:58 a.m.) Status -- This change has been

Re: Review Request 123528: Add missing license file: COPYING.LGPL-2

2015-05-04 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123528/#review79838 --- Ship it! Ship It! - Jonathan Riddell On April 27, 2015,

Re: Install location of myframework_version.h headers

2015-05-04 Thread Kevin Funk
On Monday 04 May 2015 13:11:05 David Faure wrote: On Monday 04 May 2015 12:29:39 David Faure wrote: On Monday 04 May 2015 12:23:32 Kevin Funk wrote: The issue could be easily fixed by moving the myframework_version.h into $PREFIX/include/KF5/$FRAMEWORK/, no? Correct, this is what

Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 4, 2015, 1:03 p.m.) Review request for KDE Frameworks and

Re: Review Request 123570: Add a method to insert new known structures

2015-05-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/ --- (Updated May 4, 2015, 1:25 p.m.) Status -- This change has been

Review Request 123630: Remove unused dependency.

2015-05-04 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123630/ --- Review request for KDE Frameworks. Repository: kross Description

Review Request 123631: Only add a '/' if the url does not end with one

2015-05-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123631/ --- Review request for KDE Frameworks, Àlex Fiestas and David Faure.

Re: Review Request 123630: Remove unused dependency.

2015-05-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123630/#review79847 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 4, 2015,

Re: Review Request 123101: Only add / to path if really necessary

2015-05-04 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123101/ --- (Updated May 4, 2015, 3:13 p.m.) Status -- This change has been

Review Request 123632: Fix the i18n after Jerome's patch

2015-05-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123632/ --- Review request for KDE Frameworks. Repository: kglobalaccel

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-05-04 Thread Martin Klapetek
On May 3, 2015, 2:34 p.m., Albert Astals Cid wrote: I'm confused, the title say Remove KAboutData and then goes and changes i18n while breaking it? I mean i18n handling is relatively easy, and we have pretty good documentation at

Re: Review Request 123631: Only add a '/' if the url does not end with one

2015-05-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123631/#review79855 --- Ship it! You can differentiate between smb:// and smb: by

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 4, 2015, 5:44 p.m.) Review request for KDE Frameworks and

Re: [KDE/Mac] CI for kf5-qt5 is not green anymore

2015-05-04 Thread Bradley Giesbrecht
On May 4, 2015, at 2:00 AM, René J.V. Bertin rjvber...@gmail.com wrote: On Saturday May 02 2015 09:42:44 Scarlett Clark wrote: On Saturday, May 02, 2015 10:20:27 AM David Faure wrote: KMainWindow_UnitTest::testDefaultName() Cannot create window: no screens available Yes it is a CI issue.

Circular dependency in kde-build-metadata

2015-05-04 Thread Daniel Vrátil
Hi, commit a5f6c247d99db3a3f565f5fa8d1346420e5a892c (frameworksintegration tests want oxygen-fonts) in kde-build-metadata has introduced a circular dependency between frameworkintegration and oxygen, leading to $ kdesrc-build --refresh-build kf5 plasma5 * Downloading projects.kde.org project

Re: Interested in Contribution

2015-05-04 Thread Claudio Autiero
Albert, https://bugs.kde.org/show_bug.cgi?id=342927 should be relatively simple. This is a future request ;-) and Okular it's ok for now (I think). We can ask to a devel of Okular if is smart to make this new implementation. All the best, Claudio Il 04/05/2015 22:44, Albert Astals Cid ha

Re: Interested in Contribution

2015-05-04 Thread Aleix Pol
On Tue, May 5, 2015 at 1:23 AM, Claudio Autiero robotic.stea...@gmail.com wrote: Albert, https://bugs.kde.org/show_bug.cgi?id=342927 should be relatively simple. This is a future request ;-) and Okular it's ok for now (I think). We can ask to a devel of Okular if is smart to make this new

Re: Interested in Contribution

2015-05-04 Thread Claudio Autiero
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Alex Albert, @Alex I only congratulated for Okular APP :P @Albert How Dhriti Shikhar I'm a new and if it is ok for you we can try to make this implementation together. Claudio. Il 05/05/2015 01:37, Aleix Pol ha scritto: On Tue, May 5, 2015 at

Re: Review Request 123632: Fix the i18n after Jerome's patch

2015-05-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123632/#review79867 --- Ship it! Ship It! - Albert Astals Cid On mai. 4, 2015,

Re: Circular dependency in kde-build-metadata

2015-05-04 Thread Scarlett Clark
On Monday, May 04, 2015 01:51:52 PM Daniel Vrátil wrote: Hi, commit a5f6c247d99db3a3f565f5fa8d1346420e5a892c (frameworksintegration tests want oxygen-fonts) in kde-build-metadata has introduced a circular dependency between frameworkintegration and oxygen, leading to $ kdesrc-build

Re: Review Request 123632: Fix the i18n after Jerome's patch

2015-05-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123632/#review79868 --- Sorry, that's not enough you need to add the loader to the

Re: Interested in Contribution

2015-05-04 Thread Albert Astals Cid
El Dilluns, 4 de maig de 2015, a les 16:12:20, Dhriti Shikhar va escriure: Hello, I am Dhriti Shikhar from Pune, India. I am currently studying engineering in Pune University. I program in Python, C, C++, javascript/jquery, HTML. I have hands-on experience on git, Flask, Vim, reStructured