Re: Review Request 123811: Use tcgetattr tcsetattr if available

2015-05-17 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123811/#review80499 --- Ship it! Ship It! - Oswald Buddenhagen On May 16, 2015,

Re: Review Request 123811: Use tcgetattr tcsetattr if available

2015-05-17 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123811/ --- (Updated May 17, 2015, 8:47 a.m.) Status -- This change has been

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: klipper/klipper.kcfg, line 32 https://git.reviewboard.kde.org/r/123806/diff/3/?file=369517#file369517line32 It would be immensely useful, if Klipper also showed leading/trailing whitespace, i.e. for items that aren't completely

Re: Review Request 123803: Coding Style for k7zip.cpp kar.cpp karchive.cpp kbzip2filter.cpp kcompressiondevice.cpp kfilterdev.cpp kgzipfilter.cpp klimitediodevice.cpp knonefilter.cpp krcc.cpp ktar.cpp

2015-05-17 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123803/ --- (Updated May 17, 2015, 4:03 p.m.) Status -- This change has been

Review Request 123830: Coding Style for main.cpp

2015-05-17 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123830/ --- Review request for KDE Frameworks, Mario Bensi and David Faure.

Review Request 123831: Coding Style for main.cpp

2015-05-17 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123831/ --- Review request for KDE Frameworks, Mario Bensi and David Faure.

Re: Review Request 121471: Port KDirSelectDialog to QFileDialog

2015-05-17 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121471/ --- (Updated Kvě. 17, 2015, 5:04 odp.) Status -- This change has been

Re: Review Request 123803: Coding Style for k7zip.cpp kar.cpp karchive.cpp kbzip2filter.cpp kcompressiondevice.cpp kfilterdev.cpp kgzipfilter.cpp klimitediodevice.cpp knonefilter.cpp krcc.cpp ktar.cpp

2015-05-17 Thread Guy Maurel
On May 15, 2015, 9:49 p.m., David Faure wrote: About your commit log: we won't have a different coding style for karchive, all frameworks should follow https://techbase.kde.org/Policies/Kdelibs_Coding_Style and https://techbase.kde.org/Policies/Library_Code_Policy About the

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Christoph Feck
On May 16, 2015, 9:37 p.m., Patrick Eigensatz wrote: klipper/historyitem.cpp, line 91 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91 I'm not sure if I can access Klipper from here. If I have a look at how this is done at other options then I see

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: klipper/historyitem.cpp, line 91 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91 I'm not sure if I can access Klipper from here. If I have a look at how this is done at other options then I see

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Pfeiffer
On May 16, 2015, 9:37 p.m., Patrick Eigensatz wrote: klipper/historyitem.cpp, line 91 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91 I'm not sure if I can access Klipper from here. If I have a look at how this is done at other options then I see

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Pfeiffer
On May 16, 2015, 9:37 p.m., Patrick Eigensatz wrote: klipper/historyitem.cpp, line 91 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91 I'm not sure if I can access Klipper from here. If I have a look at how this is done at other options then I see

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Martin Gräßlin
On May 17, 2015, 8:22 p.m., Martin Gräßlin wrote: klipper/generalconfig.ui, lines 36-45 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369604#file369604line36 unrelated to the discussion about how to call the entries: I would call the config option differently as the code

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: klipper/historyitem.cpp, line 91 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91 I'm not sure if I can access Klipper from here. If I have a look at how this is done at other options then I see

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Martin Gräßlin
On May 17, 2015, 8:22 p.m., Martin Gräßlin wrote: klipper/generalconfig.ui, lines 36-45 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369604#file369604line36 unrelated to the discussion about how to call the entries: I would call the config option differently as the code

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
On Mai 17, 2015, 6:22 nachm., Martin Gräßlin wrote: klipper/generalconfig.ui, lines 36-45 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369604#file369604line36 unrelated to the discussion about how to call the entries: I would call the config option differently as the

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Martin Gräßlin
On May 16, 2015, 11:37 p.m., Patrick Eigensatz wrote: klipper/historyitem.cpp, line 91 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91 I'm not sure if I can access Klipper from here. If I have a look at how this is done at other options then I see

Solid::AcAdapter gone w/o replacement, ie. all is Battery now?

2015-05-17 Thread Thomas Lübking
Solid::AcAdapter was removed from the API and I don't see a replacement. Does that mean one only has to care about Solid::Battery in KF5? And if: how do I know the System is on AC? Battery::chargeState() != Battery::Discharging? Thanks, Thomas Visit

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Lübking
On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: klipper/historyitem.cpp, line 91 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91 I'm not sure if I can access Klipper from here. If I have a look at how this is done at other options then I see

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: klipper/historyitem.cpp, line 91 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91 I'm not sure if I can access Klipper from here. If I have a look at how this is done at other options then I see

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Lübking
On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: klipper/klipper.kcfg, line 32 https://git.reviewboard.kde.org/r/123806/diff/3/?file=369517#file369517line32 It would be immensely useful, if Klipper also showed leading/trailing whitespace, i.e. for items that aren't completely

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Pfeiffer
On May 16, 2015, 4:37 p.m., Christoph Feck wrote: klipper/klipper.kcfg, line 32 https://git.reviewboard.kde.org/r/123806/diff/3/?file=369517#file369517line32 It would be immensely useful, if Klipper also showed leading/trailing whitespace, i.e. for items that aren't completely

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Lübking
On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: klipper/klipper.kcfg, line 32 https://git.reviewboard.kde.org/r/123806/diff/3/?file=369517#file369517line32 It would be immensely useful, if Klipper also showed leading/trailing whitespace, i.e. for items that aren't completely

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Pfeiffer
On May 16, 2015, 4:37 p.m., Christoph Feck wrote: klipper/klipper.kcfg, line 32 https://git.reviewboard.kde.org/r/123806/diff/3/?file=369517#file369517line32 It would be immensely useful, if Klipper also showed leading/trailing whitespace, i.e. for items that aren't completely

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806/#review80532 --- klipper/generalconfig.ui (lines 36 - 45)

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
On Mai 17, 2015, 6:22 nachm., Martin Gräßlin wrote: klipper/generalconfig.ui, lines 36-45 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369604#file369604line36 unrelated to the discussion about how to call the entries: I would call the config option differently as the

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Christoph Feck
On May 16, 2015, 9:37 p.m., Patrick Eigensatz wrote: klipper/historyitem.cpp, line 91 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91 I'm not sure if I can access Klipper from here. If I have a look at how this is done at other options then I see

Re: Solid::AcAdapter gone w/o replacement, ie. all is Battery now?

2015-05-17 Thread Thiago Macieira
On Sunday 17 May 2015 11:39:46 Thomas Lübking wrote: Solid::AcAdapter was removed from the API and I don't see a replacement. Does that mean one only has to care about Solid::Battery in KF5? And if: how do I know the System is on AC? Battery::chargeState() != Battery::Discharging? That's

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: klipper/historyitem.cpp, line 91 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91 I'm not sure if I can access Klipper from here. If I have a look at how this is done at other options then I see

Re: Solid::AcAdapter gone w/o replacement, ie. all is Battery now?

2015-05-17 Thread Kai Uwe Broulik
Hi Thomas, I'm afraid there is no replacement currently, the overall situation is a bit of a mess. Lukas Tinkl is currently working on a proper replacement for the Solid::PowerManagement stuff, called solid-power, which will have the appShouldConserveResources thingie like the old one.

Re: Solid::AcAdapter gone w/o replacement, ie. all is Battery now?

2015-05-17 Thread Thomas Lübking
On Sonntag, 17. Mai 2015 21:32:55 CEST, Kai Uwe Broulik wrote: Sorry for the inconvenience, No problem. As Thiago confirmed, iterating over all batteries to check if any is discharging actually is sufficient (if there's no battery or none discharging we're either on AC, just nuked #1

Re: Solid::AcAdapter gone w/o replacement, ie. all is Battery now?

2015-05-17 Thread Kai Uwe Broulik
The only problem could be if NoCharge means Unknown, but I assume that's academic. NoCharge as far as Solid Battery is concerned means either not charging, not yet charging (eg. just plugged in AC), not yet discharging (pending discharge), or unknown. It does know fully charged, however. My

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Lübking
On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: klipper/klipper.kcfg, line 32 https://git.reviewboard.kde.org/r/123806/diff/3/?file=369517#file369517line32 It would be immensely useful, if Klipper also showed leading/trailing whitespace, i.e. for items that aren't completely