Re: Icons installed by apps

El Dimarts, 22 de setembre de 2015, a les 23:01:06, Jaroslaw Staniek va escriure: > On 22 September 2015 at 22:55, Matthias Klumpp wrote: > > Am 22.09.2015 10:32 nachm. schrieb "Albert Astals Cid" : > >> El Dimarts, 22 de setembre de 2015, a les 14:17:28, Jaroslaw Staniek va > >> > >> escriure:

Re: Review Request 125351: Don't ignore AND subterm if there is no results

> On Сен. 22, 2015, 5:26 п.п., Vishesh Handa wrote: > > Oh wow. This is bad. Thanks for diagnosing it. > > > > I'm wondering if this is the best way of solving it. The assumption always > > is that if a DB does not have any values then it can just return 0. If we > > change this assumption in

Re: Icons installed by apps

On 22 September 2015 at 22:55, Matthias Klumpp wrote: > > Am 22.09.2015 10:32 nachm. schrieb "Albert Astals Cid" : >> >> El Dimarts, 22 de setembre de 2015, a les 14:17:28, Jaroslaw Staniek va >> escriure: >> > Hello, >> > A couple of related questions while wrestling with issues such as [1]. >> >

Re: Review Request 125352: Prevent Baloo::File::load() from creating a transaction if the Database is not open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125352/#review85788 --- Can this checked by an autotest? - Albert Astals Cid On set

Re: Review Request 125351: Don't ignore AND subterm if there is no results

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125351/#review85787 --- Can this checked by an autotest? - Albert Astals Cid On set

Re: Icons installed by apps

El Dimarts, 22 de setembre de 2015, a les 14:17:28, Jaroslaw Staniek va escriure: > Hello, > A couple of related questions while wrestling with issues such as [1]. > > Let's assume Kexi app installs some icons to > PREFIX/share/kexi/icons/oxygen/32x32/places/ or > PREFIX/share/kexi/icons/breeze/3

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

> On Sept. 16, 2015, 12:37 a.m., Vishesh Handa wrote: > > kcms/baloo/kcm.cpp, line 168 > > > > > > I'm really not too sure about this. So the display name is taken and > > that is compared with the mountPoint? >

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/ --- (Updated Sept. 22, 2015, 10:24 p.m.) Review request for Baloo, Plasma and

Re: Review Request 125352: Prevent Baloo::File::load() from creating a transaction if the Database is not open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125352/ --- (Updated Sept. 22, 2015, 6:58 p.m.) Status -- This change has been m

Re: Review Request 125352: Prevent Baloo::File::load() from creating a transaction if the Database is not open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125352/#review85780 --- Ship it! Ship It! - Armin K. On Sept. 22, 2015, 6:51 p.m.,

Re: Review Request 125352: Prevent Baloo::File::load() from creating a transaction if the Database is not open

> On Sept. 22, 2015, 6:56 p.m., Armin K. wrote: > > Ship It! It fixes the issue for me too. - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125352/#review85780 --

Re: Review Request 125352: Prevent Baloo::File::load() from creating a transaction if the Database is not open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125352/#review85779 --- Ship it! - Pinak Ahuja On Sept. 22, 2015, 6:51 p.m., Boudha

Review Request 125352: Prevent Baloo::File::load() from creating a transaction if the Database is not open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125352/ --- Review request for Baloo, Pinak Ahuja and Vishesh Handa. Repository: balo

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

> On Sept. 15, 2015, 9:37 nachm., Vishesh Handa wrote: > > kcms/baloo/kcm.cpp, line 168 > > > > > > I'm really not too sure about this. So the display name is taken and > > that is compared with the mountPoint?

Re: Icons installed by apps

On Dienstag, 22. September 2015 18:44:47 CEST, Jaroslaw Staniek wrote: Sorry for adding more info to clarify. UserIconSet is deprecated so I guess this functionality is deprecated too... since QIcon::fromTheme() apaprently isn't able to find app icons. tried KIconLoader::global()->addAppDir(co

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

> On Sept. 16, 2015, 12:37 a.m., Vishesh Handa wrote: > > kcms/baloo/kcm.cpp, line 168 > > > > > > I'm really not too sure about this. So the display name is taken and > > that is compared with the mountPoint? >

Re: Review Request 125351: Don't ignore AND subterm if there is no results

> On Sept. 22, 2015, 5:26 p.m., Vishesh Handa wrote: > > Oh wow. This is bad. Thanks for diagnosing it. > > > > I'm wondering if this is the best way of solving it. The assumption always > > is that if a DB does not have any values then it can just return 0. If we > > change this assumption in

Re: Review Request 125351: Don't ignore AND subterm if there is no results

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125351/#review85773 --- Oh wow. This is bad. Thanks for diagnosing it. I'm wondering

Re: Review Request 125351: Don't ignore AND subterm if there is no results

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125351/ --- (Updated Сен. 22, 2015, 5:06 п.п.) Review request for Baloo. Changes --

Re: Icons installed by apps

On 22 September 2015 at 14:17, Jaroslaw Staniek wrote: > Hello, > A couple of related questions while wrestling with issues such as [1]. > > Let's assume Kexi app installs some icons to > PREFIX/share/kexi/icons/oxygen/32x32/places/ or > PREFIX/share/kexi/icons/breeze/32x32/places. > Can these be

Review Request 125351: Don't ignore AND subterm if there is no results

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125351/ --- Review request for Baloo. Repository: baloo Description --- This i

Icons installed by apps

Hello, A couple of related questions while wrestling with issues such as [1]. Let's assume Kexi app installs some icons to PREFIX/share/kexi/icons/oxygen/32x32/places/ or PREFIX/share/kexi/icons/breeze/32x32/places. Can these be searched by the icon engine? In kdelibs4 times PREFIX/share/apps/kex

Re: Review Request 125330: IndexerConfig: Add a refresh() method to

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125330/ --- (Updated Sept. 22, 2015, 7:08 a.m.) Status -- This change has been m