Re: Review Request 125362: Avoid QByteArray::fromRawData

> On Сен. 25, 2015, 3:12 д.п., Milian Wolff wrote: > > src/codecs/doctermscodec.cpp, line 73 > > > > > > this and the below cases look fine to me - anything else sounds super > > dangerous and could leak to subtl

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

> On Сен. 24, 2015, 11:50 п.п., Vishesh Handa wrote: > > runners/baloo/baloosearchrunner.cpp, line 165 > > > > > > Have a look at basicindexingjob.txt. We define that all Presentation > > and Spreadsheets are al

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

> On Sept. 24, 2015, 11:50 p.m., Vishesh Handa wrote: > > runners/baloo/baloosearchrunner.cpp, line 165 > > > > > > Have a look at basicindexingjob.txt. We define that all Presentation > > and Spreadsheets are a

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

> On Сен. 24, 2015, 11:50 п.п., Vishesh Handa wrote: > > runners/baloo/baloosearchrunner.cpp, line 165 > > > > > > Have a look at basicindexingjob.txt. We define that all Presentation > > and Spreadsheets are al

Re: Review Request 125374: TagListJob: Emit error when failed to open database

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125374/ --- (Updated Sept. 25, 2015, 7:45 a.m.) Status -- This change has been m

Re: Review Request 125359: Remove baloo-monitor from baloo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/ --- (Updated Sept. 25, 2015, 7:55 a.m.) Status -- This change has been m

Re: Icons installed by apps

Thanks for advice David. In the specs I see no mention about using share/{app}/ subdirs. I also noted this: "It is recommended that the icons installed in the hicolor theme look neutral, since it is a fallback theme that will be used in combination with some very different looking themes." For th

Re: DBus service for screenshots.

On 24/09/15 23:54, Emmanuele Bassi wrote: > On 24 September 2015 at 23:25, Boudhayan Gupta wrote: >> The service we've implemented is called org.freedesktop.Screenshot >> (we're using the freedesktop namespace because we truly want the >> service to be DE or platform agnostic). > > Commendable sp

Re: DBus service for screenshots.

Hi; you also want to use xdg-list, not dbus-list, for discussing a shared DBus interface. Ciao, Emmanuele. On 24 September 2015 at 23:54, Emmanuele Bassi wrote: > Hi; > > On 24 September 2015 at 23:25, Boudhayan Gupta wrote: >> Hi, >> >> In December we'll be releasing a new screenshot app for

Re: DBus service for screenshots.

Hi; On 24 September 2015 at 23:25, Boudhayan Gupta wrote: > Hi, > > In December we'll be releasing a new screenshot app for KDE. We've > implemented a generic DBus interface for this app, and I'm posting > this to the dbus mailing list as others may be interested in this idea > and may want to im

Re: DBus service for screenshots.

Hi, I'm moving this discussion over to the xdg mailing list, as per suggestions from the dbus list. On 25 September 2015 at 04:24, Emmanuele Bassi wrote: > Hi; > > On 24 September 2015 at 23:25, Boudhayan Gupta wrote: >> Hi, >> >> In December we'll be releasing a new screenshot app for KDE. We'

Re: DBus service for screenshots.

> So what's the expected flow here? You don't have any way of providing > a filename to the Agent for further manipulation and publishing. Is > the Agent expected to show all recently taken thumbnails in a grid or > similar, and have the user select them? What's the expectation here? I think we're

Re: DBus service for screenshots.

On Fri, Sep 25, 2015 at 8:09 AM, Boudhayan Gupta wrote: ... snip ... > The use-case for StartAgent is simple - what if a supervisor (such as > the compositor on Wayland) is providing the service, but a separate > application (agent) provides manipulation, editing, saving etc. > functionality? So

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/ --- (Updated Sept. 25, 2015, 10:58 p.m.) Status -- This change has been

Review Request 125401: implement windows usermetadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125401/ --- Review request for Baloo and kdewin. Repository: kfilemetadata Descript