Ok, frameworks branch merged to master now. I'll delete the frameworks branch now too. I updated the logical-module-structure and translation branches on projects.kde.org already also.
thanks, Jeremy On Sat, Oct 10, 2015 at 5:37 AM, Albert Astals Cid <aa...@kde.org> wrote: > El Saturday 10 October 2015, a les 04:41:32, Jeremy Whiting va escriure: >> Yeah, that's the latest. I e-mailed Urs about krdc and mentioned krfb >> also. He suggested asking for a general review, so that's what this >> is now. > > Looks good to me, could not find anything wrong and seems to work fine. > > Cheers, > Albert > >> >> thanks, >> Jeremy >> >> On Sat, Oct 10, 2015 at 3:26 AM, Albert Astals Cid <aa...@kde.org> wrote: >> > El Friday 09 October 2015, a les 10:40:56, Jeremy Whiting va escriure: >> >> Hello all, >> >> >> >> I've ported Krfb to kf5/qt5 on the frameworks branch. >> > >> > Last commit is September 17, did you forget to push some stuff or this is >> > an email you wanted to write a while ago? >> > >> > Cheers, >> > >> > Albert >> >> >> >> It seems to work >> >> well here, but I am not the maintainer so thought it would be good if >> >> others can take a look at the code also. If one or two people would >> >> give it a try I would appreciate it. I'd like to merge frameworks >> >> branch to master before the November Applications 15.12 dependency >> >> freeze date. Note the following with the port. >> >> >> >> All telepathy tubes support has been removed since it doesn't work >> >> well with existing telepathy protocols anyway after discussing with >> >> kde-telepathy maintainers. >> >> >> >> thanks, >> >> Jeremy >> >> >> >> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to >> >> >> unsubscribe >> >> >> << >> >> >> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe >> >> << > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
