Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-27 Thread taro yamada
> On Oct. 27, 2016, 7:13 p.m., Andreas Hartmetz wrote: > > Taro, do you have push rights? Otherwise I or somebody else can push it for > > you. Ah, I was misunderstanding the use of reviewboard. I'll try to push, thank you very much! - taro

Re: Review Request 129267: [OS X] emulate posix_fallocate()

2016-10-27 Thread Michael Pyne
> On Oct. 27, 2016, 1:55 a.m., Michael Pyne wrote: > > src/lib/caching/posix_fallocate_mac.h, line 97 > > > > > > Given that the user has some input into the size of the cache I'd > > prefer to have some kind of

Re: ABI break checking in frameworks

2016-10-27 Thread Albert Astals Cid
El dijous, 27 d’octubre de 2016, a les 9:20:29 CEST, Jaroslaw Staniek va escriure: > On 26 October 2016 at 23:54, Albert Astals Cid wrote: > > Does anyone have other ideas or thoughts on it? > > ​Three things: > - the Qt project has own solution for the checks, maybe worth

Re: announcement: Kwave is in kdereview

2016-10-27 Thread Albert Astals Cid
El dijous, 27 d’octubre de 2016, a les 21:48:40 CEST, Thomas Eschenbacher va escriure: > Albert Astals Cid wrote: > > [...] > > >>> These warnings look like nice to fix > >>> kf5.kcoreaddons.kaboutdata: Could not initialize the equivalent > >>> properties > >>> of Q*Application: no instance

Re: announcement: Kwave is in kdereview / recording / memory leak

2016-10-27 Thread Albert Astals Cid
El dijous, 27 d’octubre de 2016, a les 21:10:35 CEST, Thomas Eschenbacher va escriure: > Albert Astals Cid wrote: > > [...] > > >>> Pressed File->record and i got > >>> > >>>http://i.imgur.com/DUhCvVA.png > >>> > >>> I guess that's probably because that user doesn't have enough > >>>

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-27 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/#review100338 --- Ship it! Taro, do you have push rights? Otherwise I or

Re: announcement: Kwave is in kdereview

2016-10-27 Thread Thomas Eschenbacher
Albert Astals Cid wrote: > El dimecres, 12 d’octubre de 2016, a les 7:15:31 CEST, Thomas Eschenbacher va > escriure: > [...] >> BTW: how should we handle these findings during review phase: is it ok >> four you to handle/discuss them here on the mailing list, or shall we >> use some bug tracking

[Announcement] FOSDEM Desktops DevRoom 2017 CfP

2016-10-27 Thread Pau Garcia i Quiles
Hello, Here is the Call for Participation for the Desktops DevRoom 2017 -8<-- FOSDEM is one of the largest (5,000+ hackers!) gatherings of Free Software contributors in the world and happens each February in Brussels (Belgium, Europe). Once again, one of the tracks

Re: announcement: Kwave is in kdereview / _(...) macro

2016-10-27 Thread Thomas Eschenbacher
On 17.10.2016 23:30, Jan Kundrát wrote: > On úterý 11. října 2016 21:41:09 CEST, Thomas Eschenbacher wrote: >> the _(...) macro has nothing to do with i18n > > Isn't that a bit confusing? Underscore is used by gettext to mean the > *opposite* from what Kwave uses it for. really? I have never

Re: Test your applications on Wayland

2016-10-27 Thread Elvis Angelaccio
On Thu, Oct 13, 2016 at 2:31 PM, Adriaan de Groot wrote: > On Thursday, October 13, 2016 01:12:27 PM Martin Graesslin wrote: >> Just an example of an issue I run into today: >> https://git.reviewboard.kde.org/ r/129171/ >> >> Application just crashed on startup due to a missing

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-27 Thread taro yamada
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/ --- (Updated Oct. 27, 2016, 3:02 p.m.) Review request for KDE Frameworks.

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-27 Thread taro yamada
> On Oct. 27, 2016, 12:57 p.m., Andreas Hartmetz wrote: > > src/ioslaves/file/file.cpp, line 791 > > > > > > You can use qMin() here. As is the compiler would complain about the > > different types (off_t and

[Differential] [Request, 70 lines] D3178: Make kconfig_compiler autotests use the KCONFIG_ADD_KCFG_FILES

2016-10-27 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added a reviewer: Frameworks. REVISION SUMMARY Instead of having an odd fake of it. Will help some required refactorings and already showed some issues, fixed by this patch, namely: - don't use string(regex replace) to extract a string from another

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-27 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/#review100334 --- Ship it! In any case this is good enough already.

Re: Review Request 129267: [OS X] emulate posix_fallocate()

2016-10-27 Thread René J . V . Bertin
> On Oct. 27, 2016, 3:55 a.m., Michael Pyne wrote: > > src/lib/caching/posix_fallocate_mac.h, line 97 > > > > > > Given that the user has some input into the size of the cache I'd > > prefer to have some kind of

Re: state of release and release plan

2016-10-27 Thread Jaroslaw Staniek
On 27 October 2016 at 13:11, Friedrich W. H. Kossebau wrote: > Hi Dag & all, > > Am Mittwoch, 26. Oktober 2016, 14:03:12 CEST schrieb Dag: > > Hi > > Another month came and went, and not much happened... > > I'm actually a little afraid of releasing because we might attract

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-10-27 Thread Kai Uwe Broulik
> On Okt. 27, 2016, 10:38 vorm., Kai Uwe Broulik wrote: > > The problem with isNativeMenuBar() is that it returns true if the window > > *may* be a native menu bar, for example when the platform theme removes the > > AA_DontUseNativeMenuBar qApp flag. This does not mean that the platform > >

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-10-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/#review100331 --- The problem with isNativeMenuBar() is that it returns true

Re: Review Request 126028: Add support for desktopFileName to NETWinInfo

2016-10-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126028/ --- (Updated Oct. 27, 2016, 9:33 a.m.) Status -- This change has been

Re: ABI break checking in frameworks

2016-10-27 Thread Jaroslaw Staniek
On 26 October 2016 at 23:54, Albert Astals Cid wrote: > > > > Does anyone have other ideas or thoughts on it? > > ​Three things: - the Qt project has own solution for the checks, maybe worth looking - try to convert the compiler-specific decorated symbols to some uniform notation

Re: Review Request 129262: Properly finish DropJobs when triggered is not emitted

2016-10-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129262/#review100324 --- Ship it! Thanks for the fix. Given that there is no

Re: Bugzilla Update: Antispam modification deployed

2016-10-27 Thread Ben Cooksley
On Thu, Oct 27, 2016 at 3:52 AM, Marco Martin wrote: > On Wed, Oct 26, 2016 at 9:42 AM, Ben Cooksley wrote: >> Hi all, >> >> As some of you will already be aware, Bugzilla has recently been >> experiencing some issues with spam - courtesy of the same group