We need to enable auto close in github pull requests

Looking at https://github.com/pulls?q=is%3Apr+org%3Akde+is%3Aopen makes me very sad seeing how there's people that want to contribute but will never get an answer. Even if you click to those 109 closed you can see how there are some that are from people that clearly got fed up from waiting.

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

Proof of concept: https://commits.kde.org/scratch/rjvbb/osx-integration/1260a608db98cfd3d75bf15917945b59c81b1182 The same class also adds a simulated (emulated?) Menu key that's a real saver in those situations where I'm getting more side-effects from my trackpad's 2-finger right-tap than

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

jsalatas added a comment. In https://phabricator.kde.org/D4947#94562, @dhaumann wrote: > Reading this API, I still have some general thoughts: > This is the first time we expose the concept of "visible lines". So far, this only exists internally in katetextfolding.h/cpp. By itself,

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

jsalatas updated this revision to Diff 12416. jsalatas edited the summary of this revision. jsalatas added a comment. According to @cullmann's and @dhaumann's feedback created the `enum LineType` and also renamed `firstVisibleLine()` and `lastVisibleLine()` to `firstDisplayedLine()` and

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 20:21:33 David Faure wrote: > Forget QGesture, this can be done with simple mouse events. Another solution: catch mouse events for the desired QWidget types, use QGesture::grabbedGesture to check if they are subscribed and if not subscribe them. Re-implementing this

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 20:21:33 David Faure wrote: >Forget QGesture, this can be done with simple mouse events. Reinvent the wheel? Why not. I got the impression from the google results that led to finding the TapAndHold gesture solution that it could be trickier than you might think but

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 471 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/471/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 12 Mar 2017 19:22:10 + Build duration: 58 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 471 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/471/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 12 Mar 2017 19:22:10 + Build duration: 58 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On dimanche 12 mars 2017 20:14:20 CET René J.V. Bertin wrote: > On Sunday March 12 2017 20:11:08 René J.V. Bertin wrote: > > And a static method that takes a QWidget, subscribes it to the gesture and > > installs the event filter. > Correction: the event filter could of course be provided by a QPA

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 20:11:08 René J.V. Bertin wrote: > And a static method that takes a QWidget, subscribes it to the gesture and > installs the event filter. Correction: the event filter could of course be provided by a QPA platform plugin and installed at the application level. But what

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 17:52:25 David Faure wrote: > > And if you make it an optional feature in the QPA it (almost?) becomes > > something that users might want to control the way they could control > > certain things via Q4's qtconfig . > > Or systemsettings, sure. > > > Maybe the QPA

Re: no krazy reports for extragear

On Saturday, March 11, 2017 08:33:35 PM Alexander Semke wrote: > Hi all, > > since couple of days there are no krazy reports for couple of extragear > projects: > http://ebn.kde.org/krazy/index.php?component=extragear > > Is there any reason for this? > I think I know. I'll fix. -Allen

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 18:57:23 David Faure wrote: > Or I hold the mouse button pressed because I'm about to start a drag-n- > drop. One for which you wait too long then, something users of systems where tap-and-hold is usual (i.e. most of us?) would probably recognise. If you start

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 470 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/470/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 12 Mar 2017 17:52:59 + Build duration: 3.8 sec CHANGE SET No changes

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

dhaumann added a comment. Reading this API, I still have some general thoughts: This is the first time we expose the concept of "visible lines". So far, this only exists internally in katetextfolding.h/cpp. By itself, this is fine, but given we do not expose folding information so far, I

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On dimanche 12 mars 2017 18:38:04 CET René J.V. Bertin wrote: > On Sunday March 12 2017 17:52:25 David Faure wrote: > > It would trigger, sometimes against the user's will if he's a bit slow, on > > desktop systems where it's really not necessary since there's a right > > mouse button. > > Quite

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 17:52:25 David Faure wrote: > It would trigger, sometimes against the user's will if he's a bit slow, on > desktop systems where it's really not necessary since there's a right mouse > button. Quite slow, more like "oops, forgot to release the mousebutton". 700ms is

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f65946ece03c: Handle/truncate url display string assigned to job description. Prevents large… (authored by Lim Yuen Hoe ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D5030: kioexec: delegate upload to a kded module

elvisangelaccio edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5030 To: elvisangelaccio, dfaure Cc: #frameworks

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On dimanche 12 mars 2017 17:37:55 CET René J.V. Bertin wrote: > On Sunday March 12 2017 16:54:20 David Faure wrote: > >If it's about a very general long-click-should-open-context-menu then maybe > >it can be done globally in the QPA rather than in each and every widget? > Probably, yes. > > >It

D5030: kioexec: delegate upload to a kded module

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This introduces a kded module that kioexec can use to watch the cached files for changes. This allows kioexec to be fully

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 16:54:20 David Faure wrote: >If it's about a very general long-click-should-open-context-menu then maybe it >can be done globally in the QPA rather than in each and every widget? Probably, yes. >It would >then be a generic event handling thing. Off by default though,

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On dimanche 12 mars 2017 15:46:07 CET René J.V. Bertin wrote: > On Sunday March 12 2017 15:27:43 David Faure wrote: > > Isn't this exactly what QToolButton::setMenu does? > > (given that the default popupMode is DelayedPopup) > > Possible, one would indeed expect that from the description . >

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

cullmann added a comment. Perhaps we should introduce some enum for real vs. visible lines. The bool parameter looks not that understandable (yeah, we did that internally already wrong). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4947 To: jsalatas,

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

jsalatas updated this revision to Diff 12412. jsalatas added a comment. in `firstVisibleLine()` and `lastVisibleLine()` provide the option for real lines (in cases of folded text). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4947?vs=12396=12412

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 15:27:43 David Faure wrote: > Isn't this exactly what QToolButton::setMenu does? > (given that the default popupMode is DelayedPopup) Possible, one would indeed expect that from the description . That class wouldn't need this extension then, but I think it's not trivial

Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux,gcc - Build # 445 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/445/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 12 Mar 2017 14:29:20 + Build duration: 5 min 2 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux,gcc - Build # 445 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/445/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 12 Mar 2017 14:29:20 + Build duration: 5 min 2 sec CHANGE SET No changes JUNIT RESULTS Name:

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

dfaure added a comment. Ship it ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5013 To: yuenlim, #plasma, dfaure Cc: dfaure, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

yuenlim updated this revision to Diff 12411. yuenlim added a comment. Got it! REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5013?vs=12403=12411 REVISION DETAIL https://phabricator.kde.org/D5013 AFFECTED FILES src/core/job.cpp To: yuenlim, #plasma,

Re: Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux, gcc - Build # 444 - Failure!

On dimanche 12 mars 2017 11:45:40 CET no-re...@kde.org wrote: > GENERAL INFO > > BUILD FAILURE > Build URL: > https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,c > ompiler=gcc/444/ Project: PLATFORM=Linux,compiler=gcc Yet another rsync failure error. The kf5 CI is very

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On dimanche 12 mars 2017 09:03:51 CET René J.V. Bertin wrote: > Hello, > > The other day I had to add a context menu to a widget (QPushbutton) defined > in a .ui file and went a bit further when I realised it could be nice to be > able to open such a menu without using a right-click or menu

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

dfaure added a comment. Yes; looks much nicer, doesn't it? INLINE COMMENTS > job_p.h:76 > Job *q_ptr; > +static const int DescriptionUrlMaxLength = 100; > This can now be moved to the helper function. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5013

Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux,gcc - Build # 444 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/444/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 12 Mar 2017 10:41:36 + Build duration: 9.8 sec CHANGE SET No changes

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 467 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/467/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 12 Mar 2017 10:21:45 + Build duration: 19 min CHANGE SET Revision 8ea3b3403dbafefdb6b8b683797bc9312ed39afa

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 467 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/467/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 12 Mar 2017 10:21:45 + Build duration: 19 min CHANGE SET Revision 8ea3b3403dbafefdb6b8b683797bc9312ed39afa

D5023: Restore Cancel button shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8ea3b3403dba: Restore Cancel button shortcut (authored by skalinichev). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5023?vs=12402=12407 REVISION DETAIL

D5023: Restore Cancel button shortcut

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5023 To: skalinichev, elvisangelaccio Cc: #frameworks

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 462 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/462/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 12 Mar 2017 08:54:13 + Build duration: 14 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 462 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/462/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 12 Mar 2017 08:54:13 + Build duration: 14 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

KGuiAddons and QGestures like tap/click-and-hold to open context menu?

Hello, The other day I had to add a context menu to a widget (QPushbutton) defined in a .ui file and went a bit further when I realised it could be nice to be able to open such a menu without using a right-click or menu button. After all, not all platforms have a (physical) right mouse button