Version Error while building KDE frameworks and Qt5

2018-06-08 Thread Bhavesh Patidar
Hello Everyone. For building Elisa from kdesrc-build, I am building the dependencies from here: https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source/Install_the_dependencies But this is installing version 5.9.5 for Qt and version 5.44 for all kde frameworks. Elisa requires versions

D13238: [tests] Add pointer constraints test

2018-06-08 Thread Roman Gilg
romangg abandoned this revision. romangg added a comment. I decided to add the test to KWin instead with: D13439 Thanks to Vlad for review comments. I incorporated them in the new patch for KWin. REPOSITORY R127 KWayland REVISION DETAIL

Re: Closing old Plasma 4 bugs

2018-06-08 Thread Ben Cooksley
On Sat, Jun 9, 2018 at 9:06 AM, Scott Harvey wrote: > Did anyone check how much space has been freed up in the Bugzilla database? The closure of bugs doesn't archive them from the database. Once entered into the system they're in there permanently. Cheers, Ben > On Jun 8, 2018, 3:39 PM -0500,

Re: Closing old Plasma 4 bugs

2018-06-08 Thread Nate Graham
This work is done; all the bugs and feature requests in the plasma4 product have been closed. Hope all of your inboxes survived the onslaught! Nate On 02/21/2018 07:21 AM, Nate Graham wrote: I have also cleaned up the bug triaging page:

D12820: Add KWayland virtual desktop protocol

2018-06-08 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > plasma-virtual-desktop.xml:56 > + > + > + Code comment: This interface doesn't have a destructor. The server can invalidate it on it's end, but ultimately up to the client to destroy the reference which they can't do. REPOSITORY

D12820: Add KWayland virtual desktop protocol

2018-06-08 Thread David Edmundson
davidedmundson added a comment. Don't feel the need to change the code unless you and whoever else agree. I'm not forcing anything, just commenting on my preference. But yeah, that would be my proposal. It'd mean reverting work here, but porting the existing plasma pager/effects

D12820: Add KWayland virtual desktop protocol

2018-06-08 Thread Marco Martin
mart added a comment. In D12820#275739 , @davidedmundson wrote: > In the current (even on X state) I can represent 4 virtual desktops in 1 2x2 grid on the pager so it fits best, yet 4x1 along the edges of the cube, and it wouldn't be

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

2018-06-08 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In D13406#275765 , @cgiboudeaux wrote: > In D13406#275755 , @habacker wrote: > > > Fixed autotests > > > Still -1, the code is now more complicated just for a

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

2018-06-08 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In D13406#275755 , @habacker wrote: > Fixed autotests Still -1, the code is not more complicated just for a cosmetic change in a build system file. Are you trying to fix anything ? REPOSITORY R249 KI18n

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

2018-06-08 Thread Ralf Habacker
habacker updated this revision to Diff 35821. habacker added a comment. Fixed autotests REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13406?vs=35756=35821 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13406 AFFECTED FILES

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

2018-06-08 Thread Ralf Habacker
habacker added a comment. In D13406#275375 , @cgiboudeaux wrote: > -1, this change would break the autotests. Hmmh, https://cmake.org/cmake/help/v3.0/variable/CMAKE_CURRENT_LIST_DIR.html mentions "... that As CMake processes the

D12820: Add KWayland virtual desktop protocol

2018-06-08 Thread David Edmundson
davidedmundson added a comment. General rule of thumb for any data storage for me is to never have a possible corruptable state. The current protocol which has the position specified inside the Virtual Desktop object itself, so you can have two in the same place and you can't swap the