D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R216 Syntax Highlighting BRANCH add-syntax-srt REVISION DETAIL https://phabricator.kde.org/D24211 To: nibags, #framework_syntax_highlighting, dhaumann,

D24210: KadeModeMenuList: fix memory leaks and others

nibags added a comment. `m_searchName` is a pointer to an attribute of a KateFileType object (which may be the string `translatedName` or `name`), but in some cases a new string is created. I added the boolean `m_bHasNewSearchName` that is true when a new QString is created for search.

D24210: KadeModeMenuList: fix memory leaks and others

nibags updated this revision to Diff 66864. nibags added a comment. - Update - Add boolean `m_bHasNewSearchName` to verify removal of `m_searchName`. - Correct format in some comments. - Remove `friend KateModeMenuList` and replace it with the "Factory" class. REPOSITORY R39

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

nibags updated this revision to Diff 66863. nibags added a comment. - Undo changes in Mustache REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24211?vs=66799=66863 BRANCH add-syntax-srt REVISION DETAIL https://phabricator.kde.org/D24211

D23787: [baloo_file_extractor] Improve handling of large plain-text files

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Can you please provide an example which: - is currently indexed though it should be skipped due to size - is skipped after this change and another example which: -

D23787: [baloo_file_extractor] Improve handling of large plain-text files

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH improve-large-text-files (branched from master) REVISION DETAIL https://phabricator.kde.org/D23787 To: poboiko, #baloo, bruns, ngraham Cc: broulik, kde-frameworks-devel, #baloo,

D24185: Add format-text-underline-squiggle actions icons

ngraham added a comment. Not the butt ends are gone again. :) REPOSITORY R266 Breeze Icons BRANCH arcpatch-D24185 REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg, ngraham Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

Re: Review Request 129083: [KIconLoader] Take into account devicePixelRatio for overlays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129083/ --- (Updated Sept. 25, 2019, 8:29 p.m.) Status -- This change has been

Re: lzip vs. xz

On 09/25/19 20:12, Tobias Leupold wrote: Hi devs! We provide all source tarballs xz-compressed. Now, apparently, xz is quite a badly designed format (cf. http://lzip.nongnu.org/xz_inadequate.html ), and lzip provides the same compression, but an apparently distinctly more reasonable format. I

lzip vs. xz

Hi devs! We provide all source tarballs xz-compressed. Now, apparently, xz is quite a badly designed format (cf. http://lzip.nongnu.org/xz_inadequate.html ), and lzip provides the same compression, but an apparently distinctly more reasonable format. I must admit that I personally neither heard

D24227: Add colorful preferences-desktop-filter icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:63b9438be1e4: Add colorful preferences-desktop-filter icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24227?vs=66839=66846 REVISION

D24227: Add colorful preferences-desktop-filter icon

GB_2 updated this revision to Diff 66839. GB_2 added a comment. Make bottom hard show slightly stronger REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24227?vs=66838=66839 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24227

Re: Proposing Quick Charts as a new framework

Am Mittwoch, 18. September 2019, 11:50:58 CEST schrieb Arjen Hiemstra: > On 09-09-2019 10:24, Dominik Haumann wrote: > > Hi, > > > > On Sat, Sep 7, 2019 at 3:59 PM Arjen Hiemstra > > > > wrote: > >> On 06-09-2019 02:49, Aleix Pol wrote: > >>> On Thu, Sep 5, 2019 at 10:53 PM Arjen Hiemstra > >>

D24227: Add colorful preferences-desktop-filter icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24227 To: GB_2, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n,

D24227: Add colorful preferences-desktop-filter icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 406900 F7431167: preferences-desktop-filter Icon.png

D24226: bitbake: handle embedded shell and python

This revision was automatically updated to reflect the committed changes. Closed by commit R216:53187de4a78a: bitbake: handle embedded shell and python (authored by mnauwelaerts). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24226?vs=66835=66837

D24226: bitbake: handle embedded shell and python

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable + has test => accept ;=) REPOSITORY R216 Syntax Highlighting BRANCH syntax-bitbake (branched from master) REVISION DETAIL https://phabricator.kde.org/D24226

D24226: bitbake: handle embedded shell and python

mnauwelaerts created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. mnauwelaerts requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH syntax-bitbake (branched from master) REVISION DETAIL

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

dhaumann added a comment. I'd indeed prefer another/separate diff. :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24211 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson,

Re: Proposing Quick Charts as a new framework

One area of overlap not mentioned yet is KDeclarative::Plotter KDeclarative::Plotter is something we found we had to create in Plasma as the existing solutions didn't cover simple use cases or high refresh rate well at all. This framework absolutely overlaps with that, which is a good thing as

D23879: Add Qt Designer icon symlink

GB_2 planned changes to this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23879 To: GB_2, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23857: Honor global animation speed factor

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d5a5d07f0f89: Honor global animation speed factor (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23857?vs=65804=66828

D24185: Add format-text-underline-squiggle actions icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D24185 REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg, ngraham Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24185: Add format-text-underline-squiggle actions icons

trickyricky26 updated this revision to Diff 66827. trickyricky26 added a comment. This revision is now accepted and ready to land. - Use sine wave as suggested by ndavis REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24185?vs=66778=66827 BRANCH

D23857: Honor global animation speed factor

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23857 To: broulik, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23927: Improve naming of KTitleWidget icon methods

kossebau added a comment. In D23927#537585 , @vkrause wrote: > Moving even more towards a QIcon rather than a QPixmap API is a good thing for sure, I agree on that. I don't think going back is justified here though, especially since the

D23927: Improve naming of KTitleWidget icon methods

vkrause added a comment. In D23927#537583 , @kossebau wrote: > When going to adapt some code to follow the deprecation, I now look though at some inconsistency in the API: > > - KTitleWidget has a property "pixmap" > - the `setPixmap`

D23927: Improve naming of KTitleWidget icon methods

kossebau added a comment. When going to adapt some code to follow the deprecation, I now look though at some inconsistency in the API: - KTitleWidget has a property "pixmap" - the `setPixmap` methods all set this pixmap, with overloads for convenience - `setIcon` is without a getter

D23951: Improve desktop layout and panel editing UX

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2,

D24220: [src/ioslaves/*] replace deprecated foreach with range for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN The code compiles and passes all unit tests REPOSITORY R241 KIO BRANCH ahmad/foreach-ioslaves2 (branched from

D24217: [src/ioslaves/*] replace deprecated foreach with range for

ahmadsamir abandoned this revision. ahmadsamir added a comment. git branch mess up on my end, will submit again after cleaning. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24217 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24217: [src/ioslaves/*] replace deprecated foreach with range for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN The code compiles and passes all unit tests REPOSITORY R241 KIO BRANCH ahmad/foreach-ioslaves (branched from

D24185: Add format-text-underline-squiggle actions icons

trickyricky26 planned changes to this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg, ngraham Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24185: Add format-text-underline-squiggle actions icons

trickyricky26 added a comment. In D24185#537365 , @ndavis wrote: > I have some improvements to the squiggle, but unfortunately, I have no internet in my house except on my phone until the 27th. > > basically, I > > - made a rectangle >

D23787: [baloo_file_extractor] Improve handling of large plain-text files

poboiko marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D23787 To: poboiko, #baloo, bruns, ngraham Cc: broulik, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D23787: [baloo_file_extractor] Improve handling of large plain-text files

poboiko updated this revision to Diff 66805. poboiko added a comment. Address raised issue: fetch file size only once REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23787?vs=65646=66805 BRANCH improve-large-text-files (branched from master) REVISION

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

nibags added a comment. Sorry, that could go in another diff. In the definition of Mustashe, I realized that using WordDetect requires a delimiter before `` doesn't match the WordDetect rule, so I changed it to RegExpr. In HTML, I only put the Tags in a different context to make it

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

dhaumann added inline comments. INLINE COMMENTS > subrip-subtitles.xml:22 > + version="1" > + kateversion="5.53" > + section="Other" What feature do you use to require 5.53 instead of 5.0? REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

dhaumann added a comment. There are also changes in other xml files. Are these intentional? E.g. the changes from WordDetect to RegExpr seem suspicious. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24211 To: nibags, #framework_syntax_highlighting,

D24210: KadeModeMenuList: fix memory leaks and others

cullmann added a comment. I must confess the m_searchName deletion condition seems for me too be overly complex. Given QString copying is cheap, can't we just always set that and store it inline as value? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D24210

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Add highlighting for the

D24210: KadeModeMenuList: fix memory leaks and others

nibags created this revision. nibags added reviewers: KTextEditor, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY - Remove strings `m_searchName` in the

D24179: Fix skipOffset with dynamic RegExpr

cullmann accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH d399388 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24179 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson,