D12077: Show view mode buttons in the open/save dialog's toolbar

2018-05-03 Thread Andres Betts
abetts added a comment. It would be cool if we could introduce it in this release and polish a lot for the next release. I give it a +1. @ngraham ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: elvisangelaccio,

D12392: Fix the "Default" color scheme to match Breeze again

2018-05-02 Thread Andres Betts
abetts added a comment. Just trying to understand. What is happening here is that we have 3 color schemes that are all theoretically the same as Breeze. However, the "default" and "Breeze" scheme are currently not the same. Therefore, we have to make sure that they are. If that's the case

D12508: Make KMessageWidget match Kirigami inlineMessage's style

2018-04-25 Thread Andres Betts
abetts added a comment. +1, looking good. Keep up the work! REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, elvisangelaccio, cfeck Cc: abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, bruns

D10980: updated hanle icon

2018-04-22 Thread Andres Betts
abetts added a comment. Just to provide perspective at what the rest of the industry is using, here is a search online: https://www.flaticon.com/search?word=drag REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10980 To: andreask, mart Cc: abetts, rkflx,

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-04-20 Thread Andres Betts
abetts added a comment. In D12311#250637 , @bruns wrote: > If you really want to save some space (and probably make it easier for users to understand the dialog without getting lost), I think the whole > > > An application is attempting to

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

2018-04-20 Thread Andres Betts
abetts added a comment. +1 In D12333#250266 , @rkflx wrote: > In D12333#250194 , @abetts wrote: > > > I gave a +1 to the original idea because I feel that there isn't really much closeness that

D11768: Add Desktop and Downloads to the default list of Places

2018-04-19 Thread Andres Betts
abetts added a comment. I would say remove search for images audio files and video and move them to the places location REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: abetts, huoni, markg,

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

2018-04-19 Thread Andres Betts
abetts added a comment. I gave a +1 to the original idea because I feel that there isn't really much closeness that you can achieve with the open dialog. It is simple, straightforward. If we wanted to do a strict fitt's law follow, then each back and forth icon would be next to each of the

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

2018-04-19 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12333 To: ngraham, #frameworks, #dolphin, #vdg Cc: abetts, jtamate, broulik, anemeth, rkflx, michaelh, bruns

D12218: Remove Reload button from the file dialogs' toolbar

2018-04-19 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc: abetts, markg, broulik, rkflx, #dolphin, michaelh, bruns

D12327: [WIP/open dependencies] Show Detailed Tree View by default

2018-04-19 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham Cc: abetts, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

2018-04-19 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

2018-04-18 Thread Andres Betts
abetts added a comment. In D12077#249447 , @ngraham wrote: > In D12077#249446 , @abetts wrote: > > > Somewhat related, why does the Size header have a number of items listed and not the size in

D12077: Show view mode buttons in the open/save dialog's toolbar

2018-04-18 Thread Andres Betts
abetts added a comment. Somewhat related, why does the Size header have a number of items listed and not the size in bytes for all the items inside the folder? size 0 items 2 items Shouldn't it be: size 1 kb 3 Mb ?? REPOSITORY R241 KIO REVISION DETAIL

D12328: Enable preview by default in the filepicker dialog

2018-04-18 Thread Andres Betts
abetts added a comment. What would it look like if it was enabled by default? Screenshot? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

2018-04-18 Thread Andres Betts
abetts added a comment. I also vote for a little more vertical spacing. Maybe in similar ways to what Marco Martin did recently for spacing in System Settings. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg Cc: abetts, rkflx,

D12077: Show view mode buttons in the open/save dialog's toolbar

2018-04-13 Thread Andres Betts
abetts accepted this revision. REPOSITORY R241 KIO BRANCH show-view-mode-toggles-on-open-save-dialog-toolbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: rkflx, mmustac, broulik, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

2018-04-13 Thread Andres Betts
abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH tighter-grid-in-icons-view (branched from master) REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx, abetts Cc: abetts, cfeck, alexeymin,

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

2018-04-13 Thread Andres Betts
abetts added a comment. Can we also create another patch that can add more vertical spacing between the items and the top edge of the field? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: abetts, cfeck, alexeymin,

D12130: Use the more user-friendly string "File type" in the save dialogs

2018-04-13 Thread Andres Betts
abetts accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx, abetts Cc: davidc, ltoscano, cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12034: Use the more appropriate "two sliders" icon for "configure"

2018-04-13 Thread Andres Betts
abetts accepted this revision as: VDG, abetts. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH more-consistent-configure-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze, abetts Cc:

D12130: Use the more user-friendly string "File format" in the open/save dialogs

2018-04-11 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R241 KIO BRANCH file-format-label (branched from master) REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns Cc: abetts, bruns, michaelh, ngraham

D12034: Use the more appropriate "two sliders" icon for "configure"

2018-04-09 Thread Andres Betts
abetts added a comment. In D12034#243522 , @ngraham wrote: > 1. System Settings uses sliders right there in its icon. :) They're already used to mean "Configure me!" in other contexts (KRunner, Plasma widgets, GTK apps) > 2. Sliders aren't

D12034: Use the more appropriate "two sliders" icon for "configure"

2018-04-09 Thread Andres Betts
abetts added a comment. I am in fact, a little bit taken back by the fact that we have a two slider icon. The reason is because I have been told many times that we don't want to use sliders or toggles in the desktop. We are referencing something that doesn't exist in the Plasma desktop. I

D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-04 Thread Andres Betts
abetts added a comment. I don't have any objections. Good work! +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, firef, alexeymin, skadinna,

D11569: Improve consistency of "Open With" UI by always showing top app inline

2018-03-30 Thread Andres Betts
abetts accepted this revision. REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts Cc: mmustac, davidedmundson, broulik, dfaure,

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

2018-03-28 Thread Andres Betts
abetts added a comment. Can we just call all of those entries just "Recent" or "Recently Used" independent of when it happened? I feel that would be more clear without having to remove the feature. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham,

D11569: Improve consistency of "Open With" UI by always showing top app inline

2018-03-23 Thread Andres Betts
abetts added a comment. This may be different than this patch is intending to address. Let me know if that's the case. Another thing that adds more characters to the menus are the long names that our applications have. Firefox Web Browser Gwenview Image Editor GIMP Image Editor

D11569: Improve consistency of "Open With" UI

2018-03-22 Thread Andres Betts
abetts added a comment. +1 on this! Easy access to apps! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve usability of "Open With" UI

2018-03-21 Thread Andres Betts
abetts added a comment. Would it look good also that if there were less handlers and they are presented in the same menu that it goes like this: Open With - Gwenview - GIMP I am talking about right justification instead of Open With Gwenview GIMP REPOSITORY R241

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-01 Thread Andres Betts
abetts added a comment. Is there a way that we can add extra clarity by adding a label below the icons? A label that explains what the action is? I agree that the current symbolism can be hard to read but it is also very simple. If you make the connection to label, it will be even stronger

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

2018-02-12 Thread Andres Betts
abetts added a comment. Will this hide "All" menu items or will it hide after a certain amount of them are in the menu? For example, it will turn into a sub menu after 3 items? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10329 To: broulik, #vdg, #frameworks, dfaure

D10211: Suggestion for emacs icon

2018-01-31 Thread Andres Betts
abetts added a comment. I like it! Maybe a way to accentuate that this is an "E" a little more. As a first impression, it didn't strike me as an E for emacs. Overall, the colors are great and the circle shape fits well. REPOSITORY R266 Breeze Icons REVISION DETAIL

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2018-01-26 Thread Andres Betts
abetts added a comment. Is this change purely a conversation of what developers use in code to call up fonts in their applications? Or does this also include a discussion where regular users have interfaces that allow changes to font naming? Let's say, something like System Settings that

D9324: [Air theme] Add task bar progress graphic

2017-12-14 Thread Andres Betts
abetts added a comment. What should be the move here? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9324 To: broulik, #plasma, #vdg, ngraham Cc: abetts, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread Andres Betts
abetts added a comment. My perspective here is that instead of using an actual checkbox to enable the dragging, I would create visual handles instead. Maybe something like this: F5489078: Group.png Why? Because checkboxes generally don't

D8348: Add a section for removable devices

2017-11-05 Thread Andres Betts
abetts added a comment. What about something like this as well F548: Unmount.png The removable device gets an "unmount" or "disconnect" icon on hover? Thoughts? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-04 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D8056#164287, @ngraham wrote: > I would say make the categories disappear as soon as that view displays search results. Yeah, because in the end, when you want to narrow down the results, the categories will get in your way

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-04 Thread Andres Betts
abetts added a comment. Can I suggest to maybe simplify even a little more and remove the category separators? AKA, system, internet? REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg,

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Andres Betts
abetts added a comment. We don't seem to have anything against it. My only request is that if we do shortcuts, make them use 2 hands instead of just one. If the keys are too close together, this makes it harder to enter. Possibly harder for people with disabilities as well. So, space the

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Andres Betts
abetts added a comment. If you assume that most computers that run linux will have a windows key, I would call it just windows. Everyone else uses exceptions really. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Andres Betts
abetts added a comment. What about Windows/Meta + Something, let's say , comma? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik,

D8296: Use Alt+, as the standard shortcut for "Configure "

2017-10-25 Thread Andres Betts
abetts added a comment. Could this also be added to global shortcuts if it is not there already? That the user can define the keys to use for Preferences? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc:

D7828: createKMessageBox tries to focus a default button when available

2017-10-24 Thread Andres Betts
abetts added a comment. I am leaning toward implementing the change. The reason being that the user gets a duplicate indication of focus when likely they might feel confused, I have been at times too, by not knowing clearly where the highlight is. If you have two highlights, how do you know

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-23 Thread Andres Betts
abetts added a comment. Can you guys add a quick picture of what this looks like right now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: abetts, ngraham, alexeymin, #frameworks

<    1   2