Re: Review Request 127728: Headers generated BalooDBusInterfaces custom target are used in KF5Baloo target sources (IndexerConfig::refresh()), so build this target unconditionally.

2017-02-04 Thread Andrius da Costa Ribas
problem on MSVC 2015 (missing generated "maininterface.h" for "lib/indexerconfig.cpp"). No further testing done. Thanks, Andrius da Costa Ribas

Re: Review Request 127728: Headers generated BalooDBusInterfaces custom target are used in KF5Baloo target sources (IndexerConfig::refresh()), so build this target unconditionally.

2016-05-12 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127728/#review95441 --- ping? - Andrius da Costa Ribas On Abril 23, 2016, 4:44

Re: Review Request 127727: There is no QT_LSTAT on Windows, use QT_STAT and follow symlink (if needed), only on Windows, instead.

2016-04-24 Thread Andrius da Costa Ribas
marked as submitted. Review request for Baloo and kdewin. Changes --- Submitted with commit 0475e40d65036cb46f84740f4195d239030f13f1 by Andrius da Costa Ribas to branch master. Repository: baloo Description --- This fixes compilation on Windows, where QT_LSTAT is not available

Re: Review Request 127726: Fix EXPORT usage.

2016-04-24 Thread Andrius da Costa Ribas
marked as submitted. Review request for Baloo and kdewin. Changes --- Submitted with commit 07e3fe88f35eae9c5fdbbc408b9d222a060f9641 by Andrius da Costa Ribas to branch master. Repository: baloo Description --- The export macro should not be used in the namespace declaration

Review Request 127728: Headers generated BalooDBusInterfaces custom target are used in KF5Baloo target sources (IndexerConfig::refresh()), so build this target unconditionally.

2016-04-23 Thread Andrius da Costa Ribas
dexerconfig.cpp"). No further testing done. Thanks, Andrius da Costa Ribas

Review Request 127727: There is no QT_LSTAT on Windows, use QT_STAT and follow symlink (if needed), only on Windows, instead.

2016-04-23 Thread Andrius da Costa Ribas
--- This fixes compilation on Windows, where QT_LSTAT is not available. Diffs - src/engine/idutils.h 7c4f898 Diff: https://git.reviewboard.kde.org/r/127727/diff/ Testing --- Fixes compiling error on MSVC 2015. No further testing done. Thanks, Andrius da Costa Ribas

Review Request 127726: Fix EXPORT usage.

2016-04-23 Thread Andrius da Costa Ribas
--- The export macro should not be used in the namespace declaration. Diffs - src/engine/global.h aba5495 Diff: https://git.reviewboard.kde.org/r/127726/diff/ Testing --- Fixes compiling error on MSVC 2015. No further testing done. Thanks, Andrius da Costa Ribas