[frameworks/extra-cmake-modules] modules: Revert "ECMEnableSanitizers: do not enable linker flags when not supported"

2022-01-25 Thread Bhushan Shah
Git commit fffae63daa48648784919aec4b576034e44a2da0 by Bhushan Shah. Committed on 26/01/2022 at 07:46. Pushed by cgiboudeaux into branch 'master'. Revert "ECMEnableSanitizers: do not enable linker flags when not supported" This reverts commit abc3a698abc0dfea19040007a7c57d

Re: New repo in kdereview: plasma-settings

2021-02-14 Thread Bhushan Shah
Forwarding message, since had wrong reply to address in previous message - Forwarded message from Bhushan Shah - Date: Mon, 15 Feb 2021 11:44:14 +0530 From: Bhushan Shah To: Harald Sitter Subject: Re: New repo in kdereview: plasma-settings On Mon, Jan 25, 2021 at 03:29:18PM +0100

Re: New repo in kdereview: plasma-angelfish

2021-02-14 Thread Bhushan Shah
On Mon, Jan 25, 2021 at 02:56:39PM +0100, Harald Sitter wrote: > On 25.01.21 06:55, Bhushan Shah wrote: > > Hello everyone! > > > > Yet another Plasma Mobile repository in kdereview: > > > > https://invent.kde.org/plasma-mobile/plasma-angelfish > >

Re: New repo in kdereview: plasma-phonebook

2021-02-14 Thread Bhushan Shah
Hello, On Mon, Jan 25, 2021 at 02:18:51PM +0100, Harald Sitter wrote: > On 25.01.21 06:48, Bhushan Shah wrote: > > Hello everyone! > > > > I am back with more Plasma Mobile related repositories in kdereview. I > > want to move plasma-phonebook in kdereview. plasma-phon

New repo in kdereview: plasma-settings

2021-01-24 Thread Bhushan Shah
desktop is, this code is much more lean and modern, it is my understanding that long term idea is to replace the original systemsettings code base with plasma-settings. But for now this is mobile specific. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint

New repo in kdereview: plasma-angelfish

2021-01-24 Thread Bhushan Shah
is available in README.md of the repository. Before moving it to extragear I would like to drop plasma- prefix from the repository as this repo have nothing much to do with "Plasma". And it is otherwise already called just "Angelfish" in its desktop files and stuff. Cheers. -

New repo in kdereview: plasma-phonebook

2021-01-24 Thread Bhushan Shah
contacts on your system. Another thing I want to discuss is, branding, currently it is named as Plasma Phonebook which is bit awkward because Plasma is not related to app at all and even android port for app exists. Maybe we should name this just phonebook? Thanks -- Bhushan Shah http

Re: plasma-mobile/spacebar in kdereview

2021-01-19 Thread Bhushan Shah
Hello, I have fixed the i18n issue with the spacebar, and crash fix was committed by the JBB, Since it has been in kdereview for month now, I will proceed to move this to extragear and prepare 0.1 release of it. Thanks! On Thu, Dec 17, 2020 at 06:02:20PM +0530, Bhushan Shah wrote: > He

plasma-mobile/spacebar in kdereview

2020-12-19 Thread Bhushan Shah
them in database, spacebar client is what users interact with to check the incoming messages and send outgoing messages. Similar to plasma-dialer, to test this you need ofono phonesim and telepathy-ring or telepathy-ofono. Cheers! -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah

plasma-mobile/plasma-dialer in kdereview

2020-12-19 Thread Bhushan Shah
is dialer application for Plasma Mobile. It is basically telepathy client with two parts, approver and dialer client. To test this on local system if you want you need ofono-phonesim and telepathy-ofono or telepathy-ring. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freeno

Merge tags in master branch?

2020-11-23 Thread Bhushan Shah
e have any opinion on "merging" latest git tag in master branch? and potentially doing that for next releases as well? Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Git merge workflow: reverse it?

2020-08-02 Thread Bhushan Shah
and if it works fine in general testing then, cherry-pick it in stable branches. Proposal is to probably adapt this policy kde-wise if people feel that advantages are worth it. Thanks [1] https://mail.kde.org/pipermail/plasma-devel/2020-June/117887.html -- Bhushan Shah http://blog.bshah.in IRC Nick

Re: Gitlab Turn-off Issues

2020-06-30 Thread Bhushan Shah
> feature, they can also decide to restrict it to enterprise customers. May I please suggest to make public statements which have the facts backing to it? Because that statement is not correct and have zero backing to it. -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key finger

Re: Gitlab, Git History and Merge Options

2020-05-19 Thread Bhushan Shah
gration, so if you're still seeing new instances of the such merge commits, please let us know. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Namespaces for a few repositories on invent (was Re: Migration to Gitlab -- Update)

2020-05-10 Thread Bhushan Shah
sure where this content is hosted if at all (seems to have .php files in there) > Also unmaintained/ contains two of them (necessitas, strigi), but it doesn't > matter much I guess. I've flattened necessitas and strigi. > Ciao! > -- > Luigi -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Migration to Gitlab -- Update

2020-05-10 Thread Bhushan Shah
> the metadata repopath has not been updated yet: > https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent/utilities/keysmith/metadata.yaml?h=bshah/invent Yes, that is correct, currently directory structure is what will be final structure, repopath and other bits will migrated

Re: Namespaces for a few repositories on invent (was Re: Migration to Gitlab -- Update)

2020-05-10 Thread Bhushan Shah
sure where this content is hosted if at all (seems to have .php files in there) > Also unmaintained/ contains two of them (necessitas, strigi), but it doesn't > matter much I guess. I've flattened necessitas and strigi. > Ciao! > -- > Luigi -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Migration to Gitlab -- Update

2020-05-10 Thread Bhushan Shah
> the metadata repopath has not been updated yet: > https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent/utilities/keysmith/metadata.yaml?h=bshah/invent Yes, that is correct, currently directory structure is what will be final structure, repopath and other bits will migrated

Information regarding upcoming Gitlab Migration: clarifications

2020-04-30 Thread Bhushan Shah
t?h=bshah/invent -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

[sysadmin/repo-metadata] projects: projects: move new wayland repos to their final place

2020-04-29 Thread Bhushan Shah
Git commit 53d913c3af459024d359c13def87db8913d8ed6b by Bhushan Shah. Committed on 29/04/2020 at 11:09. Pushed by bshah into branch 'master'. projects: move new wayland repos to their final place - plasma-wayland-protocols -> frameworks - kwayland-server -> kde/workspace Ref: T13052 CCMAI

Information regarding upcoming Gitlab Migration: clarifications

2020-04-29 Thread Bhushan Shah
t?h=bshah/invent -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Information regarding upcoming Gitlab Migration: clarifications

2020-04-29 Thread Bhushan Shah
t?h=bshah/invent -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Information regarding upcoming Gitlab Migration

2020-04-29 Thread Bhushan Shah
ptimal. I've also mentioned various new contributor focused requirements which lead us to this proposal for structuring in previous emails. -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Information regarding upcoming Gitlab Migration

2020-04-28 Thread Bhushan Shah
(That said, bigflatlistofrepositories.kde.org .. or maybe call it > cgit.kde.org > .. could be a particular view onto gitlab which does flattening and search, > but only if there's people around to create it and maintain it) Just to clarify, sysadmins have no plan to support or maintain the

Re: Information regarding upcoming Gitlab Migration

2020-04-28 Thread Bhushan Shah
(That said, bigflatlistofrepositories.kde.org .. or maybe call it > cgit.kde.org > .. could be a particular view onto gitlab which does flattening and search, > but only if there's people around to create it and maintain it) Just to clarify, sysadmins have no plan to support or maintain the

Re: Information regarding upcoming Gitlab Migration

2020-04-28 Thread Bhushan Shah
(That said, bigflatlistofrepositories.kde.org .. or maybe call it > cgit.kde.org > .. could be a particular view onto gitlab which does flattening and search, > but only if there's people around to create it and maintain it) Just to clarify, sysadmins have no plan to support or maintain the

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
(chiliproject installation). [1] https://blog.bshah.in/2013/09/01/hello-planet/ -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
orks", and so on). As explained above, while grouping repositories is trying to solve the merge requests/issue organization, it is not sole purpose of the suggested grouping, discoverability and reachability is the main issue we are trying to solve here. [1] https://i.imgur.com/h1L1A5H.png [2] ht

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
ut they are instead offered the empty page. One have to click on Shared repositories tab to actually see the list. https://invent.kde.org/groups/sysadmin/test/test2/-/shared This defeats the purpose of the creating subgroups (offering easy reachability). -- Bhushan Shah http://blog.bshah.in IRC Nick : b

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
(chiliproject installation). [1] https://blog.bshah.in/2013/09/01/hello-planet/ -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
(chiliproject installation). [1] https://blog.bshah.in/2013/09/01/hello-planet/ -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
ut they are instead offered the empty page. One have to click on Shared repositories tab to actually see the list. https://invent.kde.org/groups/sysadmin/test/test2/-/shared This defeats the purpose of the creating subgroups (offering easy reachability). -- Bhushan Shah http://blog.bshah.in IRC Nick : b

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
ut they are instead offered the empty page. One have to click on Shared repositories tab to actually see the list. https://invent.kde.org/groups/sysadmin/test/test2/-/shared This defeats the purpose of the creating subgroups (offering easy reachability). -- Bhushan Shah http://blog.bshah.in IRC Nick : b

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
orks", and so on). As explained above, while grouping repositories is trying to solve the merge requests/issue organization, it is not sole purpose of the suggested grouping, discoverability and reachability is the main issue we are trying to solve here. [1] https://i.imgur.com/h1L1A5H.png [2] ht

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
orks", and so on). As explained above, while grouping repositories is trying to solve the merge requests/issue organization, it is not sole purpose of the suggested grouping, discoverability and reachability is the main issue we are trying to solve here. [1] https://i.imgur.com/h1L1A5H.png [2] ht

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
tching a repository. [*] Ironically, in your case search would be helpful as you know you are looking for knetwalk so you can just add it and search it -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
tching a repository. [*] Ironically, in your case search would be helpful as you know you are looking for knetwalk so you can just add it and search it -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
tching a repository. [*] Ironically, in your case search would be helpful as you know you are looking for knetwalk so you can just add it and search it -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Information regarding upcoming Gitlab Migration

2020-04-26 Thread Bhushan Shah
next week and move projects to https://invent.kde.org. Thanks! Bhushan for sysadmin team [1] https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07

Information regarding upcoming Gitlab Migration

2020-04-26 Thread Bhushan Shah
next week and move projects to https://invent.kde.org. Thanks! Bhushan for sysadmin team [1] https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07

Information regarding upcoming Gitlab Migration

2020-04-26 Thread Bhushan Shah
next week and move projects to https://invent.kde.org. Thanks! Bhushan for sysadmin team [1] https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07

Moving several repositories in kdesupport to unmaintained

2020-04-25 Thread Bhushan Shah
Any objections to moving following out of kdesupport to unmaintained? - automoc - emerge - emerge-history - libqzeitgeist - soprano - strigi All of this is kde4 based our outdated Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643

Move kimagemapeditor to kdegraphics

2020-04-25 Thread Bhushan Shah
to this? -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Move some out-of-date bindings to unmaintained

2020-04-24 Thread Bhushan Shah
? Anyway, any objections to me moving following to unmaintained? Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Bhushan Shah
bshah added a comment. Hmm yeah I am also not a fan of the stretched out dialpad icon REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Bhushan Shah
bshah added a subscriber: jbbgameich. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28114 To: ndavis, #vdg Cc: jbbgameich, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27708: Cleanup accounts kded module

2020-03-09 Thread Bhushan Shah
bshah accepted this revision. REPOSITORY R155 KAccounts Integration BRANCH arcpatch-D27708 REVISION DETAIL https://phabricator.kde.org/D27708 To: nicolasfella, #frameworks, bshah, leinir

D27637: kill twitter support

2020-02-24 Thread Bhushan Shah
bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH killtwitter REVISION DETAIL https://phabricator.kde.org/D27637 To: nicolasfella, #frameworks, apol, bshah Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27622: only find bash once

2020-02-24 Thread Bhushan Shah
bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27622 To: sitter, bshah Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27614: build: fix the build where install prefix is not user-writable

2020-02-24 Thread Bhushan Shah
This revision was automatically updated to reflect the committed changes. Closed by commit R266:462c5dfe2e9a: build: fix the build where install prefix is not user-writable (authored by bshah). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D27614: build: fix the build where install prefix is not user-writable

2020-02-24 Thread Bhushan Shah
bshah updated this revision to Diff 76278. bshah added a comment. rebase REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27614?vs=76256=76278 BRANCH bshah/fix-build REVISION DETAIL https://phabricator.kde.org/D27614 AFFECTED FILES

D27614: build: fix the build where install prefix is not user-writable

2020-02-23 Thread Bhushan Shah
bshah created this revision. bshah added reviewers: ngraham, lbeltrame. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY - Validate only the files and symlinks - Fix target names, they were swapped

Re: Keysmith in kdereview

2020-01-22 Thread Bhushan Shah
much better! Since there has been no other objections, I will move the keysmith into extragear today. Cheers! -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

D26273: cmake: don't use taglib-config if we are cross compiling

2019-12-29 Thread Bhushan Shah
bshah created this revision. bshah added a reviewer: vkrause. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY If we are cross compiling two things are possible, - cmake finds host

Keysmith in kdereview

2019-12-18 Thread Bhushan Shah
Hello everyone! Keysmith (https://invent.kde.org/kde/keysmith) has been moved to kdereview. Keysmith is a Two-factor code generator for Plasma Mobile and Desktop and is using oath-toolkit for this purpose. User interface is written in the kirigami. Thanks! -- Bhushan Shah http://blog.bshah.in

plasma-nano and plasma-phone-components are now in kdereview

2019-11-07 Thread Bhushan Shah
can extend, while plasma-phone-components is a shell package, look and feel and several other components which makes Plasma Mobile. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc

Taking over maintainership of the kaccounts-* repos

2019-09-13 Thread Bhushan Shah
with this, let me know. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Taking over maintainership of the kaccounts-* repos

2019-09-13 Thread Bhushan Shah
with this, let me know. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

D22968: Make it possible to modify contacts

2019-08-23 Thread Bhushan Shah
bshah requested changes to this revision. bshah added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > abstracteditablecontact.h:31 > + * > + * @since 5.60 > + * @internal Since 5.62 > persondata.h:103 > > +Q_SCRIPTABLE bool setContactCustomProperty(const

KCalendarCore plugins/datasources?

2019-08-11 Thread Bhushan Shah
di storage, and Akonadi have it's own custom code for this. Would it make sense to have something like this in kcalcore itself? Volker mentioned to me that it needs close look at Akonadi based implementation and trying to finalize API. Thanks -- Bhushan Shah http://blog.bshah.in IRC Ni

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

2019-07-31 Thread Bhushan Shah
bshah accepted this revision. bshah added a comment. As a short term workaround, this is fine, in terms of porting to python3 it will also need changes on our server zivo.kde.org which is hosting api.kde.org, right now every scripts including krazy2 and apidox generation scripts are too

D22425: personsmodel: Add phoneNumber

2019-07-12 Thread Bhushan Shah
bshah added a reviewer: apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22425 To: jbbgameich, #plasma:_mobile, #kde_pim, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22049: pluginloader: Change behavior of X-KDE-ParentApp

2019-06-25 Thread Bhushan Shah
This revision was automatically updated to reflect the committed changes. Closed by commit R242:7ae271987ca2: pluginloader: Change behavior of X-KDE-ParentApp (authored by bshah). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D22049: pluginloader: Change behavior of X-KDE-ParentApp

2019-06-23 Thread Bhushan Shah
bshah created this revision. bshah added reviewers: mart, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY X-KDE-ParentApp is the key in desktop file to display that given service or

D21778: Add some documentation for PlatformDependent

2019-06-13 Thread Bhushan Shah
This revision was automatically updated to reflect the committed changes. Closed by commit R235:fbda1d799cc1: Add some documentation for PlatformDependent (authored by bshah). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21778?vs=59711=59712 REVISION DETAIL

D21778: Add some documentation for PlatformDependent

2019-06-13 Thread Bhushan Shah
bshah created this revision. bshah added a reviewer: leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY Also add note about deprecating askForCredentials and saveCredentials in future.

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-01-26 Thread Bhushan Shah
> > Can we try to get this documented? 1.7GB isn't a lot for lots of people with > fast internet (if the server serves fast enough). https://invent.kde.org/sysadmin/ci-tooling/wikis/CI-On-Local-Machine I have added some initial documentation here, which I will improve later. -- Bhu

D17808: Don't force Phonon on Android

2018-12-26 Thread Bhushan Shah
bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D17808 To: vkrause, bshah Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17345: Support Bluetooth batteries

2018-12-04 Thread Bhushan Shah
bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17345 To: broulik, #plasma, bruns, davidedmundson, bshah Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: Downtime announcement: www.kde.org

2018-11-09 Thread Bhushan Shah
logies for any inconvenience caused. > > The maintenance window has now commenced. > The above sites will be inaccessible until the maintenance is completed. > > > > > Regards, > > Ben Cooksley > > KDE Sysadmin > > Regards, > Ben -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Downtime announcement: www.kde.org

2018-11-06 Thread Bhushan Shah
logies for any inconvenience caused. > > The maintenance window has now commenced. > The above sites will be inaccessible until the maintenance is completed. > > > > > Regards, > > Ben Cooksley > > KDE Sysadmin > > Regards, > Ben -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Downtime announcement: www.kde.org

2018-11-05 Thread Bhushan Shah
logies for any inconvenience caused. > > The maintenance window has now commenced. > The above sites will be inaccessible until the maintenance is completed. > > > > > Regards, > > Ben Cooksley > > KDE Sysadmin > > Regards, > Ben -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Downtime announcement: www.kde.org

2018-11-05 Thread Bhushan Shah
- Any application using GHNS > > > > In addition, any other site which is hosted by the server known as > > "olios.kde.org" will also be unavailable during this time. > > > > Apologies for any inconvenience caused. > > The maintenance window has n

Re: Downtime announcement: www.kde.org

2018-11-05 Thread Bhushan Shah
- Any application using GHNS > > > > In addition, any other site which is hosted by the server known as > > "olios.kde.org" will also be unavailable during this time. > > > > Apologies for any inconvenience caused. > > The maintenance window has n

Re: Pre-review CI

2018-07-29 Thread Bhushan Shah
ot; is link to jenkins build. But the test was if you were able to spot it in first glance, and it failed. :P so yeah we will keep comments enabled even if it means extra emails. > Cheers and Thanks again for improving the review system > Friedrich Thanks -- Bhushan Shah http://blog.bshah.in IRC

Pre-review CI

2018-07-29 Thread Bhushan Shah
the comment? See linked review for example [1]. Looking forward to feedback. Thanks! [1] https://mail.kde.org/pipermail/kde-frameworks-devel/2018-June/065616.html [2] https://phabricator.kde.org/D14438 -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Bhushan Shah
bshah removed a project: Frameworks. bshah removed a subscriber: kde-frameworks-devel. Restricted Application added a project: Frameworks. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, michaelh, ngraham, bruns, kde-frameworks-devel

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Bhushan Shah
bshah updated this revision to Diff 38634. bshah added a comment. - Revert "make it fail" - break test REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=38632=38634 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Bhushan Shah
bshah updated this revision to Diff 38632. bshah added a comment. - make it fail REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=38631=38632 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Bhushan Shah
bshah updated this revision to Diff 38631. bshah added a comment. - change REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=38500=38631 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To:

D13819: dummy commit to test pre-review CI

2018-07-26 Thread Bhushan Shah
bshah updated this revision to Diff 38500. bshah added a comment. - change REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=37574=38500 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To:

D13819: dummy commit to test pre-review CI

2018-07-11 Thread Bhushan Shah
bshah updated this revision to Diff 37574. bshah added a comment. - jhdkjfhdskj REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=37004=37574 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To:

D13559: Fix some of cppcheck warnings

2018-07-04 Thread Bhushan Shah
This revision was automatically updated to reflect the committed changes. Closed by commit R127:84bc3cbd6102: Fix some of cppcheck warnings (authored by bshah). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13559?vs=37088=37135 REVISION DETAIL

D13559: Fix some of cppcheck warnings

2018-07-02 Thread Bhushan Shah
bshah added subscribers: aacid, apol. bshah added a comment. Added subscribers back which arc removed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13559 To: bshah, #frameworks Cc: apol, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D13559: Fix some of cppcheck warnings

2018-07-02 Thread Bhushan Shah
bshah updated this revision to Diff 37088. bshah edited the summary of this revision. bshah removed subscribers: aacid, apol. bshah added a comment. update commit message REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13559?vs=37087=37088 BRANCH

D13559: Fix some of cppcheck warnings

2018-07-02 Thread Bhushan Shah
bshah updated this revision to Diff 37087. bshah added a comment. - fix memory leak properly REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13559?vs=36199=37087 BRANCH fix-cppcheck REVISION DETAIL https://phabricator.kde.org/D13559 AFFECTED FILES

D13559: Fix some of cppcheck warnings

2018-07-02 Thread Bhushan Shah
bshah added a comment. In D13559#285804 , @apol wrote: > I don't see any fix here. It's just silencing cppcheck. Only supressing done is the memleak in the autotests, otherwise for selfInitialization it is the false alarm, which can be

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 37004. bshah added a comment. - fix tests REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36992=37004 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To:

D13559: Fix some of cppcheck warnings

2018-07-01 Thread Bhushan Shah
bshah added a comment. bump? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13559 To: bshah, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36992. bshah added a comment. - less fun, but this time try failing unit test REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36991=36992 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36991. bshah added a comment. - find qt5 fun, because that will make build fail REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36989=36991 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36989. bshah added a comment. - final change handover chnage REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36988=36989 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36988. bshah added a comment. - enough derps REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36987=36988 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36987. bshah added a comment. - derp REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36986=36987 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To: bshah

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36986. bshah added a comment. - derp REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36985=36986 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To: bshah

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36985. bshah added a comment. - edit 4, to check change handover works REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36982=36985 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. Harbormaster failed remote builds in B508: Diff 36977! Harbormaster returned this revision to the author for changes because remote builds failed.

PSA: Phabricator staging repositories

2018-06-29 Thread Bhushan Shah
list, feel free to forward it and please make sure to include sysad...@kde.org or me in reply. Thanks [1] https://secure.phabricator.com/book/phabricator/article/harbormaster/ -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7

PSA: Phabricator staging repositories

2018-06-29 Thread Bhushan Shah
list, feel free to forward it and please make sure to include sysad...@kde.org or me in reply. Thanks [1] https://secure.phabricator.com/book/phabricator/article/harbormaster/ -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7

PSA: Phabricator staging repositories

2018-06-29 Thread Bhushan Shah
list, feel free to forward it and please make sure to include sysad...@kde.org or me in reply. Thanks [1] https://secure.phabricator.com/book/phabricator/article/harbormaster/ -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7

  1   2   3   4   >