Re: Review Request 119441: Akonadi-Indexer: Collection indexing

Didn't you already handled empty NS term on l. 103? I think this entire block could be just moves into the if (!folderAttribute->collectionName().isEmpty()) { ... } block src/pim/agent/index.cpp <https://git.reviewboard.kde.org/r/119441/#comment43736> s/akononotes/coll

Re: Review Request 119319: Baloo (frameworks): install *store plugins into kf5/baloo subfolder

eLists.txt 0fe03b5 src/pim/search/note/baloo_notesearchstore.desktop c11e28e Diff: https://git.reviewboard.kde.org/r/119319/diff/ Testing --- Thanks, Dan Vrátil >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119318: Baloo (frameworks): Install kio slaves into correct folder

19318/diff/ Testing --- Thanks, Dan Vrátil >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119319: Baloo (frameworks): install *store plugins into kf5/baloo subfolder

On July 16, 2014, 2:41 p.m., Dan Vrátil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119319/ > --- &

Re: Review Request 119319: Baloo (frameworks): install *store plugins into kf5/baloo subfolder

earch/note/baloo_notesearchstore.desktop c11e28e Diff: https://git.reviewboard.kde.org/r/119319/diff/ Testing --- Thanks, Dan Vrátil >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 119319: Baloo (frameworks): install *store plugins into kf5/baloo subfolder

iff: https://git.reviewboard.kde.org/r/119319/diff/ Testing --- Thanks, Dan Vrátil >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 119318: Baloo (frameworks): Install kio slaves into correct folder

eLists.txt f379834 src/kioslaves/tags/tags.protocol f14af6d src/kioslaves/timeline/CMakeLists.txt 7c9e35c src/kioslaves/timeline/timeline.protocol 81f814e Diff: https://git.reviewboard.kde.org/r/119318/diff/ Testing --- Thanks, Dan Vrátil >> Visit http://mail.kde.org/mail

Re: Review Request 116764: Baloo: Use XDG_DATA_HOME instead of KDE HOME

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116764/#review52875 --- Ship it! - Dan Vrátil On March 12, 2014, 3:25 p.m

Re: Review Request 116708: Support Akonadi instances in Baloo indexer

/pimsearchstore.cpp 7d208db Diff: https://git.reviewboard.kde.org/r/116708/diff/ Testing --- Thanks, Dan Vrátil >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 116705: Make BalooIndexingAgent::indexedItems() return a real number or indexed items in collection

. Thanks, Dan Vrátil >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 116695: Fix conversion of value properties with CondEqual from Baloo::Term to Xapian::Query

Thanks, Dan Vrátil >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 116708: Support Akonadi instances in Baloo indexer

--- Thanks, Dan Vrátil >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 116705: Make BalooIndexingAgent::indexedItems() return a real number or indexed items in collection

qdbus org.freedesktop.Akonadi.Agent.akonadi_baloo_indexer / org.freedesktop.Akonadi.BalooIndexer.indexedItems XYZ" and compare result with number of items in collection XYZ reported by Akonadi Console, they should be the same. Thanks, Dan Vrátil >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 116695: Fix conversion of value properties with CondEqual from Baloo::Term to Xapian::Query

- src/pim/akonadiplugin/autotests/searchplugintest.cpp 824da60 src/pim/search/pimsearchstore.cpp 7d208db Diff: https://git.reviewboard.kde.org/r/116695/diff/ Testing --- Unit tests pass Thanks, Dan Vrátil >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#un

Re: Review Request 116692: Lower memory usage of akonadi_baloo_indexer with frequent commits

> On March 10, 2014, 11:18 a.m., Sergio Luis Martins wrote: > > Hi, Is this the same patch I tested a few days ago ? That one didn't fix > > the problem, I still reach 1.5GB of memory usage with a 100k e-mail maildir. There is still the problem with Akonadi/KMime "leaking" lots and lots of mem