Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2018-01-25 Thread James Smith
/balooctl/main.cpp b12b39d753aa6f65aefb1cade2bd44edcb7d0f38 Diff: https://git.reviewboard.kde.org/r/129605/diff/4/ Testing --- Compile, run. Thanks, James Smith

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-10-01 Thread James Smith
avoid a complete rebuild of the database after a Frameworks > update, that would be good. > > Would it be better to read the old location if found and reserve the new > one only for new database (or rebuilt) and switch to the new one for > Frameworks 6? > > James Sm

Re: Review Request 128665: Nested tags for Baloo Widgets

2017-02-19 Thread James Smith
https://git.reviewboard.kde.org/r/128665/diff/ Testing --- Compile, run File Attachments Edit Tags Dialog https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/b572b577-0931-40c5-a6d9-6dd655b0f1b6__baloonestedtagwidget.png Thanks, James Smith

Re: Review Request 128664: Nested tags for Baloo

2017-02-19 Thread James Smith
88bb59a01e5592abb74b1ab345bfc6765d35db57 src/kioslaves/tags/kio_tags.cpp de2e6d71945632e23a85f831878b4c431360731c src/lib/searchstore.cpp 72185d182a8adebe9b8f66ff8b7e5ce9565b6cb4 Diff: https://git.reviewboard.kde.org/r/128664/diff/ Testing --- Compile, run Thanks, James Smith

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-16 Thread James Smith
52c42e9821fac6e077b0e5e7eaadf40f3e20c6a6 src/tools/balooctl/main.cpp b12b39d753aa6f65aefb1cade2bd44edcb7d0f38 Diff: https://git.reviewboard.kde.org/r/129605/diff/ Testing --- Compile, run. Thanks, James Smith

Re: Review Request 128664: Nested tags for Baloo

2017-02-15 Thread James Smith
/searchstore.cpp 72185d182a8adebe9b8f66ff8b7e5ce9565b6cb4 Diff: https://git.reviewboard.kde.org/r/128664/diff/ Testing --- Compile, run Thanks, James Smith

Re: Review Request 128665: Nested tags for Baloo Widgets

2017-02-15 Thread James Smith
.org/media/uploaded/files/2016/09/07/b572b577-0931-40c5-a6d9-6dd655b0f1b6__baloonestedtagwidget.png Thanks, James Smith

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-09 Thread James Smith
, James Smith

Re: Review Request 128664: Nested tags for Baloo

2017-02-06 Thread James Smith
/searchstore.cpp 72185d182a8adebe9b8f66ff8b7e5ce9565b6cb4 Diff: https://git.reviewboard.kde.org/r/128664/diff/ Testing --- Compile, run Thanks, James Smith

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-06 Thread James Smith
avoid a complete rebuild of the database after a Frameworks > update, that would be good. > > Would it be better to read the old location if found and reserve the new > one only for new database (or rebuilt) and switch to the new one for > Frameworks 6? > > James Sm

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-06 Thread James Smith
b12b39d753aa6f65aefb1cade2bd44edcb7d0f38 Diff: https://git.reviewboard.kde.org/r/129605/diff/ Testing --- Compile, run. Thanks, James Smith

Re: Review Request 128664: Nested tags for Baloo

2017-02-04 Thread James Smith
> On Sept. 23, 2016, 3:16 a.m., Boudhayan Gupta wrote: > > Diff looks sane to me, and the feature seems useful in theory. > > > > Will this require a reindexing? Seems to me from previous comments made by > > vHanda that there's a schema change involved? >

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-04 Thread James Smith
avoid a complete rebuild of the database after a Frameworks > update, that would be good. > > Would it be better to read the old location if found and reserve the new > one only for new database (or rebuilt) and switch to the new one for > Frameworks 6? > > James Sm

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-04 Thread James Smith
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129605/#review102382 ------- On Dec. 12, 2016, 4:06 a.m., James Smith wrote: > > ---

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2016-12-05 Thread James Smith
recreated and repopulated with the same dataset it had before removal. - James --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129605/#review101298 -------

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2016-12-05 Thread James Smith
tion. - James --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129605/#review101297 --- On Dec. 3, 2016, 9 p.m., Ja

Review Request 129605: Move the Baloo database into the XDG cache path.

2016-12-03 Thread James Smith
Diff: https://git.reviewboard.kde.org/r/129605/diff/ Testing --- Compile, run. Thanks, James Smith

Re: Review Request 128664: Nested tags for Baloo

2016-12-01 Thread James Smith
/kio_tags.cpp de2e6d71945632e23a85f831878b4c431360731c src/lib/searchstore.cpp 060a4fd795ab858eb84526f93f827d09ee85db7c Diff: https://git.reviewboard.kde.org/r/128664/diff/ Testing --- Compile, run Thanks, James Smith

Re: Review Request 128738: baloosearch usability improvements

2016-10-18 Thread James Smith
same value as baloo widgets. Diffs (updated) - src/tools/baloosearch/main.cpp 8fabdbb90197c727f599c7c32076a9a254f0a40f Diff: https://git.reviewboard.kde.org/r/128738/diff/ Testing --- Compile, run. Thanks, James Smith

Re: Review Request 128738: baloosearch usability improvements

2016-10-09 Thread James Smith
://git.reviewboard.kde.org/r/128738/diff/ Testing --- Compile, run. Thanks, James Smith

Re: Review Request 128664: Nested tags for Baloo

2016-10-09 Thread James Smith
: https://git.reviewboard.kde.org/r/128664/diff/ Testing --- Compile, run Thanks, James Smith

Re: Review Request 128664: Nested tags for Baloo

2016-09-23 Thread James Smith
he full tag is stored in its own prefix. - James --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/#review99481 --- On Sept.

Re: Review Request 128664: Nested tags for Baloo

2016-09-22 Thread James Smith
es/tags/kio_tags.cpp de2e6d71945632e23a85f831878b4c431360731c src/lib/searchstore.cpp 060a4fd795ab858eb84526f93f827d09ee85db7c Diff: https://git.reviewboard.kde.org/r/128664/diff/ Testing --- Compile, run Thanks, James Smith

Re: Review Request 128665: Nested tags for Baloo Widgets

2016-09-22 Thread James Smith
ialog https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/b572b577-0931-40c5-a6d9-6dd655b0f1b6__baloonestedtagwidget.png Thanks, James Smith

Re: Review Request 128664: Nested tags for Baloo

2016-09-07 Thread James Smith
de2e6d71945632e23a85f831878b4c431360731c src/lib/searchstore.cpp 060a4fd795ab858eb84526f93f827d09ee85db7c Diff: https://git.reviewboard.kde.org/r/128664/diff/ Testing --- Compile, run Thanks, James Smith

Re: Review Request 128738: Quote all prefix search values, if operator is = or :.

2016-09-07 Thread James Smith
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128738/#review98859 --- On Aug. 24, 2016, 3:26 p.m., James Smith wrote: > > ---

Re: Review Request 128665: Nested tags for Baloo Widgets

2016-09-07 Thread James Smith
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/b572b577-0931-40c5-a6d9-6dd655b0f1b6__baloonestedtagwidget.png Thanks, James Smith

Re: Review Request 128664: Nested tags for Baloo

2016-09-07 Thread James Smith
88bb59a01e5592abb74b1ab345bfc6765d35db57 src/kioslaves/tags/kio_tags.cpp de2e6d71945632e23a85f831878b4c431360731c src/lib/searchstore.cpp 060a4fd795ab858eb84526f93f827d09ee85db7c Diff: https://git.reviewboard.kde.org/r/128664/diff/ Testing --- Compile, run Thanks, James Smith

Re: Review Request 128664: Nested tags for Baloo

2016-09-07 Thread James Smith
is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/#review98860 --- On Aug. 20, 2016, 10:58 p.m., James Smith wrote: > > -

Re: Review Request 128738: Quote all prefix search values, if operator is = or :.

2016-08-31 Thread James Smith
out surrounding quotes anyway. - James --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128738/#review98763 --- On Aug. 24, 2016, 3:26 p.

Re: Review Request 128738: Quote all prefix search values, if operator is = or :.

2016-08-23 Thread James Smith
matching operator = or :. Diffs (updated) - src/tools/baloosearch/main.cpp 8fabdbb Diff: https://git.reviewboard.kde.org/r/128738/diff/ Testing --- Compile, run. Thanks, James Smith

Review Request 128738: Fix for baloosearch tool tags with spaces

2016-08-22 Thread James Smith
quotation marks surrounding the search term for tag searches. Diffs - src/tools/baloosearch/main.cpp 8fabdbb Diff: https://git.reviewboard.kde.org/r/128738/diff/ Testing --- Compile, run. Thanks, James Smith

Re: Review Request 128664: Nested tags for Baloo

2016-08-20 Thread James Smith
> > > > > I think this line along with the next can now be removed. It looks like these are still used in fetchPrefix(). - James ------- This is an automatically generated e-mail. To reply, visit: https://git.reviewb

Re: Review Request 128664: Nested tags for Baloo

2016-08-20 Thread James Smith
o_tags.cpp de2e6d71945632e23a85f831878b4c431360731c src/lib/searchstore.cpp 060a4fd795ab858eb84526f93f827d09ee85db7c Diff: https://git.reviewboard.kde.org/r/128664/diff/ Testing --- Compile, run Thanks, James Smith

Re: Review Request 128665: Nested tags for Baloo Widgets

2016-08-20 Thread James Smith
128665/#review98495 --- On Aug. 19, 2016, 12:05 a.m., James Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://g

Re: Review Request 128665: Nested tags for Baloo Widgets

2016-08-18 Thread James Smith
s for creating and selecting nested tags. Diffs (updated) - src/kedittagsdialog.cpp 1778d53 src/kedittagsdialog_p.h 3c4de19 src/tagcheckbox.cpp 8273a7f Diff: https://git.reviewboard.kde.org/r/128665/diff/ Testing --- Compile, run Thanks, James Smith

Review Request 128665: Nested tags for Baloo Widgets

2016-08-17 Thread James Smith
src/kedittagsdialog_p.h 3c4de19 src/tagcheckbox.cpp 8273a7f Diff: https://git.reviewboard.kde.org/r/128665/diff/ Testing --- Compile, run Thanks, James Smith

Review Request 128664: Nested tags for Baloo

2016-08-17 Thread James Smith
src/kioslaves/tags/kio_tags.cpp de2e6d71945632e23a85f831878b4c431360731c src/lib/searchstore.cpp 060a4fd795ab858eb84526f93f827d09ee85db7c Diff: https://git.reviewboard.kde.org/r/128664/diff/ Testing --- Compile, run Thanks, James Smith