D25827: kcodecs EBN transport protocol cleanup

2020-03-04 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D25827 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25757: EBN purpose constructor cleanup

2020-03-04 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D25757 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26096: kio filewidgets EBN constructor cleanup

2020-03-04 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26096 To: jhayes Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26089: baloo EBN transport protocol cleanup

2020-03-04 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26089 To: jhayes, ngraham, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D25865: kfilemetadata EBN transport protocol cleanup

2020-03-04 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25865 To: jhayes Cc: vkrause, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D25407: EBN cleanup to change quotes and transport protocol

2020-03-04 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25407 To: jhayes Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25388: Make constructor explicit and cleanup QWebPluginFactory #include.

2020-03-03 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R300 KDEWebKit REVISION DETAIL https://phabricator.kde.org/D25388 To: jhayes Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26095: kio EBN constructor cleanup

2020-03-01 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26095 To: jhayes Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26092: kidletime EBN constructor cleanup

2020-03-01 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D26092 To: jhayes, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25388: Make constructor explicit and cleanup QWebPluginFactory #include.

2019-12-18 Thread John Hayes
jhayes added a comment. ping REPOSITORY R300 KDEWebKit REVISION DETAIL https://phabricator.kde.org/D25388 To: jhayes Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26096: kio filewidgets EBN constructor cleanup

2019-12-18 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Make constructors explicit in kio/filewidgets REPOSITORY R241 KIO BRANCH ebn-constructor-cleanup-filewidgets

D26095: kio EBN constructor cleanup

2019-12-18 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Make constructor explicit REPOSITORY R241 KIO BRANCH ebn-constructor-cleanup (branched from master) REVISION

D26092: kidletime EBN constructor cleanup

2019-12-18 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Make constructors explict REPOSITORY R274 KIdleTime BRANCH ebn-cleanup (branched from master) REVISION DETAIL

D26089: baloo EBN transport protocol cleanup

2019-12-18 Thread John Hayes
jhayes updated this revision to Diff 71817. jhayes added a comment. - Deleted addAuthor line as requested REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26089?vs=71807=71817 BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL

D26089: baloo EBN transport protocol cleanup

2019-12-18 Thread John Hayes
jhayes added a comment. Are you meaning the whole aboutData.addAuthor line or just the change that's in the patch? John REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26089 To: jhayes, ngraham, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77,

D26089: baloo EBN transport protocol cleanup

2019-12-18 Thread John Hayes
jhayes created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change transport protocol from http to https REPOSITORY R293 Baloo BRANCH ebn-transport-cleanup

D25865: kfilemetadata EBN transport protocol cleanup

2019-12-17 Thread John Hayes
jhayes updated this revision to Diff 71751. jhayes added a comment. - Reversed URI changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25865?vs=71236=71751 BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL

D25865: kfilemetadata EBN transport protocol cleanup

2019-12-16 Thread John Hayes
jhayes added a comment. You're right, can we just close this? John REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25865 To: jhayes Cc: vkrause, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov,

D25866: kholidays EBN transport protocol cleanup

2019-12-10 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change http to https and update link to calendar faq REPOSITORY R175 KHolidays BRANCH ebn-transport-cleanup

D25865: kfilemetadata EBN transport protocol cleanup

2019-12-10 Thread John Hayes
jhayes created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change tranport protocol from http to https and verify address REPOSITORY R286 KFileMetaData BRANCH

Links with no https address

2019-12-10 Thread John Hayes
@winters Here is another link with no https address to add to the whitelist, http://id3.org/ It's in file kframeworks5/kfilemetadata/src/extractors/taglibextractor.cpp line 483 John

D25864: kdeclarative EBN spelling cleanup

2019-12-10 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Correct spelling in comments REPOSITORY R296 KDeclarative BRANCH ebn-spelling-cleanup (branched from master)

D25829: kconfig EBN transport protocol cleanup

2019-12-09 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change and test transport protocol from http to https while correcting dead link REPOSITORY R237 KConfig BRANCH

D25827: kcodecs EBN transport protocol cleanup

2019-12-09 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Cleaned up transport protocol from http to https and verified addresses worked REPOSITORY R270 KCodecs BRANCH

D25753: EBN extra-cmake-modules transport cleanup

2019-12-06 Thread John Hayes
jhayes added a comment. The two links I know of are: http://0pointer.de/lennart/projects/libcanberra (works as is in file but wont work as https) http://www.x86-64.org/documentation/abi.pdf (http://www.x86-64.org is dead) REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D25753: EBN extra-cmake-modules transport cleanup

2019-12-05 Thread John Hayes
jhayes updated this revision to Diff 70973. jhayes added a comment. - Corrected URL as review comments Corrected url to http://www.sphinx-doc.org REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25753?vs=70958=70973 BRANCH

D25753: EBN extra-cmake-modules transport cleanup

2019-12-05 Thread John Hayes
jhayes updated this revision to Diff 70958. jhayes added a comment. - Corrections made per review comments. Reverted some non-working URL's back to http and updated one URL to the correct address REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

Re: D25448: EBN cleanup of autotests transfer protocol

2019-12-05 Thread John Hayes
I don't have commit access, could someone land this for me? On Sat, 23 Nov 2019, 9:07 am John Hayes, wrote: > jhayes updated this revision to Diff 70220. > jhayes retitled this revision from "EBN cleanup of autests transfer > protocol" to "EBN cleanup of autotests tran

D25757: EBN purpose constructor cleanup

2019-12-04 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Added explicit to the constructors REPOSITORY R495 Purpose Library BRANCH ebn-cleanup (branched from master)

D25753: EBN extra-cmake-modules transport cleanup

2019-12-04 Thread John Hayes
jhayes created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change transport protocol from http to https REPOSITORY R240 Extra CMake Modules BRANCH

D25752: EBN extra-cmake-modules comments spelling cleanup

2019-12-04 Thread John Hayes
jhayes created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Correct spelling in extra-cmake-modules comments. REPOSITORY R240 Extra CMake Modules

D25448: EBN cleanup of autotests transfer protocol

2019-12-04 Thread John Hayes
jhayes added a comment. I don't have commit access, could someone land this for me? REPOSITORY R267 Oxygen Icons BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25448 To: jhayes, apol Cc: meven, apol, kde-frameworks-devel, LeGast00n, GB_2,

D25719: EBN KActivites transfer protocol cleanup

2019-12-04 Thread John Hayes
jhayes added a comment. I don't have commit access, could someone land this for me? REPOSITORY R6 KActivities BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25719 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25721: EBN kdeclarative transfer protocol cleanup

2019-12-04 Thread John Hayes
jhayes added a comment. I don't have commit access. Would someone land this for me? REPOSITORY R296 KDeclarative BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25721 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

Patches ready to land

2019-12-04 Thread John Hayes
What happens next after patches are accepted and marked ready to land? Is there anything else needed from me? I don't have commit access.

D25721: EBN kdeclarative transfer protocol cleanup

2019-12-03 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change transfer protocol from http to https REPOSITORY R296 KDeclarative BRANCH ebn-cleanup (branched from master)

D25719: EBN KActivites transfer protocol cleanup

2019-12-03 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change transfer protocol from http to https REPOSITORY R6 KActivities BRANCH ebn-cleanup (branched from master)

D25493: EBN kmoretools cleanup transport protocol

2019-11-26 Thread John Hayes
jhayes added a comment. No I don't have commitcommit access. REPOSITORY R304 KNewStuff BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25493 To: jhayes, dhaumann Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25493: EBN kmoretools cleanup transport protocol

2019-11-23 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Cleanup of kmoretools tranport protocol from http to https REPOSITORY R304 KNewStuff BRANCH ebn-cleanup (branched

D25448: EBN cleanup of autotests transfer protocol

2019-11-23 Thread John Hayes
jhayes updated this revision to Diff 70220. jhayes retitled this revision from "EBN cleanup of autests transfer protocol" to "EBN cleanup of autotests transfer protocol". jhayes added a comment. Corrected summary typo REPOSITORY R267 Oxygen Icons CHANGES SINCE LAST UPDATE

D25448: EBN cleanup of autests transfer protocol

2019-11-22 Thread John Hayes
jhayes added a comment. arc amend is not allowing me to correct the typo, it just shows it and then back to command line. REPOSITORY R267 Oxygen Icons BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25448 To: jhayes, apol Cc: meven, apol,

D25448: EBN cleanup of autests transfer protocol

2019-11-22 Thread John Hayes
jhayes added a comment. No I don't have a commit account yet John Hayes REPOSITORY R267 Oxygen Icons BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25448 To: jhayes, apol Cc: meven, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D25448: EBN cleanup of autests transfer protocal

2019-11-21 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY change newlinetest.cpp protocol from http to https REPOSITORY R267 Oxygen Icons BRANCH ebn-cleanup (branched from

D25407: EBN cleanup to change quotes and transport protocol

2019-11-19 Thread John Hayes
jhayes added a comment. This diff was the changes that was made to two lines in a total of two files. Arc sent the original diff with nothing but svg changes. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25407 To: jhayes Cc: kde-frameworks-devel, LeGast00n,

D25407: EBN cleanup to change quotes and transport protocol

2019-11-19 Thread John Hayes
jhayes updated this revision to Diff 70030. jhayes added a comment. This is what the diff should have been to start with REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25407?vs=70005=70030 REVISION DETAIL https://phabricator.kde.org/D25407

D25407: EBN cleanup to change quotes and transport protocol

2019-11-19 Thread John Hayes
jhayes added a comment. I checked the diff and this change is not what I changed. I changed 3 characters total out of 2 files. John Hayes REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25407 To: jhayes Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh

D25407: EBN cleanup to change quotes and transport protocol

2019-11-19 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change from "" to '' to add a char to a string. Change transport protocol from http to https. REPOSITORY R266 Breeze

D25388: Make constructor explicit and cleanup QWebPluginFactory #include.

2019-11-18 Thread John Hayes
jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REPOSITORY R300 KDEWebKit BRANCH master REVISION DETAIL https://phabricator.kde.org/D25388 AFFECTED FILES src/kwebpluginfactory.h