D8946: Avoid unnecessary 'dataChanged' signal

renatoo updated this revision to Diff 22758. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8946?vs=22739=22758 REVISION DETAIL https://phabricator.kde.org/D8946 AFFECTED FILES

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

renatoo updated this revision to Diff 22757. renatoo added a comment. Updated parent brach REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8945?vs=22738=22757 REVISION DETAIL https://phabricator.kde.org/D8945 AFFECTED FILES

D8943: Create 'KFilePlacesModel::convertedUrl' static function

renatoo updated this revision to Diff 22755. renatoo marked 2 inline comments as done. renatoo added a comment. Updated documentation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8943?vs=22736=22755 REVISION DETAIL https://phabricator.kde.org/D8943

D8944: Create a 'KFilePlacesModel::refresh' function

renatoo updated this revision to Diff 22756. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8944?vs=22737=22756 REVISION DETAIL https://phabricator.kde.org/D8944 AFFECTED FILES

D8947: Expose KFilePlacesModel 'iconName' role

renatoo retitled this revision from "Expose KFilePlacesModel 'iconName' rule" to "Expose KFilePlacesModel 'iconName' role". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8947 To: renatoo, dfaure Cc: ngraham, kossebau, #frameworks

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

renatoo planned changes to this revision. renatoo added a comment. Implement unit test REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8948 To: renatoo, dfaure Cc: #frameworks

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

renatoo edited the summary of this revision. renatoo added a reviewer: dfaure. renatoo added a dependency: D8947: Expose KFilePlacesModel 'iconName' rule. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8948 To: renatoo, dfaure Cc: #frameworks

D8947: Expose KFilePlacesModel 'iconName' rule

renatoo added a dependent revision: D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8947 To: renatoo, dfaure Cc: #frameworks

D8946: Avoid unnecessary 'dataChanged' signal

renatoo added a dependent revision: D8947: Expose KFilePlacesModel 'iconName' rule. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8946 To: renatoo, dfaure Cc: #frameworks

D8947: Expose KFilePlacesModel 'iconName' rule

renatoo edited the summary of this revision. renatoo added a reviewer: dfaure. renatoo added a dependency: D8946: Avoid unnecessary 'dataChanged' signal. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8947 To: renatoo, dfaure Cc: #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

renatoo added a dependent revision: D8946: Avoid unnecessary 'dataChanged' signal. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8945 To: renatoo, dfaure Cc: #frameworks

D8946: Avoid unnecessary 'dataChanged' signal

renatoo edited the summary of this revision. renatoo added a reviewer: dfaure. renatoo added a dependency: D8945: Return a valid bookmark object for any entry in KFilePlacesModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8946 To: renatoo, dfaure Cc: #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

renatoo edited the summary of this revision. renatoo added a reviewer: dfaure. renatoo added a dependency: D8944: Create a 'KFilePlacesModel::refresh' function. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8945 To: renatoo, dfaure Cc: #frameworks

D8944: Create a 'KFilePlacesModel::refresh' function

renatoo added a dependent revision: D8945: Return a valid bookmark object for any entry in KFilePlacesModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8944 To: renatoo, dfaure Cc: #frameworks

D8944: Create a 'KFilePlacesModel::refresh' function

renatoo edited the summary of this revision. renatoo added a dependency: D8943: Create 'KFilePlacesModel::convertedUrl' static function. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8944 To: renatoo, dfaure Cc: #frameworks

D8332: Added baloo urls into places model

renatoo added a dependent revision: D8943: Create 'KFilePlacesModel::convertedUrl' static function. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure, mwolff Cc:

D8943: Create 'KFilePlacesModel::convertedUrl' static function

renatoo added a dependent revision: D8944: Create a 'KFilePlacesModel::refresh' function. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8943 To: renatoo, dfaure Cc: #frameworks

D8943: Create 'KFilePlacesModel::convertedUrl' static function

renatoo edited the summary of this revision. renatoo added dependencies: D8332: Added baloo urls into places model, D8434: Created 'remote' section, D8348: Add a section for removable devices. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8943 To: renatoo, dfaure Cc:

D8348: Add a section for removable devices

renatoo added a dependent revision: D8943: Create 'KFilePlacesModel::convertedUrl' static function. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham,

D8434: Created 'remote' section

renatoo added a dependent revision: D8943: Create 'KFilePlacesModel::convertedUrl' static function. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure Cc: dfaure, elvisangelaccio, mwolff, mlaurent,

D8862: Extend KFilePlacesModel API

renatoo abandoned this revision. renatoo added a comment. This review was spited in small ones: https://phabricator.kde.org/D8943 https://phabricator.kde.org/D8944 https://phabricator.kde.org/D8945 https://phabricator.kde.org/D8946 https://phabricator.kde.org/D8947

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY with 'KFilePlacesModel::movePlace' the external APIs can easily move items in the model without replicate the code. TEST PLAN Unit test

D8947: Expose KFilePlacesModel 'iconName' rule

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Make possible for external APIs to get the iconName used in each entry of KFilePlacesModel TEST PLAN Unit test created REPOSITORY

D8946: Avoid unnecessary 'dataChanged' signal

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Only emit 'dataChanged' signal if the data really changes TEST PLAN Unit test created REPOSITORY R241 KIO REVISION DETAIL

D8944: Create a 'KFilePlacesModel::refresh' function

renatoo added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8944 To: renatoo, dfaure Cc: #frameworks

D8943: Create 'KFilePlacesModel::convertedUrl' static function

renatoo added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8943 To: renatoo, dfaure Cc: #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Make sure that 'KFilePlacesModel::bookmarkForIndex' return a bookmark for any item in the model. TEST PLAN unit test created

D8943: Create 'KFilePlacesModel::convertedUrl' static function

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Move convertedUrl from KFilePlacesView to KFilePlacesModel to be reused by other views that use the same model. TEST PLAN unit test

D8944: Create a 'KFilePlacesModel::refresh' function

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Expose a public function that allows manually reload bookmark information TEST PLAN unit test created REPOSITORY R241 KIO REVISION

D8862: Extend KFilePlacesModel API

renatoo updated this revision to Diff 22703. renatoo added a comment. Created a public function 'moveItem' to be used by external apps REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8862?vs=22673=22703 REVISION DETAIL https://phabricator.kde.org/D8862

D8862: Extend KFilePlacesModel API

renatoo updated this revision to Diff 22673. renatoo added a comment. Added a new role to access icon name property REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8862?vs=22666=22673 REVISION DETAIL https://phabricator.kde.org/D8862 AFFECTED FILES

D8862: Extend KFilePlacesModel API

renatoo updated this revision to Diff 22666. renatoo marked 4 inline comments as done. renatoo added a comment. Fixed code style Added more unit test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8862?vs=22652=22666 REVISION DETAIL

D8862: Extend KFilePlacesModel API

renatoo updated this revision to Diff 22652. renatoo added a comment. Renamed function from convertUrl to convertedUrl REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8862?vs=22651=22652 REVISION DETAIL https://phabricator.kde.org/D8862 AFFECTED FILES

D8862: Extend KFilePlacesModel API

renatoo updated this revision to Diff 22651. renatoo added a comment. Created new function convertUrl Added @since tag to new functions REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8862?vs=22510=22651 REVISION DETAIL https://phabricator.kde.org/D8862

D8862: Extend KFilePlacesModel API

renatoo retitled this revision from "Extend API" to "Extend KFilePlacesModel API". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8862 To: renatoo Cc: #frameworks

D8348: Add a section for removable devices

renatoo added a dependent revision: D8862: Extend API. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8862: Extend API

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8862 To: renatoo Cc: #frameworks

D8862: Extend API

renatoo edited the summary of this revision. renatoo added dependencies: D8332: Added baloo urls into places model, D8630: Created unit test for PlacesItemModel, D8434: Created 'remote' section, D8348: Add a section for removable devices. REPOSITORY R241 KIO REVISION DETAIL

D8862: Extend API

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8862 To: renatoo Cc: #frameworks

D8434: Created 'remote' section

renatoo added a dependent revision: D8862: Extend API. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks

D8862: Extend API

renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source model for PlacesItemModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8862 To: renatoo Cc: #frameworks

D8332: Added baloo urls into places model

renatoo added a dependent revision: D8862: Extend API. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham,

D8862: Extend API

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Extend API to make it possible to use by external apps Make possible to retrieve item bookmark even if that is not a device Added

D8348: Add a section for removable devices

renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source model for PlacesItemModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff Cc: mwolff, abetts, mlaurent, anthonyfieroni,

D8332: Added baloo urls into places model

renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source model for PlacesItemModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure Cc: mwolff,

D8434: Created 'remote' section

renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source model for PlacesItemModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure Cc: dfaure, elvisangelaccio, mwolff, mlaurent,

D8348: Add a section for removable devices

renatoo updated this revision to Diff 22453. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=22393=22453 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks

D8434: Created 'remote' section

renatoo updated this revision to Diff 22454. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=22394=22454 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 22451. renatoo added a comment. Make 'isFileIndexingEnabled' a static function REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=22328=22451 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES

D8348: Add a section for removable devices

renatoo added inline comments. INLINE COMMENTS > mwolff wrote in kfileplacesitem.cpp:91 > shouldn't this always be called? i.e. when the bookmark is changed to a > different UDI, don't we need to update here, even when we had a valid device > UDI before? I think this also means this path isn't

D8348: Add a section for removable devices

renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

renatoo updated this revision to Diff 22393. renatoo added a comment. Update device info if udi changes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=22329=22393 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8434: Created 'remote' section

renatoo updated this revision to Diff 22394. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=22330=22394 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8348: Add a section for removable devices

renatoo marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

renatoo added a comment. In https://phabricator.kde.org/D8348#167924, @mwolff wrote: > In https://phabricator.kde.org/D8348#163546, @ngraham wrote: > > > Could you add camera:/ devices to this section too? That way we could also take care of

D8434: Created 'remote' section

renatoo updated this revision to Diff 22330. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21934=22330 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8348: Add a section for removable devices

renatoo updated this revision to Diff 22329. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=21933=22329 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 22328. renatoo marked 2 inline comments as done. renatoo added a comment. Fallback to initial url if the searchUrl is invalid. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=21932=22328 REVISION DETAIL

D8434: Created 'remote' section

renatoo marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks

D8434: Created 'remote' section

renatoo updated this revision to Diff 21934. renatoo marked 4 inline comments as done. renatoo added a comment. Fixed typos REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21809=21934 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8348: Add a section for removable devices

renatoo updated this revision to Diff 21933. renatoo added a comment. Parent branch update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=21808=21933 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 21932. renatoo marked an inline comment as done. renatoo added a comment. Fixed import REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=21807=21932 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES

D8348: Add a section for removable devices

renatoo updated this revision to Diff 21808. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=21759=21808 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks

D8434: Created 'remote' section

renatoo updated this revision to Diff 21809. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21760=21809 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 21807. renatoo added a comment. Added warning message for invalid search:// urls REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=21758=21807 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES

D8366: Factoring out lists of url data within KFilePlacesModelTest

renatoo added a comment. In https://phabricator.kde.org/D8366#163427, @ngraham wrote: > Is this dependent on any of the other patches floating around? Probably not, but that will affect (possible conflicts) with all patches REVISION DETAIL https://phabricator.kde.org/D8366 To:

D8366: Factoring out lists of url data within KFilePlacesModelTest

renatoo accepted this revision. REVISION DETAIL https://phabricator.kde.org/D8366 To: mlaurent, renatoo, ervin, franckarrecot Cc: ervin, ngraham, mlaurent, #frameworks

D8348: Add a section for removable devices

renatoo updated this revision to Diff 21759. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=21648=21759 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8434: Created 'remote' section

renatoo updated this revision to Diff 21760. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21757=21760 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 21758. renatoo added a comment. Fixed code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=21647=21758 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES autotests/CMakeLists.txt

D8332: Added baloo urls into places model

renatoo marked 5 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks

D8434: Created 'remote' section

renatoo updated this revision to Diff 21757. renatoo added a comment. Fixed code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21697=21757 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES autotests/kfileplacesmodeltest.cpp

D8348: Add a section for removable devices

renatoo added a dependent revision: D8434: Created 'remote' section. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg, ervin Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8434: Created 'remote' section

renatoo edited the summary of this revision. renatoo added dependencies: D8332: Added baloo urls into places model, D8348: Add a section for removable devices. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin, mwolff Cc:

D8332: Added baloo urls into places model

renatoo added a dependent revision: D8434: Created 'remote' section. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks

D8434: Created 'remote' section

renatoo updated this revision to Diff 21697. renatoo added a comment. Added more test cases Renamed enum to match group name REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21694=21697 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED

D8434: Created 'remote' section

renatoo updated this revision to Diff 21694. renatoo added a comment. Created unit test for remote ulrs REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21693=21694 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8434: Created 'remote' section

renatoo added a comment. In https://phabricator.kde.org/D8434#162786, @mwolff wrote: > Well, but if we use `Network` for `remote://` already, then the group should also have this label, no? I don't see an issue with this, really. On the contrary - maybe we could in the future remove the

D8434: Created 'remote' section

renatoo retitled this revision from "Created 'shared' section" to "Created 'remote' section". renatoo edited the summary of this revision. renatoo edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham,

D8434: Created 'shared' section

renatoo updated this revision to Diff 21693. renatoo added a comment. Renamed section from 'sared' to 'remote' REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21649=21693 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8434: Created 'shared' section

renatoo added a comment. In https://phabricator.kde.org/D8434#162727, @mwolff wrote: > lgtm overall. but I wonder about the naming choice. "Shared" is confusing, to me personally at least. Why not call it "Remote" or "Network"? The reasoning is that "shared" for me is only LAN/WLAN

D8367: Hidding place groups implementation in KFilePlacesModel

renatoo added a comment. In https://phabricator.kde.org/D8367#162465, @ngraham wrote: > Nice! If possible, I'd like a more user-friendly way of hiding and showing categories, though. The context menu is not very discoverable, and if a category is hidden, there's no indication that

D8332: Added baloo urls into places model

renatoo marked 4 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks

D8434: Created 'shared' section

renatoo updated this revision to Diff 21649. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21623=21649 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8348: Add a section for removable devices

renatoo updated this revision to Diff 21648. renatoo added a comment. Update parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=21622=21648 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 21647. renatoo marked 2 inline comments as done. renatoo added a comment. Created unittest for PlacesView::convertUrl Refactory some small part of the code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D8332: Added baloo urls into places model

renatoo added inline comments. INLINE COMMENTS > ervin wrote in kfileplacesmodel.cpp:68 > Do we really want to keep that state? It's never reevaluated so could be a > const if we keep it. > > Asks the question of what happens if the setting changes at runtime though. This code came from

D8348: Add a section for removable devices

renatoo updated this revision to Diff 21622. renatoo added a comment. Use plural form for RemovableDevicesType enum REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=21584=21622 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8348: Add a section for removable devices

renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg, ervin Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8434: Created 'shared' section

renatoo updated this revision to Diff 21623. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21585=21623 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8434: Created 'shared' section

renatoo updated this revision to Diff 21585. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21297=21585 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8243: Implement support for categories on KfilesPlacesView

renatoo updated this revision to Diff 21582. renatoo added a comment. Updated visuals to match dolphin REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8243?vs=21226=21582 REVISION DETAIL https://phabricator.kde.org/D8243 AFFECTED FILES

D8243: Implement support for categories on KfilesPlacesView

renatoo marked 3 inline comments as done. renatoo added inline comments. INLINE COMMENTS > ervin wrote in kfileplacesmodel.cpp:476 > Either reorder the enum or change for a different (more explicit not relying > on enum storage) comparison operator to have the "right" order. By right > order I

D8348: Add a section for removable devices

renatoo updated this revision to Diff 21584. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=21296=21584 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 21583. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=21227=21583 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES

D8243: Implement support for categories on KfilesPlacesView

renatoo added inline comments. INLINE COMMENTS > ervin wrote in kfileplacesmodel.cpp:476 > Either reorder the enum or change for a different (more explicit not relying > on enum storage) comparison operator to have the "right" order. By right > order I assume the goal was to align with Dolphin

D8243: Implement support for categories on KfilesPlacesView

renatoo added a comment. Guys, is that ready? Do you need any other change/fix? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8243 To: renatoo, #frameworks, dfaure, ervin, #vdg Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8434: Created 'shared' section

renatoo updated this revision to Diff 21297. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21238=21297 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

<    1   2   3   >