renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks
renatoo updated this revision to Diff 21296.
renatoo added a comment.
Used new connect API
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=21228=21296
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
renatoo added a comment.
Pleas unit test "hiddenCount" when groups are invisible, it is used by the
view in https://phabricator.kde.org/D8450
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, mlaurent, ngraham
Cc: ngraham, mlaurent,
renatoo added inline comments.
INLINE COMMENTS
> kfileplacesmodel.cpp:257
>
> bool KFilePlacesModel::isHidden(const QModelIndex ) const
> {
should this check if the group which the index belongs is hider or not?
Something like:
return (data(index, HiddenRole).toBool() ||
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin
Cc: mlaurent, #frameworks
renatoo updated this revision to Diff 21238.
renatoo added a comment.
Used QLatin1String for static strings
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21229=21238
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
renatoo marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
renatoo updated this revision to Diff 21229.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21176=21229
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
renatoo updated this revision to Diff 21227.
renatoo added a comment.
Upated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=20952=21227
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
renatoo updated this revision to Diff 21228.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=21003=21228
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
renatoo updated this revision to Diff 21226.
renatoo added a comment.
Fixed typo
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8243?vs=20951=21226
REVISION DETAIL
https://phabricator.kde.org/D8243
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
renatoo abandoned this revision.
renatoo added a comment.
In https://phabricator.kde.org/D8433#158886, @ngraham wrote:
> Looks like this was opened by accident; can you abandon it?
Ok sorry did not notice that two merge reguest was creted.
REPOSITORY
R241 KIO
REVISION DETAIL
renatoo added a comment.
In https://phabricator.kde.org/D8433#158886, @ngraham wrote:
> Looks like this was opened by accident; can you abandon it?
No this is a valid change? I would like to proposal that one. :D
REPOSITORY
R241 KIO
REVISION DETAIL
renatoo added reviewers: ngraham, Frameworks, Dolphin.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin
Cc: #frameworks
renatoo edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo
Cc: #frameworks
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Group all network related urls into the 'shared' section, to make it
clear to the user what is access through network or not
REPOSITORY
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Group all network related urls into the 'shared' section, to make it
clear to the user what is access through network or not
TEST PLAN
renatoo added a comment.
In https://phabricator.kde.org/D8332#158392, @ngraham wrote:
> @dvratil, any remaining objections? This looks great to me.
>
> @renatoo, once this is in, can we remove the now-duplicated code from
Dolphin?
Yes the idea is to try to use at least the
renatoo marked 3 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
renatoo added a comment.
In https://phabricator.kde.org/D8243#157336, @markg wrote:
> We have such a nice modular design with panels yet we keep cramming
everything in the places panel... Why?
> It's not just here, I've seen patches like this for Dolphin as well.
>
> Imho, the
renatoo updated this revision to Diff 21003.
renatoo added a comment.
Fixed unit test
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=20987=21003
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
renatoo marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
renatoo updated this revision to Diff 20987.
renatoo marked 2 inline comments as done.
renatoo added a comment.
Fixed code style
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=20953=20987
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED
renatoo added a comment.
Could add "Depends on https://phabricator.kde.org/D8332; into the summary.
I think something like:
root.setMetaDataItem("hiden-groups", "[]")
its is way more simple and do not need to export new groups.
REPOSITORY
R241 KIO
REVISION DETAIL
renatoo updated this revision to Diff 20953.
renatoo added a comment.
Update parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=20941=20953
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
renatoo updated this revision to Diff 20952.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=20940=20952
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
renatoo updated this revision to Diff 20951.
renatoo added a comment.
Fixed places item size calculation
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8243?vs=20939=20951
REVISION DETAIL
https://phabricator.kde.org/D8243
AFFECTED FILES
renatoo updated this revision to Diff 20941.
renatoo edited the summary of this revision.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=20919=20941
REVISION DETAIL
https://phabricator.kde.org/D8348
renatoo updated this revision to Diff 20940.
renatoo edited the summary of this revision.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=20918=20940
REVISION DETAIL
https://phabricator.kde.org/D8332
renatoo updated this revision to Diff 20939.
renatoo marked 11 inline comments as done.
renatoo edited the summary of this revision.
renatoo added a comment.
Fixed typo and code style
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8243?vs=20675=20939
REVISION
renatoo added a comment.
In https://phabricator.kde.org/D8348#156659, @ngraham wrote:
> Can you put the screenshot in the Summary section above, and list the
dependencies there too? Also put dependency information there, in the following
form:
>
>
> Depends on D8243
> Depends
renatoo added a dependent revision: D8332: Added baloo urls into places model.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin
Cc: ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
renatoo edited the summary of this revision.
renatoo added a dependency: D8243: Implement support for categories on
KfilesPlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: usta, mlaurent,
renatoo added a dependent revision: D8348: Add a section for removable devices.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: usta, mlaurent, dvratil, ngraham, #frameworks
renatoo edited the summary of this revision.
renatoo added dependencies: D8243: Implement support for categories on
KfilesPlacesView, D8332: Added baloo urls into places model.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks
Cc:
renatoo added a dependent revision: D8348: Add a section for removable devices.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin
Cc: ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks
Cc: ngraham, #frameworks
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: usta, mlaurent, dvratil, ngraham, #frameworks
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin
Cc: ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
renatoo added a comment.
In https://phabricator.kde.org/D8348#156653, @ngraham wrote:
> Is there a bugzilla ticket tracking this? And can you include a screenshot
showing what it looks like now?
There is no bugzilla, I can create one if that will helps.
A preview can be find
renatoo added reviewers: Dolphin, Frameworks.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks
Cc: #frameworks
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: usta, mlaurent, dvratil, ngraham, #frameworks
renatoo marked an inline comment as not done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: usta, mlaurent, dvratil, ngraham, #frameworks
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: usta, mlaurent, dvratil, ngraham, #frameworks
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Show removable devices in a different section
TEST PLAN
From any kde app try to open/save a file.
Plug any removable device in your
renatoo updated this revision to Diff 20918.
renatoo added a comment.
Typo fixed
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=20906=20918
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
renatoo marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: mlaurent, dvratil, ngraham, #frameworks
renatoo updated this revision to Diff 20906.
renatoo added a comment.
Fixed typos
Use QStringLiteral when possible
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=20905=20906
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
renatoo updated this revision to Diff 20905.
renatoo marked 5 inline comments as done.
renatoo added a comment.
Fixed typos
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=20879=20905
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
renatoo updated this revision to Diff 20879.
renatoo added a comment.
Does not load baloo urls if file index is disabled
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=20873=20879
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
renatoo updated this revision to Diff 20873.
renatoo added a comment.
Removed baloo dependency
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=20859=20873
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo
Cc: ngraham, #frameworks
renatoo planned changes to this revision.
renatoo added a comment.
Remove baloon dependency using KConfig API to query if it is enable, and
hard-code search url with a fixed string.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo
Cc: #frameworks
renatoo updated this revision to Diff 20675.
renatoo added a comment.
Updated unit test
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8243?vs=20674=20675
BRANCH
model-hide-row
REVISION DETAIL
https://phabricator.kde.org/D8243
AFFECTED FILES
renatoo updated this revision to Diff 20674.
renatoo marked 8 inline comments as done.
renatoo edited the summary of this revision.
renatoo added a comment.
updated comit summary
renamed m_dragModeCount to m_dragStart
refactory 'KFilePlacesItem::data' function
REPOSITORY
R241 KIO
renatoo added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kfileplacesview.cpp:169
> Ok i understaind the workaround, but did you know what is the value of
> opt.index.row() ?
Humm I did not know about this opt.index property. Did some debug here and it
is always -1 .
Sorry
renatoo marked an inline comment as done.
renatoo added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kfileplacesview.cpp:169
> Why you are sure that m_dragModeCount is 0 when indexIsSectionHeader? Why not
> when index.row() == 0 we can paint section header?
m_dragModeCount is
renatoo marked 2 inline comments as done.
renatoo added inline comments.
INLINE COMMENTS
> renatoo wrote in kfileplacesview.cpp:424
> I need a way query the header size height from "pointIsHeaderArea" to know if
> the user clicked on header or in the real item. Since I do not have access
>
renatoo updated this revision to Diff 20656.
renatoo added a comment.
Use QApplication::font() to determine the section header font size
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8243?vs=20650=20656
BRANCH
model-hide-row
REVISION DETAIL
renatoo added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kfileplacesview.cpp:424
> So you mean sizeHint have a right height ? This height store looks like a
> workaround.
I need a way query the header size height from "pointIsHeaderArea" to know if
the user clicked on header
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
renatoo updated this revision to Diff 20650.
renatoo marked an inline comment as done.
renatoo added a comment.
Optimize sectionsCount to not use a QSet
Use static_cast when possible
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8243?vs=20646=20650
BRANCH
renatoo updated this revision to Diff 20646.
renatoo added a comment.
Fixed code style
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8243?vs=20645=20646
BRANCH
model-hide-row
REVISION DETAIL
https://phabricator.kde.org/D8243
AFFECTED FILES
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
renatoo added a comment.
All problems fixed.
INLINE COMMENTS
> anthonyfieroni wrote in kfileplacesview.cpp:1065-1066
> So if second line is correct why not remove first one?
Sorry wrong operator it should be "+="
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
renatoo updated this revision to Diff 20645.
renatoo marked 9 inline comments as done.
renatoo added a comment.
Fix code syntax
Disable drag from item header
Does not show item header on floating preview during the drag
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
renatoo updated this revision to Diff 20613.
renatoo added a comment.
Does not use KCategorizedView
Instead of use KCategorizedView, draw the section over the first item area
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8243?vs=20587=20613
BRANCH
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Make use of KCategorizedView on file dialogs to classify the entries in
groups,
most similar as possible with dolphin
TEST PLAN
From
201 - 268 of 268 matches
Mail list logo
