Re: Is KF5::KCodecs::base64Encode now including a trailing newline?

2015-05-20 Thread Aleix Pol
On Wed, May 20, 2015 at 2:01 PM, Thomas Lübking wrote: > On Mittwoch, 20. Mai 2015 12:19:38 CEST, Daniel Vrátil wrote: > >> OK, if you think it's a bug, I'll post a RR to remove the behaviour. > > Afaiu it violates FRC 4648 which allows further RFCs (MIME) to weaken > restrictions, but itself forb

Re: Is KF5::KCodecs::base64Encode now including a trailing newline?

2015-05-20 Thread Thomas Lübking
On Mittwoch, 20. Mai 2015 12:19:38 CEST, Daniel Vrátil wrote: OK, if you think it's a bug, I'll post a RR to remove the behaviour. Afaiu it violates FRC 4648 which allows further RFCs (MIME) to weaken restrictions, but itself forbids it: "Implementations MUST reject the encoded data if it con

Re: Is KF5::KCodecs::base64Encode now including a trailing newline?

2015-05-20 Thread Daniel Vrátil
On Tuesday, May 19, 2015 03:32:03 PM Albert Astals Cid wrote: > El Dimarts, 19 de maig de 2015, a les 11:17:09, Daniel Vrátil va escriure: > > On Monday, May 18, 2015 07:32:54 PM Robby Stephenson wrote: > > > Hi, > > > > > > In the process of porting Tellico to KF5, one of my unit tests that > > >

Re: Is KF5::KCodecs::base64Encode now including a trailing newline?

2015-05-19 Thread Thiago Macieira
On Tuesday 19 May 2015 03:01:35 Robby Stephenson wrote: > At the very least, it should probably be mentioned in the class > documentation and porting notes as a behavior change. As to adding a > newline, I'll leave that up to you or others to determine. I was just going > to chop(1), but Thiago's s

Re: Is KF5::KCodecs::base64Encode now including a trailing newline?

2015-05-19 Thread Albert Astals Cid
El Dimarts, 19 de maig de 2015, a les 11:17:09, Daniel Vrátil va escriure: > On Monday, May 18, 2015 07:32:54 PM Robby Stephenson wrote: > > Hi, > > > > In the process of porting Tellico to KF5, one of my unit tests that > > depends on KCodecs::base64Encode() started to fail. After poking at it a

Re: Is KF5::KCodecs::base64Encode now including a trailing newline?

2015-05-19 Thread Robby Stephenson
On Tue, May 19, 2015 at 2:17 AM, Daniel Vrátil wrote: > On Monday, May 18, 2015 07:32:54 PM Robby Stephenson wrote: > > In the process of porting Tellico to KF5, one of my unit tests that > > depends on KCodecs::base64Encode() started to fail. After poking at it a > > little bit, my impression is

Re: Is KF5::KCodecs::base64Encode now including a trailing newline?

2015-05-19 Thread Daniel Vrátil
On Monday, May 18, 2015 07:32:54 PM Robby Stephenson wrote: > Hi, > > In the process of porting Tellico to KF5, one of my unit tests that > depends on KCodecs::base64Encode() started to fail. After poking at it a > little bit, my impression is that KF5::KCodecs is including a newline at > the end

Re: Is KF5::KCodecs::base64Encode now including a trailing newline?

2015-05-19 Thread Thiago Macieira
On Monday 18 May 2015 19:32:54 Robby Stephenson wrote: > Hi, > > In the process of porting Tellico to KF5, one of my unit tests that > depends on KCodecs::base64Encode() started to fail. After poking at it a > little bit, my impression is that KF5::KCodecs is including a newline at > the end of th

Is KF5::KCodecs::base64Encode now including a trailing newline?

2015-05-18 Thread Robby Stephenson
Hi, In the process of porting Tellico to KF5, one of my unit tests that depends on KCodecs::base64Encode() started to fail. After poking at it a little bit, my impression is that KF5::KCodecs is including a newline at the end of the byte string, where the kdelibs4 version didn't. But it's la