Re: Review Request 125004: Make "querying for remaining time" thread safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125004/ --- (Updated Sept. 5, 2015, 6:37 p.m.) Status -- This change has been ma

Re: Review Request 125004: Make "querying for remaining time" thread safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125004/#review84869 --- Ship it! - Vishesh Handa On Sept. 2, 2015, 7:54 a.m., Pinak

Re: Review Request 125004: Make "querying for remaining time" thread safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125004/#review84742 --- src/file/timeestimator.cpp (line 46)

Re: Review Request 125004: Make "querying for remaining time" thread safe

> On Sept. 2, 2015, 8:10 a.m., Kevin Funk wrote: > > src/file/timeestimator.cpp, line 46 > > > > > > I'm not sure this change is correct: This changes semantics wrt weights. > > > > I presume the prior ap

Re: Review Request 125004: Make "querying for remaining time" thread safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125004/#review84740 --- src/file/timeestimator.cpp (line 46)

Re: Review Request 125004: Make "querying for remaining time" thread safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125004/ --- (Updated Sept. 2, 2015, 7:54 a.m.) Review request for Baloo and Vishesh H

Re: Review Request 125004: Make "querying for remaining time" thread safe

> On Sept. 1, 2015, 6:12 p.m., Stefan Brüns wrote: > > src/file/timeestimator.cpp, line 47 > > > > > > No more reason to split this in two for loops, as it is guarded by > > m_estimateReady. > > > > Mayb

Re: Review Request 125004: Make "querying for remaining time" thread safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125004/#review84723 --- src/file/timeestimator.cpp (line 45)

Re: Review Request 125004: Make "querying for remaining time" thread safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125004/ --- (Updated Sept. 1, 2015, 11:42 a.m.) Review request for Baloo and Vishesh

Re: Review Request 125004: Make "querying for remaining time" thread safe

> On Aug. 31, 2015, 8:55 p.m., Vishesh Handa wrote: > > src/file/fileindexscheduler.h, line 106 > > > > > > Do you think it makes more sense for the TimeEstimator class to store > > the buffer? Yes that, makes

Re: Review Request 125004: Make "querying for remaining time" thread safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125004/#review84675 --- src/file/fileindexscheduler.h (line 106)

Review Request 125004: Make "querying for remaining time" thread safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125004/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti