Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string

2015-10-24 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125777/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string

2015-10-24 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125777/#review87348 --- src/qml/experimental/monitor.cpp (line 146)

Re: Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string

2015-10-25 Thread Pinak Ahuja
> On Oct. 24, 2015, 7:11 p.m., John Layt wrote: > > src/qml/experimental/monitor.cpp, line 146 > > > > > > Are you sure you want the system locale? Usually you want the > > application locale by calling QLocale(

Re: Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string

2015-10-28 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125777/ --- (Updated Oct. 28, 2015, 10:25 a.m.) Review request for Baloo and Vishesh

Re: Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string

2015-10-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125777/#review87608 --- Ship it! Ship It! - Vishesh Handa On Oct. 28, 2015, 10:25

Re: Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string

2015-10-29 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125777/ --- (Updated Oct. 29, 2015, 7:46 a.m.) Status -- This change has been ma