/utils/kglobalsettings.h 5fb1d9b
staging/kwidgets/src/utils/kglobalsettings.cpp 53b648e
Diff: http://git.reviewboard.kde.org/r/110833/diff/
Testing
---
it builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks
/kiconloader.cpp 795ec93
staging/kwidgets/src/utils/kglobalsettings.h 5fb1d9b
staging/kwidgets/src/utils/kglobalsettings.cpp 53b648e
Diff: http://git.reviewboard.kde.org/r/110833/diff/
Testing
---
it builds
Thanks,
Aleix Pol Gonzalez
___
Kde
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110674/#review33795
---
ping!
- Aleix Pol Gonzalez
On June 3, 2013, 4:08 p.m
af65f34
tier1/kwidgetsaddons/tests/CMakeLists.txt 85a8732
tier1/kwidgetsaddons/tests/kpassivepopuptest.h PRE-CREATION
tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/110815/diff/
Testing
---
It builds fine
Thanks,
Aleix Pol
and installs fine.
File Attachments
::addSeparator()
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-nospaceraction.png
KToolBarSpacerAction
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-spaceraction.png
Thanks,
Aleix Pol Gonzalez
/
Testing
---
builds and the test seems to work
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/tests/CMakeLists.txt 2bb9306
tier1/kwidgetsaddons/tests/kpixmapregionselectordialogtest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/110847/diff/
Testing
---
builds and the test seems to work
Thanks,
Aleix Pol Gonzalez
___
Kde
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110858/
---
(Updated June 6, 2013, 11:44 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110815/#review33920
---
ping!
- Aleix Pol Gonzalez
On June 5, 2013, 2:12 p.m
---
On June 10, 2013, 11:07 a.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110833
point).
Aleix Pol Gonzalez wrote:
Well, then the KWidgets not depending on KIconItems contradicts this
review request, right?
Kevin Ottens wrote:
Well, not really. Here it's more about removing the dependency on
KGlobalSettings than anything, and that is definitely welcome. Your
staging/kwidgets/src/utils/kglobalsettings.h 5fb1d9b
staging/kwidgets/src/utils/kglobalsettings.cpp 53b648e
Diff: http://git.reviewboard.kde.org/r/110833/diff/
Testing
---
it builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing
staging/kwidgets/tests/kpagewidgettest.h PRE-CREATION
staging/kwidgets/tests/kpagewidgettest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/110997/diff/
Testing
---
Everything builds, the test seems good.
Thanks,
Aleix Pol Gonzalez
/#review34320
---
On June 13, 2013, 2:57 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110997
://git.reviewboard.kde.org/r/110997/diff/
Testing
---
Everything builds, the test seems good.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110997/#review34475
---
ping...
- Aleix Pol Gonzalez
On June 14, 2013, 10:27 a.m
---
builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/06/#review34625
---
Ship it!
Cleaning up! ^^ good stuff
- Aleix Pol Gonzalez
On June 22, 2013, 10:58 a.m., Thomas Lübking wrote:
kdeui/util/kglobalsettings.cpp, line 308
http://git.reviewboard.kde.org/r/71/diff/1/?file=165092#file165092line308
These are the colors for the window titlbar (with ambiguous function
names, though), the default for
---
On June 22, 2013, 5:09 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/78
depending on the desktop environment I'm using.
Aleix Pol Gonzalez wrote:
Ok, then we have a problem:
- We don't want ki18n to decide what language we run (chusslove)
- We don't want kde's QPlatformTheme to decide what language we run
(albert)
Then who decides what language
this.
Diffs
-
staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp
b8f5fa7
Diff: http://git.reviewboard.kde.org/r/111298/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp
b8f5fa7
Diff: http://git.reviewboard.kde.org/r/111298/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
against kde4support
Diffs
-
kdeui/util/kglobalsettings.cpp 3e60632
Diff: http://git.reviewboard.kde.org/r/111348/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111298/#review35425
---
On July 1, 2013, 5:13 p.m., Aleix Pol Gonzalez wrote
---
On July 1, 2013, 5:13 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111298
/openurltest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111298/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/kwidgets/tests/openurltest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111298/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
://git.reviewboard.kde.org/r/111405/#review35636
---
On July 5, 2013, 2:25 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org
staging/kconfigwidgets/src/CMakeLists.txt cd0afd2
Diff: http://git.reviewboard.kde.org/r/111408/diff/
Testing
---
Builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
6f1832f
tier1/kwidgetsaddons/src/kfontchooser.cpp 53a4a90
Diff: http://git.reviewboard.kde.org/r/111409/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
---
On July 5, 2013, 6:24 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111409
://git.reviewboard.kde.org/r/111409/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/
Testing
---
Builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111409/#review35826
---
On July 8, 2013, 4:09 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated
class.
There's KDE_DEFAULT_* but I'll see how to do that in a different patch, there
are other cases where it's needed.
Diffs
-
Diff: http://git.reviewboard.kde.org/r/111833/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde
that in a different patch, there
are other cases where it's needed.
Diffs (updated)
-
KDE5PORTING.html 9d84525
kfile/kdirsortfilterproxymodel.cpp c8ea9b2
Diff: http://git.reviewboard.kde.org/r/111833/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
/xmlgui/src/CMakeLists.txt 255960f
staging/xmlgui/src/khelpclient.h e5f9946
staging/xmlgui/src/khelpclient.cpp dda0b13
Diff: http://git.reviewboard.kde.org/r/111834/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel
/kunitconversion/currency.cpp 8d18f633
Diff: http://git.reviewboard.kde.org/r/111841/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
staging/kunitconversion/src/kunitconversion/currency.cpp 8d18f633
Diff: http://git.reviewboard.kde.org/r/111841/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
/kunitconversion/currency.cpp 8d18f633
Diff: http://git.reviewboard.kde.org/r/111841/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
/r/111843/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Diff: http://git.reviewboard.kde.org/r/111897/diff/
Testing
---
builds...
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111905/#review37197
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 6, 2013, 9
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111897/#review37193
---
On Aug. 5, 2013, 6:06 p.m., Aleix Pol Gonzalez wrote
://git.reviewboard.kde.org/r/111897/#review37195
---
On Aug. 5, 2013, 6:06 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
On Aug. 6, 2013, 2:52 p.m., David Edmundson wrote:
tier1/kconfig/src/gui/kconfigloader.h, line 112
http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112
This looks like it should be const
I suspect it wasn't because KCoreConfigSeleton::findItem
staging/kde4support/src/kioslave/metainfo/CMakeLists.txt PRE-CREATION
staging/kde4support/tests/CMakeLists.txt 41e35ce
Diff: http://git.reviewboard.kde.org/r/111897/diff/
Testing
---
builds... actually i'm not sure if there's Qt5 soprano/strigi. what's hte
status?
Thanks,
Aleix Pol
...)
- Aleix Pol Gonzalez
On Aug. 5, 2013, 12:52 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111886
status?
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
CMakeLists.txt fb51ff4
interfaces/kimproxy/library/CMakeLists.txt 0dcee60
staging/kde4support/autotests/CMakeLists.txt 12fa24c
staging/kde4support/src/CMakeLists.txt 9e9b1d1
Diff: http://git.reviewboard.kde.org/r/112118/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
staging/frameworkintegration/src/kstyle/kstyle.cpp 63506476
Diff: http://git.reviewboard.kde.org/r/112175/diff/
Testing
---
Created a kstyletest that shows a dialog with a text edit and makes sure that
this works.
Thanks,
Aleix Pol Gonzalez
staging/frameworkintegration/src/kstyle/CMakeLists.txt 265eff4
Diff: http://git.reviewboard.kde.org/r/112175/diff/
Testing
---
Created a kstyletest that shows a dialog with a text edit and makes sure that
this works.
Thanks,
Aleix Pol Gonzalez
, then reviewboard
doesn't complain. The semantics are a bit different but it will work for you,
hopefully.
Cheers!
- Aleix Pol Gonzalez
On Aug. 22, 2013, 11:34 p.m., Wojciech Kapuscinski wrote:
---
This is an automatically generated e
staging/frameworkintegration/tests/kstyletest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/112175/diff/
Testing
---
Created a kstyletest that shows a dialog with a text edit and makes sure that
this works.
Thanks,
Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112277/#review38568
---
Ship it!
Makes sense to me, good catch!
- Aleix Pol Gonzalez
the cache whenever
the theme is changed. The cache is not useful anymore after a theme change.
- Aleix Pol Gonzalez
On Aug. 29, 2013, 8 p.m., Àlex Fiestas wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
://git.reviewboard.kde.org/r/112401/#comment28775
Maybe this could be a QSetQString?
You're doing many sorts that we can probably delay anyway (in case it's
even needed).
- Aleix Pol Gonzalez
On Aug. 31, 2013, 11:44 a.m., Chusslove Illich wrote
---
On Aug. 28, 2013, 4:17 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112331
---
On Aug. 28, 2013, 4:17 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112331
://git.reviewboard.kde.org/r/112331/diff/
Testing
---
Builds, unit tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/112449/diff/
Testing
---
builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112450/#review39171
---
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On Sept. 2
missing
something. Please tell me if that's the case.
Diffs
-
CMakeLists.txt 5a22f85
attic/modules/CMakeLists.txt c832bed
Diff: http://git.reviewboard.kde.org/r/112451/diff/
Testing
---
Installs and seems to work.
Thanks,
Aleix Pol Gonzalez
. To reply, visit:
http://git.reviewboard.kde.org/r/112451/#review39177
---
On Sept. 2, 2013, 3:09 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail
no tests.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
approved.
- Aleix Pol Gonzalez
On Sept. 1, 2013, 12:22 p.m., Chusslove Illich wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112401
://git.reviewboard.kde.org/r/112451/diff/
Testing
---
Installs and seems to work.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112457/#review39242
---
On Sept. 2, 2013, 4:42 p.m., Aleix Pol Gonzalez wrote
/klineedit.cpp b2b430d
staging/kcompletion/src/config-kcompletion.h.cmake 35b64a2
staging/kcompletion/src/CMakeLists.txt f08a47d
staging/kcompletion/src/klineedit_p.h 4d3cfbc
Diff: http://git.reviewboard.kde.org/r/112485/diff/
Testing
---
builds, tests pass
Thanks,
Aleix Pol Gonzalez
-modules/FindDocBookXSL.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/112451/diff/
Testing
---
Installs and seems to work.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
.
Diffs (updated)
-
attic/modules/FindDocBookXML.cmake 26053bf
attic/modules/FindDocBookXSL.cmake ab93c9e
Diff: http://git.reviewboard.kde.org/r/112451/diff/
Testing
---
Installs and seems to work.
Thanks,
Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119590/#review63719
---
Ship it!
Makes sense to me.
- Aleix Pol Gonzalez
On Aug
.
- Aleix Pol Gonzalez
On Aug. 3, 2014, 7:13 p.m., Thomas Lübking wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119593
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119594/#review63721
---
Ship it!
Makes sense to me.
- Aleix Pol Gonzalez
On Aug
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119588/#review63888
---
Ship it!
Looks reasonable to me.
- Aleix Pol Gonzalez
you're not accessing through them.
And maybe you can use the more generic type QAbstractButton, only maybe, I'm
unsure, up to you.
- Aleix Pol Gonzalez
On Aug. 10, 2014, 8:28 p.m., Albert Astals Cid wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119698/#review64263
---
Ship it!
Makes sense to me.
- Aleix Pol Gonzalez
On Aug
/119713/#comment44914
Wouldn't it be better to use something like this?
QIcon::setThemeSearchPaths(QIcon::themeSearchPaths()+thePathFor(breeze));
- Aleix Pol Gonzalez
On Aug. 11, 2014, 1:24 p.m., Albert Astals Cid wrote
the properties' methods (get/set/signal)
from the rest of the documentation? It would be really cool to document them
all together.
- Aleix Pol Gonzalez
On Aug. 11, 2014, 10:35 p.m., David Edmundson wrote:
---
This is an automatically generated e
in the sprint, I think we
should move this into the kde:kwidgetsaddons repository, in an examples
subdirectory.
- Aleix Pol Gonzalez
On Aug. 12, 2014, 9:33 a.m., Laurent Navet wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119745/#review64405
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 12, 2014
/kde5/lib64
Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons
Requires: Qt5Core
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119808/#review64750
---
Maybe a screenshot will make it easier to review?
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/#review64585
---
On Aug. 14, 2014, 11:10 p.m., Aleix Pol Gonzalez wrote
, on my system:
Name: KF5CoreAddons
Version: 5.1.0
Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64
Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons
Requires: Qt5Core
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
to interact with the
File List more often. I think this shows we want a new design after all.
For the moment, I won't +1 or -1.
- Aleix Pol Gonzalez
On Aug. 18, 2014, 10:04 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail
: KF5CoreAddons
Version: 5.1.0
Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64
Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons
Requires: Qt5Core
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
that don't use
KDEInstallDirs can create their own variable.
Also, pkconfig - pkgconfig.
Aleix Pol Gonzalez wrote:
I'm unsure about that, first ECM_MKSPECS_INSTALL_DIR is declared the same
way (again, copypaste) then I understand that we can override the variable
from
On Aug. 19, 2014, 10:19 a.m., Aleix Pol Gonzalez wrote:
I think it's disputable that the developers will want to interact with the
File List more often. I think this shows we want a new design after all.
For the moment, I won't +1 or -1.
Alex Merry wrote:
I'm admittedly going
break integration
quite a bit, wouldn't it be possible to set it as fallback?
- Aleix Pol Gonzalez
On Aug. 13, 2014, 8:55 p.m., Albert Astals Cid wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Aug. 24, 2014, 9:56 p.m., Aleix Pol Gonzalez wrote:
Changing the theme for everyone using kconfigwidgets would break
integration quite a bit, wouldn't it be possible to set it as fallback?
Albert Astals Cid wrote:
Break integration with what?
It only changes the theme
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119713/#review65160
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 13, 2014
/CMake_Coding_Style#End_commands
- Aleix Pol Gonzalez
On Aug. 25, 2014, 6 p.m., Rohan Garg wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901
/KCoreAddons
Requires: Qt5Core
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
screenshot would help in these reviews.
- Aleix Pol Gonzalez
On Aug. 26, 2014, 2:14 p.m., Hugo Pereira Da Costa wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119940
, reproduced with an application.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/119975/diff/
Testing
---
Ran tests, reproduced with an application.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
the comments are from
human?
- Aleix Pol Gonzalez
On Aug. 29, 2014, 2:16 p.m., Denis Steckelmacher wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119991
1301 - 1400 of 4752 matches
Mail list logo
