D17120: Implement zooming with Ctrl+mouse wheel

yurchor updated this revision to Diff 46665. yurchor added a comment. Something along the lines, at least works with my mouse and does not break things on the common machines. REPOSITORY R334 KmPlot CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17120?vs=46472&id=46665 REVISION

D17120: Implement zooming with Ctrl+mouse wheel

yurchor added a comment. In D17120#369588 , @aacid wrote: > In D17120#368102 , @yurchor wrote: > > > Add threshold to get rid of potential unwanted zooming on very sensitive touchpads. > > > Y

D17278: Meson plugin: First working version

flherne added a comment. It's quite easy to accidentally start repeated configure jobs, in which case the second one fails - e.g. by clicking "Apply" and then "Ok" in the project settings. Perhaps if a configure job is already running, it should be cancelled before starting a new one (o

D17120: Implement zooming with Ctrl+mouse wheel

aacid added a comment. In D17120#368102 , @yurchor wrote: > Add threshold to get rid of potential unwanted zooming on very sensitive touchpads. You need to accumulate them, otherwise people where all the deltas are small will never get i

D17278: Meson plugin: First working version

flherne added inline comments. INLINE COMMENTS > mesonbuilder.cpp:150 > +i18n("The directory '%1' is not empty and does not seem to be an > already configured build directory", > + buildDir.buildDir.toLocalFile())); > +case INVALID_BUILD_DIR: This condition is re

D17278: Meson plugin: First working version

rizzitello added inline comments. INLINE COMMENTS > dmensinger wrote in mesonconfigpage.cpp:178 > Then I guess it is personal preference :) > I like it better this way for (relatively) short type names without templates > and `::` (outside C++11 for loops). > If you are OK with it, I would like

D17278: Meson plugin: First working version

dmensinger marked 4 inline comments as done. dmensinger added inline comments. INLINE COMMENTS > rizzitello wrote in mesonconfigpage.cpp:178 > In these cases the type is obvious. Why not use auto? Then I guess it is personal preference :) I like it better this way for (relatively) short type nam

D17278: Meson plugin: First working version

rizzitello added inline comments. INLINE COMMENTS > dmensinger wrote in mesonconfigpage.cpp:178 > I don't know why you would use `auto` here. Should I use `auto` for every > dynamic_cast? In these cases the type is obvious. Why not use auto? REPOSITORY R32 KDevelop REVISION DETAIL https:/

D17278: Meson plugin: First working version

dmensinger updated this revision to Diff 46623. dmensinger added a comment. - Some code cleanup REPOSITORY R32 KDevelop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17278?vs=46614&id=46623 BRANCH meson_initial_phabricatorSucks (branched from master) REVISION DETAIL https:/

D17278: Meson plugin: First working version

dmensinger marked 6 inline comments as done. dmensinger added inline comments. INLINE COMMENTS > rizzitello wrote in mesonimportjob.cpp:47 > "sourcePath" and "bulilddir" appear to be unused here. Yeah, I haven't touched that code yet. This is still from the barebones framework that was created

[plasma-framework/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit e7756a10a5e701fc7cfdc5a5b644697379bbadea by l10n daemon script. Committed on 01/12/2018 at 15:00. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +814 -0po/ar/libplasma5.po A +867 -0po/bs/libplasma5.po A +277 -0po/ca/docs/plasma

[kwallet/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 61f944863c92ae8982171009ce0b485bbe60c102 by l10n daemon script. Committed on 01/12/2018 at 14:59. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +138 -0po/ar/kwallet-query.po A +784 -0po/ar/kwalletd5.po A +734 -0po/be/kwalletd5

[kservice/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 53266e77475e834124fc152b903de17b85ca78e2 by l10n daemon script. Committed on 01/12/2018 at 14:58. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +213 -0po/af/kservice5.po A +220 -0po/ar/kservice5.po A +224 -0po/as/kservice5.po

[kross/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit b2eaeb325a4eacc6537e8183ffc75afe7111a916 by l10n daemon script. Committed on 01/12/2018 at 14:58. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +201 -0po/af/kross5.po A +217 -0po/ar/kross5.po A +209 -0po/as/kross5.po A +220

[kpackage/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit eb32f65a1cdea615580714af62267dd5daaf3062 by l10n daemon script. Committed on 01/12/2018 at 14:58. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +541 -0po/ar/libkpackage5.po A +586 -0po/bs/libkpackage5.po A +327 -0po/ca/docs/kp

[kjsembed/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit eaeef1f61a6167e7e8c4ce2a3cf9af4ec896f25d by l10n daemon script. Committed on 01/12/2018 at 14:57. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +250 -0po/af/kjsembed5.po A +269 -0po/ar/kjsembed5.po A +249 -0po/as/kjsembed5.po

[kio/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 22a027e32c049970be5ba5cd67ca3d94eeda20fd by l10n daemon script. Committed on 01/12/2018 at 14:56. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +9655 -0po/af/kio5.po A +8981 -0po/ar/kio5.po A +8802 -0po/be/kio5.po A +9056 -0

[kjs/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 4f7b2e3f7d6f551e69b7d6a69dfee82d8b27e75d by l10n daemon script. Committed on 01/12/2018 at 14:57. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +210 -0po/ca/docs/kjs5/man-kjs5.1.docbook A +210 -0po/de/docs/kjs5/man-kjs5.1.docbook A

[kinit/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit ad57b5e4d17ef34851a067f0ea1eec3955cba4a2 by l10n daemon script. Committed on 01/12/2018 at 14:56. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +116 -0po/af/kinit5.po A +128 -0po/ar/kinit5.po A +119 -0po/as/kinit5.po A +116

[kdelibs4support/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 1eff48100567d09a5d6b22cd20785dfef22304e6 by l10n daemon script. Committed on 01/12/2018 at 14:54. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +14167 -0po/af/kdelibs4support.po A +13558 -0po/ar/kdelibs4support.po A +13790 -0po/a

[kdoctools/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 11dff2e3ce6da8eda6170f1354ba1a06f70eaa5e by l10n daemon script. Committed on 01/12/2018 at 14:55. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +37 -0po/af/kdoctools5.po A +40 -0po/ar/kdoctools5.po A +40 -0po/be/kdoctools5.

[kded/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 4767185299f0f18dc0eefebdce1f043504e76f5b by l10n daemon script. Committed on 01/12/2018 at 14:53. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +269 -0po/ca/docs/kded5/man-kded5.8.docbook A +269 -0po/de/docs/kded5/man-kded5.8.docboo

[kdesignerplugin/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit f46a0735f50974457d95715a96167b921a76eeb0 by l10n daemon script. Committed on 01/12/2018 at 14:54. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +74 -0po/af/kdesignerplugin5_qt.po A +68 -0po/ar/kdesignerplugin5_qt.po A +85 -0

[kconfigwidgets/v5.53.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 506d0583e1778ae7d09de2b2c5215bc8ee4995a3 by l10n daemon script. Committed on 01/12/2018 at 14:53. Pushed by dfaure into tag 'v5.53.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +660 -0po/af/kconfigwidgets5.po A +98 -0po/af/kf5_entry.desktop [TRAILING SPACE] ** A

D17278: Meson plugin: First working version

rizzitello added inline comments. INLINE COMMENTS > mesonbuilder.cpp:55 > + > +output->appendLine(i18n("*** MESON ERROR ***")); > +output->appendLine(QStringLiteral("")); Would ending the string with a \n (or two) remove the need to append an empty QStringLiteral in the next

D17278: Meson plugin: First working version

dmensinger updated this revision to Diff 46614. dmensinger added a comment. - Fixed typos and removed translations REPOSITORY R32 KDevelop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17278?vs=46611&id=46614 BRANCH meson_initial_phabricatorSucks (branched from master) REVISI

D17278: Meson plugin: First working version

yurchor added inline comments. INLINE COMMENTS > kdevmesonmanager.json:5 > +"Description": "Imports and edits Meson projects", > +"Description[ca@valencia]": "Importa i edita projectes del Meson", > +"Description[ca]": "Importa i edita projectes del Meson", There is no ne

D17278: Meson plugin: First working version

dmensinger updated this revision to Diff 46611. dmensinger added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Fixed typo in icons/CMakeLists.txt REPOSITORY R32 KDevelop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17278?vs=46602

D17262: Use https URLs where possible in KMail's documentation

vkrause updated this revision to Diff 46600. vkrause added a comment. Use translated userbase links. REPOSITORY R206 KMail CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17262?vs=46569&id=46600 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17262 AFFECTED FILES

D17262: Use https URLs where possible in KMail's documentation

vkrause added inline comments. INLINE COMMENTS > yurchor wrote in intro.docbook:88 > This page is translatable. Can we switch to the Translation extension syntax? > That is > > https://userbase.kde.org/Special:MyLanguage/KMail Wasn't aware of that feature :) Makes sense of course, will fix. R

D17277: Add a small section on using KDiff3 as a git diff/merge tool

yurchor created this revision. yurchor added reviewers: Documentation, mreeves. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. yurchor requested review of this revision. REVISION SUMMARY Just one more useful application of KDiff3. TEST PLAN Tested with chec