D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

2019-02-21 Thread Nathaniel Graham
ngraham updated this revision to Diff 52242. ngraham marked an inline comment as done. ngraham added a comment. Correct awkward string REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19186?vs=52156=52242 BRANCH use-the-word-sleep (branched from

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

2019-02-21 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > index.docbook:152 > > -If this option is chosen, a special behavior for activity can be chosen. If > this is a presentation activity, you can check the Never shutdown > the screen and Never suspend or shutdown the > computer boxes. It is

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

2019-02-21 Thread Nathaniel Graham
ngraham added a comment. In D19186#416850 , @aacid wrote: > -0.2 from my side, the thing is called suspend not sleep, if you look for "linux sleep" in a search engine you get references to the sleep (3) and sleep (1) man pages, which would only

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

2019-02-21 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D19186 To: ngraham, #vdg, #plasma, broulik Cc: abetts, aacid, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed,

D18744: Add action in Edit menu to select the text on current page

2019-02-21 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. All right, let's do this. In final testing, I just found some blockers: - If the current mouseMode is not `TextSelect`, then the menu item is enabled but does nothing. It

D18744: Add action in Edit menu to select the text on current page

2019-02-21 Thread Albert Astals Cid
aacid added a comment. In D18744#416853 , @shubham wrote: > @aacid ping? Personally i'm happy with a menu option, "no one" will see it, but that's the point, it's an option that "no one" needs. And for the people that need it,

D18744: Add action in Edit menu to select the text on current page

2019-02-21 Thread Albert Astals Cid
aacid added a comment. In D18744#413870 , @ngraham wrote: > Double-click in the margins can't be used for this since there would be too many accidental activations. > > Here's my proposal > > - Double-click in the margins: select whole

D18744: Add action in Edit menu to select the text on current page

2019-02-21 Thread Shubham
shubham added a comment. @aacid ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

2019-02-21 Thread Albert Astals Cid
aacid added a comment. -0.2 from my side, the thing is called suspend not sleep, if you look for "linux sleep" in a search engine you get references to the sleep (3) and sleep (1) man pages, which would only confuse the users. REPOSITORY R122 Powerdevil REVISION DETAIL