D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Nathaniel Graham
ngraham added a task: T11316: Systematic KCM reorganisation: Workspace section. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22871 To: GB_2, #plasma, #vdg, filipf, ngraham Cc: filipf, kde-doc-english, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh,

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:acddedf0bb1d: Use better Workspace Behavior KCM title and icon (authored by Bjrn Feber bfe...@protonmail.com, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[plasma-desktop] /: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
Git commit acddedf0bb1de753e037126428d589683fa380e7 by Björn Feber, on behalf of Bjrn Feber. Committed on 01/08/2019 at 20:24. Pushed by bfeber into branch 'master'. Use better Workspace Behavior KCM title and icon Summary: Consistently call the KCM "General Behavior" and use

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
GB_2 updated this revision to Diff 62933. GB_2 added a comment. Drop word "the" in descriptions REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22871?vs=62930=62933 BRANCH use-better-global-workspace-behavior-kcm-title-and-icon (branched from

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Ah right. Okay, this is fine then. REPOSITORY R119 Plasma Desktop BRANCH use-better-global-workspace-behavior-kcm-title-and-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D22871 To: GB_2, #plasma, #vdg,

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
GB_2 added a comment. In D22871#505360 , @ngraham wrote: > If we're going to make it "General", do we even need the word "Behavior" in there? It's implied by its category, no? I suppose there would be no visible parent category when running in

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Nathaniel Graham
ngraham added a comment. If we're going to make it "General", do we even need the word "Behavior" in there? It's implied by its category, no? I suppose there would be no visible parent category when running in kcmshell, but that doesn't seem like the hugest problem to me. REPOSITORY R119

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Filip Fila
filipf accepted this revision as: filipf. filipf added a comment. This revision is now accepted and ready to land. Looks OK, along with these two inline comments I'd also add some reasoning for the change to the commit message. INLINE COMMENTS > index.docbook:28 > > -This is a module to

D22880: Rename "Plasma Theme" to "Plasma Style"

2019-08-01 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in plasma-themes.knsrc:42 > > The KDE Store category name should probably be updated too. > > You mean here? What does this actually do? I mean in the actual store online :-) REPOSITORY R119 Plasma Desktop BRANCH

D22880: Rename "Plasma Theme" to "Plasma Style"

2019-08-01 Thread Nathaniel Graham
ngraham added a subscriber: leinir. ngraham added inline comments. INLINE COMMENTS > plasma-themes.knsrc:42 > ProvidersUrl=https://download.kde.org/ocs/providers.xml > Categories=Plasma Theme > StandardResource=tmp > The KDE Store category name should probably be updated too. You mean here?

D22880: Rename "Plasma Theme" to "Plasma Style"

2019-08-01 Thread Björn Feber
GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. The KDE Store category name should probably be updated too. REPOSITORY R119 Plasma Desktop BRANCH plasma-theme-to-plasma-style (branched from master) REVISION DETAIL

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
GB_2 retitled this revision from "Use better Global Workspace Behavior KCM title and icon" to "Use better Workspace Behavior KCM title and icon". GB_2 edited the summary of this revision. GB_2 edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22871: Use better Global Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
GB_2 updated this revision to Diff 62930. GB_2 added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. Use name "General Behavior" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22871?vs=62892=62930

D22594: [Dolphin] Open Preferred Search Tool action

2019-08-01 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, fbampaloukas, alexde, feverfew, meven, spoorun,

D22880: Rename "Plasma Theme" to "Plasma Style"

2019-08-01 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22880 To: ngraham, #vdg, #plasma Cc: plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, skadinna, himcesjf,

D22880: Rename "Plasma Theme" to "Plasma Style"

2019-08-01 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This implements one of the changes decided upon in T11314

D22594: [Dolphin] Open Preferred Search Tool action

2019-08-01 Thread Piotr Dabrowski
pdabrowski edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, fbampaloukas, alexde, feverfew, meven,

D22594: [Dolphin] Open Preferred Search Tool action

2019-08-01 Thread Piotr Dabrowski
pdabrowski updated this revision to Diff 62910. pdabrowski added a comment. Small fix for the "Open Preferred Search Tool" as a toolbar button. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22594?vs=62212=62910 REVISION DETAIL

D22594: [Dolphin] Open Preferred Search Tool action

2019-08-01 Thread Piotr Dabrowski
pdabrowski edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, fbampaloukas, alexde, feverfew, meven,