D26291: rework of keyboard widgets focus

2020-01-15 Thread Toni Asensi Esteve
asensi added a comment. The base of the idea is good, although after applying changes... Krusader users are not able to keep using the handy [Ctrl] + [↑] and [Ctrl] + [↓] to move focus even if they redefine the `Move Focus Up` and `Move Focus Down` keys :-? REVISION DETAIL https://phabri

D26684: [Notifications KCM] Add docbook for new KCM

2020-01-15 Thread Yuri Chornoivan
yurchor accepted this revision. yurchor added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26684 To: broulik, #documentation, yurchor Cc: yurchor, plasma-devel, kde-doc-english, LeGast00n,

D26684: [Notifications KCM] Add docbook for new KCM

2020-01-15 Thread Kai Uwe Broulik
broulik marked an inline comment as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26684 To: broulik, #documentation Cc: yurchor, plasma-devel, kde-doc-english, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, ng

D26684: [Notifications KCM] Add docbook for new KCM

2020-01-15 Thread Kai Uwe Broulik
broulik updated this revision to Diff 73618. broulik added a comment. - Fix wording REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26684?vs=73600&id=73618 REVISION DETAIL https://phabricator.kde.org/D26684 AFFECTED FILES doc/kcontrol/CMakeLists

D26684: [Notifications KCM] Add docbook for new KCM

2020-01-15 Thread Yuri Chornoivan
yurchor added a comment. Thanks for fixing this minor typo. INLINE COMMENTS > index.docbook:132 > +Keep popup open during progress > +Whether the popup should remain visible for the > entire duration of the progress or automatically hide. It will always shown > again when th

D26684: [Notifications KCM] Add docbook for new KCM

2020-01-15 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26684 To: broulik, #documentation Cc: plasma-devel, kde-doc-english, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, ngrah

D26684: [Notifications KCM] Add docbook for new KCM

2020-01-15 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Documentation. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 415250 FIXED-IN: 5.18.0 TEST PLAN - Clicked "Help"

D26652: Unbreak module imports for Python2

2020-01-15 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R264 KApiDox BRANCH fixpython2support REVISION DETAIL https://phabricator.kde.org/D26652 To: kossebau, ochurlaud, cordlandwehr, davidedmundson Cc: bcooksley, awilcox, kde-frameworks-devel, k