D27584: Umbrello add tooltips for UML elements

2020-02-22 Thread Yuri Chornoivan
yurchor added subscribers: ltoscano, yurchor. yurchor accepted this revision. yurchor added a comment. This revision is now accepted and ready to land. Thanks for fixing the i18n() issue. As it was mentioned by @ltoscano , it would be good for bug handling if there is a separate line

D27582: Documentation improveshttp: to https:, Review links and some menu items

2020-02-22 Thread Thomas Baumgart
tbaumgart added a comment. In D27582#616092 , @Abella wrote: > Next time I use kmymo...@kde.org mailing list. Chapter updates by KMyMoney team will be very welcome by Catalan team. The

D27575: Umbrello add mouseover tooltip information for UML elements in diagrams

2020-02-22 Thread John Hayes
jhayes retitled this revision from "Bug: 83444 Add mouseover tooltip information for UML elements in diagrams" to "Umbrello add mouseover tooltip information for UML elements in diagrams". jhayes edited the summary of this revision. REPOSITORY R139 Umbrello REVISION DETAIL

D27582: Documentation improveshttp: to https:, Review links and some menu items

2020-02-22 Thread Jack Ostroff
ostroffjh added a comment. Thanks for your help - these are things I have obviously missed, and will help me in future updates. This should be able to go into both master and 5.0 branch. REPOSITORY R261 KMyMoney BRANCH Documentation_improves (branched from master) REVISION DETAIL

D27582: Documentation improveshttp: to https:, Review links and some menu items

2020-02-22 Thread Antoni Bella Pérez
Abella added a comment. In D27582#615999 , @ostroffjh wrote: > Please note that the KMyMoney team (mainly myself) generally handles the doc editing for this application. Next time I use kmymo...@kde.org

D15580: New annotation toolbar

2020-02-22 Thread Nathaniel Graham
ngraham added a comment. See also https://community.kde.org/Infrastructure/GitLab REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid,

D27584: Umbrello add tooltips for UML elements

2020-02-22 Thread John Hayes
jhayes created this revision. jhayes added a reviewer: habacker. jhayes added a project: Umbrello. jhayes requested review of this revision. REVISION SUMMARY Add tooltips to Umbrello and change the strings to i18n(). This fixes Bug: 83444 TEST PLAN Insert UML objects into respective

D27582: Documentation improveshttp: to https:, Review links and some menu items

2020-02-22 Thread Jack Ostroff
ostroffjh accepted this revision. ostroffjh added a comment. This revision is now accepted and ready to land. Please note that the KMyMoney team (mainly myself) generally handles the doc editing for this application. However, all these changes look OK to me. Also note that about half the

D15580: New annotation toolbar

2020-02-22 Thread Simone Gaiarin
simgunz added a comment. When you create the merge request: - set the title to `WIP: title of merge request` to mark it as work in progress - push the commits as you work so you have a backup, can see the results of the CI tests and possibly receive feedbacks REPOSITORY R223 Okular

D15580: New annotation toolbar

2020-02-22 Thread Yuri Chornoivan
yurchor added a comment. > And someone needs to explain how to create merge requests on invent.kde.org. I tried three ways and failed, and unfortunately I can only find instructions for Phabricator. 1. Fork the repo with the "Fork" button here: https://invent.kde.org/kde/okular

D27582: Documentation improveshttp: to https:, Review links and some menu items

2020-02-22 Thread Antoni Bella Pérez
Abella added reviewers: habacker, yurchor. REPOSITORY R261 KMyMoney REVISION DETAIL https://phabricator.kde.org/D27582 To: Abella, #kmymoney, habacker, yurchor Cc: kde-doc-english, jhayes, brunourias, gennad, fbampaloukas, jefferyq, domson, ftonello, James, skadinna, mhubner, MayeulC,

D27582: Documentation improveshttp: to https:, Review links and some menu items

2020-02-22 Thread Antoni Bella Pérez
Abella created this revision. Abella added a reviewer: KMyMoney. Abella added projects: KMyMoney, Documentation. Herald added a subscriber: kde-doc-english. Abella requested review of this revision. REVISION SUMMARY First fixes from translation workflow TEST PLAN Validate links REPOSITORY

D15580: New annotation toolbar

2020-02-22 Thread David Hurka
davidhurka added a comment. In D15580#606022 , @aacid wrote: > In D15580#605913 , @davidhurka wrote: > > > In D15580#605611 , @simgunz wrote: > > > >

D27575: Bug: 83444 Add mouseover tooltip information for UML elements in diagrams

2020-02-22 Thread Luigi Toscano
ltoscano added a comment. I can't comment on the code, but the bug number should not be in the first line of the commit message. Please add it in a separate line using the syntax BUG: xx as described here:

D27575: Bug: 83444 Add mouseover tooltip information for UML elements in diagrams

2020-02-22 Thread Yuri Chornoivan
yurchor added a comment. All tooltips should be in i18n() to be translatable, not in QLatin1String and not in tr(). Thanks in advance for fixing this issue. REPOSITORY R139 Umbrello REVISION DETAIL https://phabricator.kde.org/D27575 To: jhayes, habacker Cc: yurchor,

D27575: Bug: 83444 Add mouseover tooltip information for UML elements in diagrams

2020-02-22 Thread John Hayes
jhayes retitled this revision from "Add mouseover tooltip information for UML elements in diagrams" to "Bug: 83444 Add mouseover tooltip information for UML elements in diagrams". REPOSITORY R139 Umbrello REVISION DETAIL https://phabricator.kde.org/D27575 To: jhayes, habacker Cc:

D27575: Add mouseover tooltip information for UML elements in diagrams

2020-02-22 Thread John Hayes
jhayes created this revision. jhayes added a reviewer: habacker. jhayes added a project: Umbrello. Herald added a subscriber: umbrello-devel. jhayes requested review of this revision. REVISION SUMMARY Add the mouseover tooltip popup descriptive information for each UML model element in each of