D29006: Allow to copy or move selection to the other split view

2020-05-01 Thread Méven Car
meven added inline comments. INLINE COMMENTS > dolphinmainwindow.cpp:1414 > paste->setIconText(i18nc("@action:inmenu Edit", "Paste")); > -paste->setWhatsThis(xi18nc("@info:whatsthis paste", "This copies the > items from " > +paste->setWhatsThis(xi18nc("@info:whatsthis paste", "This

D29353: Update copyright

2020-05-01 Thread Yuri Chornoivan
yurchor accepted this revision as: yurchor. yurchor added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R167 Krusader REVISION DETAIL https://phabricator.kde.org/D29353 To: gengisdave, #krusader, yurchor Cc: yurchor, kde-doc-english, #krusader, gennad, fba

D29353: Update copyright

2020-05-01 Thread Davide Gianforte
gengisdave created this revision. gengisdave added a reviewer: Krusader. gengisdave added a project: Krusader. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. gengisdave requested review of this revision. REVISION SUMMARY Update copyright years to 2020 TEST PL

[krusader] doc: Update documentation for file deletion

2020-05-01 Thread Davide Gianforte
Git commit 2ab9de1d6bc234cbc558edcdc21e301ad5075bbe by Davide Gianforte. Committed on 01/05/2020 at 22:48. Pushed by gengisdave into branch 'master'. Update documentation for file deletion Update the documentation to the correct file deletion shortcuts. Ctrl+Del does always the alternate delete

D29350: Update documentation for file deletion

2020-05-01 Thread Davide Gianforte
This revision was automatically updated to reflect the committed changes. Closed by commit R167:2ab9de1d6bc2: Update documentation for file deletion (authored by gengisdave). REPOSITORY R167 Krusader CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29350?vs=81703&id=81712 REVISION DET

D29350: Update documentation for file deletion

2020-05-01 Thread Toni Asensi Esteve
asensi accepted this revision. asensi added a comment. It's much better that way. Thanks, Davide! (and Yuri :-) ) REPOSITORY R167 Krusader REVISION DETAIL https://phabricator.kde.org/D29350 To: gengisdave, #krusader, yurchor, asensi Cc: asensi, yurchor, kde-doc-english, #krusader, gennad

D29006: Allow to copy or move selection to the other split view

2020-05-01 Thread Antonio Prcela
aprcela updated this revision to Diff 81708. aprcela marked 2 inline comments as done. aprcela added a comment. - Rename slotPasteJobResult to more generic slotJobResult - Added error check when copying to other view REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.

D29006: Allow to copy or move selection to the other split view

2020-05-01 Thread Antonio Prcela
aprcela added a comment. Done :) REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D29006 To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, gennad

D29350: Update documentation for file deletion

2020-05-01 Thread Yuri Chornoivan
yurchor accepted this revision. yurchor added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R167 Krusader REVISION DETAIL https://phabricator.kde.org/D29350 To: gengisdave, #krusader, yurchor Cc: yurchor, kde-doc-english, #krusader, gennad, fbampaloukas,

D29350: Update documentation for file deletion

2020-05-01 Thread Davide Gianforte
gengisdave edited the summary of this revision. REPOSITORY R167 Krusader REVISION DETAIL https://phabricator.kde.org/D29350 To: gengisdave, #krusader Cc: yurchor, kde-doc-english, #krusader, gennad, fbampaloukas, nmel, mjanczara, miroslavm, skadinna, janlepper, abika, martinkostolny, asensi

D29350: Update documentation for file deletion

2020-05-01 Thread Davide Gianforte
gengisdave created this revision. gengisdave added a reviewer: Krusader. gengisdave added a project: Krusader. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. gengisdave requested review of this revision. REVISION SUMMARY Update the documentation to the correct

D29006: Allow to copy or move selection to the other split view

2020-05-01 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > dolphinview.cpp:697 > +{ > +KIO::CopyJob* job = KIO::copy(selection.urlList(), destinationPanelUrl, > KIO::DefaultFlags); > +KJobWidgets::setWindow(job, this); Why is there no error handling for the copy job? It can fail too. (Try having /

D29006: Allow to copy or move selection to the other split view

2020-05-01 Thread Antonio Prcela
aprcela added a comment. @dfaure is it good now? Anyone found anything else to fix and/or improve? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D29006 To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure Cc: yurchor, kde-doc-english, dfaure, meven, kfm-de

[kmymoney/5.0] kmymoney/views: Allow plural form for XX day forecast

2020-05-01 Thread Thomas Baumgart
Git commit df474925e71a96959f0d12fdbfb8720e1975eee1 by Thomas Baumgart. Committed on 01/05/2020 at 12:40. Pushed by tbaumgart into branch '5.0'. Allow plural form for XX day forecast Summary: Currently KMyMoney doesn't allow plural form to translate this string. That doesn't translate well in som

[kmymoney/5.0] kmymoney: Added message contexts to support Korean translation

2020-05-01 Thread Thomas Baumgart
Git commit 187764863a426b95271b5f637f7ed6883f7e44ba by Thomas Baumgart. Committed on 01/05/2020 at 07:18. Pushed by tbaumgart into branch '5.0'. Added message contexts to support Korean translation GUI: M +1-1kmymoney/dialogs/kavailablecurrencydlg.ui M +1-1kmymoney/dialogs/kcur