yurchor requested changes to this revision.
yurchor added a comment.
This revision now requires changes to proceed.
Thanks in advance for fixing these minor typos.
INLINE COMMENTS
> details-categories.docbook:37
> + category menu item; select a parent in the tree
> + in the Categories view,
Git commit 1ceaaa38f6c750ae99fbff38d19f60d5e41720fa by Yuri Chornoivan.
Committed on 05/05/2020 at 05:53.
Pushed by yurchor into branch 'master'.
Add new option 'Folder size displays' to the docs
M +6-2doc/index.docbook
https://commits.kde.org/dolphin/1ceaaa38f6c750ae99fbff38d19f60d5e41
ostroffjh created this revision.
Herald added a project: Documentation.
Herald added a subscriber: kde-doc-english.
ostroffjh updated this revision to Diff 81940.
ostroffjh added a comment.
ostroffjh retitled this revision from "Force setting the file type to the one
selected in the filter" to "Up
gengisdave updated this revision to Diff 81923.
gengisdave added a comment.
Updated missing files
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29353?vs=81714&id=81923
REVISION DETAIL
https://phabricator.kde.org/D29353
AFFECTED FILES
CREDITS
doc/advanced-functions.docbook
aprcela updated this revision to Diff 81872.
aprcela added a comment.
- Rewrite so it's obvious that it is copying/moving to the inactive view
REPOSITORY
R318 Dolphin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29006?vs=81854&id=81872
BRANCH
arcpatch-D29006
REVISION DETAIL
broulik added inline comments.
INLINE COMMENTS
> dolphinmainwindow.cpp:943
> KJobWidgets::setWindow(statJob, this);
> statJob->exec();
> QUrl url = statJob->mostLocalUrl();
`exec()` on a job is generally bad, but looks like it was like this already?
> dolphinmainwindow.cpp:2289
>
aprcela edited the summary of this revision.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D29006
To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, azyx, nikolaik,
pberestov, iasensio, aprcela, fprice
aprcela edited the summary of this revision.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D29006
To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, azyx, nikolaik,
pberestov, iasensio, aprcela, fprice
aprcela updated this revision to Diff 81854.
aprcela added a comment.
- Merge branch 'master' of https://anongit.kde.org/dolphin into
arcpatch-D29006
REPOSITORY
R318 Dolphin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29006?vs=81850&id=81854
BRANCH
arcpatch-D29006
REVISION
aprcela marked an inline comment as done.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D29006
To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, azyx, nikolaik,
pberestov, iasensio, aprcela, fprice, g
aprcela marked an inline comment as done.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D29006
To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, azyx, nikolaik,
pberestov, iasensio, aprcela, fprice, g
aprcela marked an inline comment as done.
aprcela added inline comments.
INLINE COMMENTS
> aprcela wrote in dolphinview.cpp:1222
> Ok. I'm gonna make a separate patch via phabricator.
https://phabricator.kde.org/D29399
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D29
aprcela updated this revision to Diff 81850.
aprcela marked an inline comment as done.
aprcela added a comment.
- Revert "Instead of append, change the value to a simplifiedUrlList"
REPOSITORY
R318 Dolphin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29006?vs=81826&id=81850
BRA
aprcela marked an inline comment as done.
aprcela added inline comments.
INLINE COMMENTS
> meven wrote in dolphinview.cpp:1222
> No your individual commits are supposed to get squashed upon merging.
Ok. I'm gonna make a separate patch via phabricator.
REPOSITORY
R318 Dolphin
REVISION DETAIL
meven added inline comments.
INLINE COMMENTS
> aprcela wrote in dolphinview.cpp:1222
> It's in the commit 5359352b0ef1. Is that enough?
No your individual commits are supposed to get squashed upon merging.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D29006
To: aprc
asensi added a comment.
Davide, in order to simplify things, if you want you can apply the present
commit and later I can apply the suggested changes.
REPOSITORY
R167 Krusader
REVISION DETAIL
https://phabricator.kde.org/D29353
To: gengisdave, #krusader, yurchor, asensi
Cc: asensi, yurch
16 matches
Mail list logo