D29724: SendLaterAgent: merge libKF5SendLater library into the agent

mlaurent added inline comments. INLINE COMMENTS > mlaurent wrote in sendlaterutil_p.h:23 > not necessary no ? I think that we can remove this include no ? REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, f

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

kossebau created this revision. kossebau added reviewers: Frameworks, ochurlaud, ognarb. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY This patch makies kapidox work

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. +1 and also +1 for removing python2 support REPOSITORY R264 KApiDox BRANCH makedepworkwithpython3 REVISION DETAIL https://phabricator.kde.org/D29797 To: kossebau, #frameworks, ochur

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

cblack accepted this revision. REPOSITORY R264 KApiDox BRANCH makedepworkwithpython3 REVISION DETAIL https://phabricator.kde.org/D29797 To: kossebau, #frameworks, ochurlaud, ognarb, cblack Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, michaelh, ngrah

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

kossebau added a comment. Thanks for the (first) review :) Open questions I have are these: a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a fallback to load() otherwise? It was only introduced at a certain version of pyyaml b) by sup

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

cblack added a comment. In D29797#672263 , @kossebau wrote: > Thanks for the (first) review :) > > Open questions I have are these: > a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a fallba

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

ognarb added a comment. In D29797#672263 , @kossebau wrote: > Thanks for the (first) review :) > > Open questions I have are these: > a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a fallba

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

kossebau added a comment. I just applied the diff as-is to the working checkout of kapidox on the server, to see if the patch also works for the setup of the nightly run, other than my separate testing which might have missed any special environment setup. So tomorrow before noon CEST we sho