Re: [kde-doc-english] Review Request 124482: Search for required perl modules.

2015-07-27 Thread Alex Merry
/CMakeLists.txt:4 (kdoctools_encode_uri) -- Configuring incomplete, errors occurred! With perl-uri installed, the REQUIRED packages found list includes: * PerlModules , http://www.cpan.org Thanks, Alex Merry ___ kde-doc-english mailing list kde-doc

[kde-doc-english] Review Request 122751: Let ecm_configure_package_config_file manage path variables.

2015-02-28 Thread Alex Merry
://git.reviewboard.kde.org/r/122751/diff/ Testing --- Ran cmake with and without absolute KDE_INSTALL_DATADIR path set. Checked generated KF5DocToolsConfig.cmake by eye. Thanks, Alex Merry -- next part -- An HTML attachment was scrubbed... URL: http://mail.kde.org/pipermail/kde

[kde-doc-english] Review Request 122751: Let ecm_configure_package_config_file manage path variables.

2015-02-28 Thread Alex Merry
KF5DocToolsConfig.cmake.in eff3d70ae2dcd8711e340306a7fbd1f2d6ca3ece Diff: https://git.reviewboard.kde.org/r/122751/diff/ Testing --- Ran cmake with and without absolute KDE_INSTALL_DATADIR path set. Checked generated KF5DocToolsConfig.cmake by eye. Thanks, Alex Merry

[kde-doc-english] [kdesignerplugin] docs/kgendesignerplugin: Improve the kgendesignerplugin man page

2014-06-01 Thread Alex Merry
Git commit 06639fdb89820bc62805a9ae680f97d5e39db4dd by Alex Merry. Committed on 28/05/2014 at 15:44. Pushed by alexmerry into branch 'master'. Improve the kgendesignerplugin man page The options now match what is actually accepted, the authors section properly reflects the authors of the man

[kde-doc-english] Review Request 117985: frameworks/kjs: add missing man page docbook

2014-05-29 Thread Alex Merry
On May 5, 2014, 7:17 a.m., Kevin Ottens wrote: IIRC that was intentional as to not have kjs depend on kdoctools. Hrm. Distros like Debian aren't going to be super-happy about this. And KJS is officially a porting aid, so I'm not sure bumping it to tier 3 is that big of an issue (especially

[kde-doc-english] Review Request 117963: Install the English fallback for license translations, simplify the installation of language-specific files

2014-05-03 Thread Alex Merry
/117963/#comment39866 Is there any reason why those files wouldn't exist? If not, why the if(EXISTS)? Also, the indentation is different to the earlier part of the file. - Alex Merry On May 2, 2014, 10:01 p.m., Luigi Toscano wrote

[kde-doc-english] Review Request 117963: Install the English fallback for license translations, simplify the installation of language-specific files

2014-05-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117963/#review57209 --- Ship it! Ship It! - Alex Merry On May 3, 2014, 3:47 p.m

[kde-doc-english] Review Request 117805: Introduce kdoctools_install()

2014-04-30 Thread Alex Merry
/117805/#comment39712 footool.2.docbook - footool.conf.5.docbook KF5DocToolsMacros.cmake https://git.reviewboard.kde.org/r/117805/#comment39713 I personally prefer to use lowercase for function names everywhere, including declarations. - Alex Merry On April 27, 2014, 6:50 p.m., Aur

[kde-doc-english] [kdoctools] src/customization: Update install-compile.docbook translations to not reference KDE4

2014-04-25 Thread Alex Merry
Git commit 5e67e4c6c112fce2c9b1f131e920e2f86641e572 by Alex Merry. Committed on 24/04/2014 at 21:39. Pushed by alexmerry into branch 'master'. Update install-compile.docbook translations to not reference KDE4 These are links to techbase. Link text that was already English was just updated

[kde-doc-english] Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-25 Thread Alex Merry
/entities/install-compile.docbook 08561cda904d6110b99de087e4b82e4ddd57ebe7 src/customization/th/entities/install-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry -- next part

[kde-doc-english] Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-24 Thread Alex Merry
-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry -- next part -- An HTML attachment was scrubbed... URL: http://mail.kde.org/pipermail/kde-doc-english/attachments

[kde-doc-english] Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-24 Thread Alex Merry
-compile.docbook 08561cda904d6110b99de087e4b82e4ddd57ebe7 src/customization/th/entities/install-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry -- next part -- An HTML attachment

[kde-doc-english] Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-24 Thread Alex Merry
08561cda904d6110b99de087e4b82e4ddd57ebe7 src/customization/th/entities/install-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry -- next part -- An HTML attachment

[kde-doc-english] [kio] docs/kioslave/help/documentationnotfound: Update documentation not found docbook

2014-04-13 Thread Alex Merry
Git commit 32ca488fc2cfadd896a52fd86e814f82a4b4 by Alex Merry. Committed on 02/04/2014 at 11:24. Pushed by alexmerry into branch 'master'. Update documentation not found docbook REVIEW: 117330 M +34 -31 docs/kioslave/help/documentationnotfound/index.docbook http://commits.kde.org/kio

[kde-doc-english] [kservice] docs/kbuildsycoca5: Update the kbuildsycoca5 man page

2014-04-12 Thread Alex Merry
Git commit cec317d944ffb29c7d8c4b866e62a38c2dc7e79c by Alex Merry. Committed on 01/04/2014 at 23:32. Pushed by alexmerry into branch 'master'. Update the kbuildsycoca5 man page REVIEW: 117320 M +62 -110 docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook http://commits.kde.org/kservice

[kde-doc-english] [kservice] docs: Remove the kdeinit5 man page

2014-04-10 Thread Alex Merry
Git commit b80e0b63b04a82dca15a384805003efa255ad9d8 by Alex Merry. Committed on 10/04/2014 at 18:06. Pushed by alexmerry into branch 'master'. Remove the kdeinit5 man page This has now been moved to the kinit repository. M +0-1docs/CMakeLists.txt D +0-1docs/kdeinit5

[kde-doc-english] [sonnet] docs: Update the docbook

2014-04-07 Thread Alex Merry
Git commit 211a25365b1b8c416df753208dce6cf19a6d4e3d by Alex Merry. Committed on 02/04/2014 at 11:03. Pushed by alexmerry into branch 'master'. Update the docbook Update the releaseinfo, and change the abstract to reflect Sonnet's status as a framework. REVIEW: 117328 M +8-7docs

[kde-doc-english] [kservice] docs/desktoptojson: Improve the desktoptojson man page

2014-04-02 Thread Alex Merry
Git commit acea538e458015ee8ed4e760f802673d1b2e by Alex Merry. Committed on 02/04/2014 at 10:44. Pushed by alexmerry into branch 'master'. Improve the desktoptojson man page REVIEW: 117325 M +53 -42 docs/desktoptojson/man-desktoptojson.8.docbook http://commits.kde.org/kservice

[kde-doc-english] Review Request 116980: Update the kded5 man page

2014-03-27 Thread Alex Merry
--- Built, installed, visually inspected man page. Thanks, Alex Merry -- next part -- An HTML attachment was scrubbed... URL: http://mail.kde.org/pipermail/kde-doc-english/attachments/20140327/2d90ba97/attachment.html

[kde-doc-english] [kded] docs/kded5: Update the kded5 man page

2014-03-27 Thread Alex Merry
Git commit e5ae0f49427d30151265347299e2ff617ba8 by Alex Merry. Committed on 22/03/2014 at 17:49. Pushed by alexmerry into branch 'master'. Update the kded5 man page REVIEW: 116980 M +47 -239 docs/kded5/man-kded5.8.docbook http://commits.kde.org/kded

[kde-doc-english] Review Request 116980: Update the kded5 man page

2014-03-25 Thread Alex Merry
--- Built, installed, visually inspected man page. Thanks, Alex Merry -- next part -- An HTML attachment was scrubbed... URL: http://mail.kde.org/pipermail/kde-doc-english/attachments/20140325/f5b511cf/attachment.html

[kde-doc-english] Review Request 117061: Explicitly state link interface for libKF5XsltKde

2014-03-25 Thread Alex Merry
this library, according to the comment). Thanks, Alex Merry -- next part -- An HTML attachment was scrubbed... URL: http://mail.kde.org/pipermail/kde-doc-english/attachments/20140325/b8a215a4/attachment.html

[kde-doc-english] Review Request 117061: Explicitly state link interface for libKF5XsltKde

2014-03-25 Thread Alex Merry
://git.reviewboard.kde.org/r/117061/diff/ Testing --- Builds and installs. So does KIO (which apparently uses this library, according to the comment). Thanks, Alex Merry -- next part -- An HTML attachment was scrubbed... URL: http://mail.kde.org/pipermail/kde-doc-english/attachments

[kde-doc-english] Review Request 116980: Update the kded5 man page

2014-03-23 Thread Alex Merry
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/#review53796 --- On March 22, 2014, 5:53 p.m., Alex Merry wrote: --- This is an automatically generated e

[kde-doc-english] Review Request 116980: Update the kded5 man page

2014-03-23 Thread Alex Merry
--- Built, installed, visually inspected man page. Thanks, Alex Merry -- next part -- An HTML attachment was scrubbed... URL: http://mail.kde.org/pipermail/kde-doc-english/attachments/20140323/1af40719/attachment.html

[kde-doc-english] Review Request 116979: Rename the bootstrap CMake variable

2014-03-22 Thread Alex Merry
KF5DocToolsMacros.cmake 76477845a505cf4bc5c76c95e03b3d6e2bfc19e9 Diff: https://git.reviewboard.kde.org/r/116979/diff/ Testing --- KDocTools configures, builds and installs. Thanks, Alex Merry -- next part -- An HTML attachment was scrubbed... URL: http://mail.kde.org

[kde-doc-english] Review Request 116980: Update the kded5 man page

2014-03-22 Thread Alex Merry
/ Testing --- Built, installed, visually inspected man page. Thanks, Alex Merry -- next part -- An HTML attachment was scrubbed... URL: http://mail.kde.org/pipermail/kde-doc-english/attachments/20140322/4e8299a6/attachment.html

[kde-doc-english] Review Request 116979: Rename the bootstrap CMake variable

2014-03-22 Thread Alex Merry
with their own macros. Diffs - CMakeLists.txt 700a12648dda8d5cbdce1947f02a7d40aafddb01 KF5DocToolsMacros.cmake 76477845a505cf4bc5c76c95e03b3d6e2bfc19e9 Diff: https://git.reviewboard.kde.org/r/116979/diff/ Testing --- KDocTools configures, builds and installs. Thanks, Alex Merry

[kde-doc-english] Review Request 115956: More generic (renamed) KDocBookXML4.cmake

2014-02-23 Thread Alex Merry
to find_package(), and it will find that DTD version, otherwise it will find 4.2. - Alex Merry On Feb. 22, 2014, 6:19 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https

[kde-doc-english] Review Request 115956: More generic (renamed) KDocBookXML4.cmake

2014-02-23 Thread Alex Merry
/r/115956/#comment35589 You'll need to include the FeatureSummary module for this. cmake/FindDocBookXSL.cmake https://git.reviewboard.kde.org/r/115956/#comment35590 Likewise, FeatureSummary is needed - Alex Merry On Feb. 23, 2014, 2:34 p.m., Luigi Toscano wrote

[kde-doc-english] Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

2014-02-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/#review50594 --- Ship it! Ship It! - Alex Merry On Feb. 23, 2014, 3:02 p.m

[kde-doc-english] Review Request 115876: More generic DocBookXML - DocBookXML4

2014-02-22 Thread Alex Merry
On Feb. 21, 2014, 7:47 p.m., Luigi Toscano wrote: The files have been moved to kdoctools, should I open a new review against the kdoctools component or can I get a shipit here? :) I thought I'd already made this reply, but let's try again... (maybe I did it on another RR?) I would

[kde-doc-english] Review Request 115876: More generic DocBookXML - DocBookXML4

2014-02-22 Thread Alex Merry
On Feb. 21, 2014, 7:47 p.m., Luigi Toscano wrote: The files have been moved to kdoctools, should I open a new review against the kdoctools component or can I get a shipit here? :) Alex Merry wrote: I thought I'd already made this reply, but let's try again... (maybe I did

[kde-doc-english] Review Request 115876: More generic DocBookXML - DocBookXML4

2014-02-22 Thread Alex Merry
On Feb. 21, 2014, 7:47 p.m., Luigi Toscano wrote: The files have been moved to kdoctools, should I open a new review against the kdoctools component or can I get a shipit here? :) Alex Merry wrote: I thought I'd already made this reply, but let's try again... (maybe I did

[kde-doc-english] Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

2014-02-21 Thread Alex Merry
*.cmake from $PREFIX/share/ECM/find-modules, and a clean configure, build, install still works. Thanks, Alex Merry -- next part -- An HTML attachment was scrubbed... URL: http://mail.kde.org/pipermail/kde-doc-english/attachments/20140221/4b253aeb/attachment.html

[kde-doc-english] Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

2014-02-19 Thread Alex Merry
. Thanks, Alex Merry -- next part -- An HTML attachment was scrubbed... URL: http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/f15428fa/attachment.html

[kde-doc-english] Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

2014-02-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/#review50219 --- On Feb. 19, 2014, 12:47 p.m., Alex Merry wrote

[kde-doc-english] Review Request 115744: The WIN32 part of this if statement doesn't seem to work - drop it

2014-02-19 Thread Alex Merry
/#comment35372 This warning no longer applies, right? In that, since we no longer have a monolithic kdelibs, we can just use relative paths in the xsl files. - Alex Merry On Feb. 14, 2014, 12:29 a.m., Alexander Richardson wrote

[kde-doc-english] Review Request 115818: Support more catalogs and reduce code duplication

2014-02-19 Thread Alex Merry
be better as two separate commits (from the POV of git bisect), but I'm not going to push that. - Alex Merry On Feb. 16, 2014, 8:16 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https

[kde-doc-english] Review Request 115744: The WIN32 part of this if statement doesn't seem to work - drop it

2014-02-19 Thread Alex Merry
On Feb. 19, 2014, 2:52 p.m., Alex Merry wrote: src/CMakeLists.txt, lines 63-67 https://git.reviewboard.kde.org/r/115744/diff/1/?file=243985#file243985line63 This warning no longer applies, right? In that, since we no longer have a monolithic kdelibs, we can just use relative

[kde-doc-english] Review Request 115876: More generic DocBookXML - DocBookXML4

2014-02-18 Thread Alex Merry
? If not, it should probably just move to that module. Even if kde4support ends up using it, I don't view that as a reason to put it in ECM. - Alex Merry On Feb. 18, 2014, 10:52 p.m., Luigi Toscano wrote: --- This is an automatically generated e

[kde-doc-english] Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-31 Thread Alex Merry
On Jan. 31, 2014, 6:21 p.m., Alex Merry wrote: If this review is obsolete, can you discard it, please? David Narv?ez wrote: I'm waiting for an answer to my question above. I would go with Luigi's suggestion. If we determine later that it might be useful beyond KDocTools, we can

[kde-doc-english] Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-19 Thread Alex Merry
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved

[kde-doc-english] Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-18 Thread Alex Merry
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved

[kde-doc-english] Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-17 Thread Alex Merry
/115077/#comment33794 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to kde4support. - Alex Merry On Jan. 17, 2014, 3:14 p.m., David Narv?ez wrote